[PATCH 02/20] qemu: Remove 'removable' field from 'qemuDomainDiskPrivate'

Peter Krempa via Devel posted 20 patches 3 days, 10 hours ago
[PATCH 02/20] qemu: Remove 'removable' field from 'qemuDomainDiskPrivate'
Posted by Peter Krempa via Devel 3 days, 10 hours ago
From: Peter Krempa <pkrempa@redhat.com>

The field is only set, but never read. Drop it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.h  | 2 --
 src/qemu/qemu_process.c | 1 -
 2 files changed, 3 deletions(-)

diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 095c36b8ac..20d6bd316c 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -288,9 +288,7 @@ struct _qemuDomainDiskPrivate {
     virStorageSource *migrSource; /* disk source object used for NBD migration */
     bool migrationslice; /* storage slice was added for migration purposes */

-    /* information about the device */
     bool tray; /* device has tray */
-    bool removable; /* device media can be removed/changed */

     char *qomName; /* QOM path of the disk (also refers to the block backend) */
     char *nodeCopyOnRead; /* nodename of the disk-wide copy-on-read blockdev layer */
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index c5b2a5fda8..fba1dbe844 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -9555,7 +9555,6 @@ qemuProcessRefreshDiskProps(virDomainDiskDef *disk,
         }
     }

-    diskpriv->removable = info->removable;
     diskpriv->tray = info->tray;
 }

-- 
2.53.0
Re: [PATCH 02/20] qemu: Remove 'removable' field from 'qemuDomainDiskPrivate'
Posted by Ján Tomko via Devel 3 days, 10 hours ago
On a Thursday in 2026, Peter Krempa via Devel wrote:
>From: Peter Krempa <pkrempa@redhat.com>
>
>The field is only set, but never read. Drop it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_domain.h  | 2 --
> src/qemu/qemu_process.c | 1 -
> 2 files changed, 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano