From nobody Mon Feb 9 06:02:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1770303578; cv=none; d=zohomail.com; s=zohoarc; b=hx2IzN+8IOXOyG1hsWVPWvRWnfabXHIyhvdkqZI3UuiN/2rY+JvsW4VyXGHtq8CT1aA1BZWYwQNe2wzaqcm4iwiaJ4ooNzUnIZSZRfQHmqThNCd66EPDmfA2QKqkwAQu2jRI2XFOjJ+TCoINYacJ66njp+dE7eYcP3XF11kZIm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770303578; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=oEZ5o+QtzWVNwiY10IDl81eJ9ft5BjqICeBx07L7xMc=; b=KUXZZ/eU/FKWBbSwuPHTRgewxSivq+SXTZdkfP6CO5zRrtHD3kyRf7cJX91lGA9KLvbCCxlGeK4v5ZRGzaHGzCC1Vfz9n0bICFU8pmnT0j/+csfEjnDyqLpFHh94UnZ8BisgFAgekjR6LXH7XjnHX9zHWtZk3BIXkK9yv4ApG44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1770303578021298.23912155272035; Thu, 5 Feb 2026 06:59:38 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6467143DBD; Thu, 5 Feb 2026 09:59:37 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id F229F41A12; Thu, 5 Feb 2026 09:55:46 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1386B41BEA; Thu, 5 Feb 2026 09:55:41 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AFAD1418C8 for ; Thu, 5 Feb 2026 09:55:36 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-Wn4YF1BEOpGJ928V88_Bbw-1; Thu, 05 Feb 2026 09:55:33 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D970818001D1 for ; Thu, 5 Feb 2026 14:55:32 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.3]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2B9E118003F6 for ; Thu, 5 Feb 2026 14:55:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770303336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEZ5o+QtzWVNwiY10IDl81eJ9ft5BjqICeBx07L7xMc=; b=HTpX74gVx7zuDiijkWVuAyQWFmQsYTpEb4hb3ezzxj82NQ+Zx/1ObrvaSLTYMUHCPqIDsS P7yjofeqmO4sD1SuUgC8jcw0Y5MwHCuLyd1yzEpvcf8+5FViyIzA4usxnnYMT/0VBU009J D8NQni9kZkVnb4RTWwfX+Wtfr3/WIeo= X-MC-Unique: Wn4YF1BEOpGJ928V88_Bbw-1 X-Mimecast-MFC-AGG-ID: Wn4YF1BEOpGJ928V88_Bbw_1770303333 To: devel@lists.libvirt.org Subject: [PATCH 02/20] qemu: Remove 'removable' field from 'qemuDomainDiskPrivate' Date: Thu, 5 Feb 2026 15:55:10 +0100 Message-ID: <45de04c72a083aa0bab8daa5fda8e599cabe2c8c.1770303113.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: v2Lh9Hglm1q3eaW2wq61q0s0jhnTTsoBVz0oitpIvgE_1770303333 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WX4LD6KIROGGOC735D3SVDHCYJSDSQKB X-Message-ID-Hash: WX4LD6KIROGGOC735D3SVDHCYJSDSQKB X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1770303580680154101 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The field is only set, but never read. Drop it. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_domain.h | 2 -- src/qemu/qemu_process.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 095c36b8ac..20d6bd316c 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -288,9 +288,7 @@ struct _qemuDomainDiskPrivate { virStorageSource *migrSource; /* disk source object used for NBD migra= tion */ bool migrationslice; /* storage slice was added for migration purposes= */ - /* information about the device */ bool tray; /* device has tray */ - bool removable; /* device media can be removed/changed */ char *qomName; /* QOM path of the disk (also refers to the block backe= nd) */ char *nodeCopyOnRead; /* nodename of the disk-wide copy-on-read blockd= ev layer */ diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c5b2a5fda8..fba1dbe844 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9555,7 +9555,6 @@ qemuProcessRefreshDiskProps(virDomainDiskDef *disk, } } - diskpriv->removable =3D info->removable; diskpriv->tray =3D info->tray; } --=20 2.53.0