[PATCH 4/4] qemuDomainSetThrottleGroup: Don't put group name into the 'tunable' event twice

Peter Krempa via Devel posted 4 patches 1 week, 6 days ago
[PATCH 4/4] qemuDomainSetThrottleGroup: Don't put group name into the 'tunable' event twice
Posted by Peter Krempa via Devel 1 week, 6 days ago
From: Peter Krempa <pkrempa@redhat.com>

'qemuDomainSetBlockIoTuneFields' already populates the contents of the
VIR_DOMAIN_EVENT_ID_TUNABLE params with the group name so there's no
need to do it explicitly. We'd report the group name twice:

 event 'tunable' for domain 'cd':
	blkdeviotune.group_name: asdf
	blkdeviotune.total_bytes_sec: 1234
	blkdeviotune.group_name: asdf

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_driver.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9addad3b9e..cdd333c882 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -20387,10 +20387,6 @@ qemuDomainSetThrottleGroup(virDomainPtr dom,
     if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0)
         goto endjob;

-    if (virTypedParamsAddString(&eventParams, &eventNparams, &eventMaxparams,
-                                VIR_DOMAIN_TUNABLE_BLKDEV_GROUP_NAME, groupname) < 0)
-        goto endjob;
-
     if (qemuDomainSetBlockIoTuneFields(&info,
                                        params,
                                        nparams,
-- 
2.52.0