From nobody Mon Feb 2 07:31:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1768814262; cv=none; d=zohomail.com; s=zohoarc; b=ia9xufbJuNIhec4lpGC+pt/lKx73fw9seqTbuhVMB0TWhpLReSCbGy46G6jV4dchlWB50JVOHL2SjnKOHYhjYj1B39QTRI8RJ6wQ9AnDRbiBkEdYeMA5Ig+OB7W+6tJKllj/0Wvi61WTAOFRz9RHdMJvFe8BSvr/K9qojBkHmJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768814262; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=bgsIOpCFvpfM8eKd+/Ia0l6OshOxipO9Jui7uzTZWtw=; b=igvlBKisLFrmCh2oJS+ZKgbpQnoKK8E9HIETU+bKYSXkQ/+h0lelv8ydvNd8loVoSWBcnU/oycJRmAiZwYhiqUGVmwyT0ld3ya7ug/BiJ9z5uqDFjbeN9iiX/TneKyldX4v7yIXg3K7wJg3dPfvoq0lsv8JBPZnVsoTX5xMr0JA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1768814262453911.7145179914974; Mon, 19 Jan 2026 01:17:42 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 84F0C419C4; Mon, 19 Jan 2026 04:17:41 -0500 (EST) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 2C8F543ECB; Mon, 19 Jan 2026 04:13:04 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7AFDF4199F; Mon, 19 Jan 2026 04:13:00 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7E0DE419DD for ; Mon, 19 Jan 2026 04:12:54 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-c5IBYPWeOSCG20CwbxzwVw-1; Mon, 19 Jan 2026 04:12:52 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A04CC1956053 for ; Mon, 19 Jan 2026 09:12:51 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DFB3719560A7 for ; Mon, 19 Jan 2026 09:12:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768813974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgsIOpCFvpfM8eKd+/Ia0l6OshOxipO9Jui7uzTZWtw=; b=BhDN+Whai2FGLeBjthoQQpr05rpWtZChAnioVYROQ1Sc4pbzzxqtjiHCP+jvDYxWLABLQZ pkg+Cpte6Y0rg1Qt8yUDRTm+kul/9IclevmAP7bPdrF0/icjZ4vGKut/bbG+hkgMoNFvQg DX15uv5GPgSwEbwsFSoqv8POGm/mczA= X-MC-Unique: c5IBYPWeOSCG20CwbxzwVw-1 X-Mimecast-MFC-AGG-ID: c5IBYPWeOSCG20CwbxzwVw_1768813971 To: devel@lists.libvirt.org Subject: [PATCH 4/4] qemuDomainSetThrottleGroup: Don't put group name into the 'tunable' event twice Date: Mon, 19 Jan 2026 10:12:44 +0100 Message-ID: <9eb1530d13f21ed43d58863755e79ba161fb9c44.1768813932.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TV2BKOGyerglVOeFROODjMtJKAV-6Gkt_5EHORmiQTs_1768813971 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CVDQZFGII4FY62VNEEEABSRMJ7XMRVKW X-Message-ID-Hash: CVDQZFGII4FY62VNEEEABSRMJ7XMRVKW X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1768814263676158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa 'qemuDomainSetBlockIoTuneFields' already populates the contents of the VIR_DOMAIN_EVENT_ID_TUNABLE params with the group name so there's no need to do it explicitly. We'd report the group name twice: event 'tunable' for domain 'cd': blkdeviotune.group_name: asdf blkdeviotune.total_bytes_sec: 1234 blkdeviotune.group_name: asdf Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9addad3b9e..cdd333c882 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20387,10 +20387,6 @@ qemuDomainSetThrottleGroup(virDomainPtr dom, if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0) goto endjob; - if (virTypedParamsAddString(&eventParams, &eventNparams, &eventMaxpara= ms, - VIR_DOMAIN_TUNABLE_BLKDEV_GROUP_NAME, grou= pname) < 0) - goto endjob; - if (qemuDomainSetBlockIoTuneFields(&info, params, nparams, --=20 2.52.0