[PATCH 1/2] virDomainDiskDefCheckABIStability: Add missing check for 'removable' property

Peter Krempa via Devel posted 2 patches 2 weeks, 6 days ago
[PATCH 1/2] virDomainDiskDefCheckABIStability: Add missing check for 'removable' property
Posted by Peter Krempa via Devel 2 weeks, 6 days ago
From: Peter Krempa <pkrempa@redhat.com>

The 'removable' state is guest-visible.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d2dea6952e..15d5cd9d80 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20845,6 +20845,14 @@ virDomainDiskDefCheckABIStability(virDomainDiskDef *src,
         return false;
     }

+    if (src->removable != dst->removable) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target disk 'removable' property %1$s does not match source %2$s"),
+                       virTristateSwitchTypeToString(dst->removable),
+                       virTristateSwitchTypeToString(src->removable));
+        return false;
+    }
+
     if (src->queues != dst->queues) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("Target disk queue count %1$u does not match source %2$u"),
-- 
2.51.1