From nobody Fri Dec 12 14:08:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763733832; cv=none; d=zohomail.com; s=zohoarc; b=jcZj4fTdyH/ZHqGj3udhBasWU/em+/a6TXdUHx0s8WQIzCjQeguZ5TF0SkfZGBAS7D8poPl4OccOaG0d9XvGUFjnaKNgRStLax6FsMHVwUXodyKrK1VJHEXR8BfTH3//UruCBbsH8CU3wj70iJScByPdD1wwDa7nS73uq6bBf5I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763733832; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=S6PMBqgt2hkWufHtPNuXYearlltEjHVNqA3fqiEKaHo=; b=UtpQgQiBrCMJNVej76AqcKj//qF6/AY3C/bMsEw7VDLhB0Z0uD/mzh7v5tCGz5SXaTfUAvz6yLdhp61r/ptuMcBXqNABIjrEe8MrBOzhdfTtNhZQdLYKm6/ikGgiFTKEH32LH+psAmc+0USIbFKwAWx9MqRxhwUTrXgDoNXYCaM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763733831151298.8373643542917; Fri, 21 Nov 2025 06:03:51 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 522C1442B9; Fri, 21 Nov 2025 09:03:48 -0500 (EST) Received: from [172.19.199.56] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 7BC6044379; Fri, 21 Nov 2025 09:01:43 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4F1B83F320; Fri, 21 Nov 2025 09:01:23 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D994D44151 for ; Fri, 21 Nov 2025 09:01:21 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-_LzR2rzwPHmj44UtacMv-Q-1; Fri, 21 Nov 2025 09:01:19 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB871180ACC2 for ; Fri, 21 Nov 2025 14:01:17 +0000 (UTC) Received: from speedmetal.openshiftapps.com (unknown [10.45.242.12]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1956D180049F for ; Fri, 21 Nov 2025 14:01:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763733681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S6PMBqgt2hkWufHtPNuXYearlltEjHVNqA3fqiEKaHo=; b=eGOpxWm7AnTq1ZcMzw5yL9wOWqnXUlVJFWPWbYFclfbFHeoKHT4G/lrhka51LmrPIQW+4w xH8MNQP7JFJeE+G7WiEAR04uKOiYy7PwIb+iHgMlkqJQC7aFcGAxiTETofb9m1nFVVFjN0 cb6BcZREXIoL2RdTDSDNxbzipQpSQ0g= X-MC-Unique: _LzR2rzwPHmj44UtacMv-Q-1 X-Mimecast-MFC-AGG-ID: _LzR2rzwPHmj44UtacMv-Q_1763733679 To: devel@lists.libvirt.org Subject: [PATCH 1/2] virDomainDiskDefCheckABIStability: Add missing check for 'removable' property Date: Fri, 21 Nov 2025 15:01:13 +0100 Message-ID: <20b478177b2ce5e6ddf6a6acc0ff548130dbad68.1763733595.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hD-7VJzPs39rkxPRLMtEKINpXXk6_labg-WyO4gABeM_1763733679 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RWWSEQKQCRD3PKNU3WPS5AHTILP5NTSI X-Message-ID-Hash: RWWSEQKQCRD3PKNU3WPS5AHTILP5NTSI X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763733835280018900 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The 'removable' state is guest-visible. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d2dea6952e..15d5cd9d80 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20845,6 +20845,14 @@ virDomainDiskDefCheckABIStability(virDomainDiskDef= *src, return false; } + if (src->removable !=3D dst->removable) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target disk 'removable' property %1$s does not m= atch source %2$s"), + virTristateSwitchTypeToString(dst->removable), + virTristateSwitchTypeToString(src->removable)); + return false; + } + if (src->queues !=3D dst->queues) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target disk queue count %1$u does not match sour= ce %2$u"), --=20 2.51.1