[PATCH 1/4] selinux: Match remember/recall arguments for SavedStateLabel

Cole Robinson via Devel posted 4 patches 1 week, 2 days ago
[PATCH 1/4] selinux: Match remember/recall arguments for SavedStateLabel
Posted by Cole Robinson via Devel 1 week, 2 days ago
virSecuritySELinuxSetSavedStateLabel uses remember=false, but
virSecuritySELinuxRestoreSavedStateLabel uses recall=true.

This doesn't cause problems in practice, just some redundant xattr
calls. But Set and Restore calls should be matched here.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/security/security_selinux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index fa5d1568eb..19e550460c 100644
--- a/src/security/security_selinux.c
+++ b/src/security/security_selinux.c
@@ -2631,7 +2631,7 @@ virSecuritySELinuxRestoreSavedStateLabel(virSecurityManager *mgr,
     if (!secdef || !secdef->relabel)
         return 0;
 
-    return virSecuritySELinuxRestoreFileLabel(mgr, savefile, true);
+    return virSecuritySELinuxRestoreFileLabel(mgr, savefile, false);
 }
 
 
-- 
2.51.1