From nobody Fri Nov 21 10:10:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1762882880; cv=none; d=zohomail.com; s=zohoarc; b=KE2vRQ88oZoMhZpYw76D1JqV4xyMQw2u38ci6Si2SVmcRk1shaHqVLGM7leDAdftZw1KTDg8RXC6gPgHFyX8IPVshFGW43tmT56MfsWc4drwFl8PJ6wZU++fN/lmCrwQahuN6tpxvreXFWTwa1LroaMFrPpWdYlnAfGc6WReMME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762882880; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=dJ7tDjxbKwdJROg8Zwjk/htjK551lq+uB17r6hUFIxk=; b=NJ/I9HQ6T5BLT/2qAQYBC9QEf7aMCxIVV9G0EXVhSsXAKiw+v5Pk/JZTmqVboeAk0GxPja+X0BH5JJNLQBSLtc+4FL0wsa77cz/Q+BdrM10RTXzyMTVWokKIE8hzPE0ILgw4EznG5Mm382KrhGyJqwAVop3KCwa9lgPm5aPfi2k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 176288288004332.78764199331795; Tue, 11 Nov 2025 09:41:20 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id DDA5144764; Tue, 11 Nov 2025 12:41:18 -0500 (EST) Received: from [172.19.199.29] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0DA0644620; Tue, 11 Nov 2025 12:40:22 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id C6CAE4417B; Tue, 11 Nov 2025 12:40:04 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A1C3B44151 for ; Tue, 11 Nov 2025 12:40:03 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-6VO17LVZN0CjSxNX3Uw-mA-1; Tue, 11 Nov 2025 12:40:01 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1867F18002C2 for ; Tue, 11 Nov 2025 17:40:01 +0000 (UTC) Received: from colepc.home (unknown [10.22.82.11]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6C697195608E; Tue, 11 Nov 2025 17:40:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762882803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJ7tDjxbKwdJROg8Zwjk/htjK551lq+uB17r6hUFIxk=; b=WrIplSHc2glMcKNgZorZqSltm+/X4Ky4cyyjl7t0fNhb22qepB50GQm0KT/e8mUPGoVRYY C9RfNddhVoficjwu4jIxzW9mHqpzxno+nhXNOFKPXreJ2b1S/COljX47cjECBR32kwtE4U Bjt3AvFnTJsczm3HnLYpAkmmAyQhZxc= X-MC-Unique: 6VO17LVZN0CjSxNX3Uw-mA-1 X-Mimecast-MFC-AGG-ID: 6VO17LVZN0CjSxNX3Uw-mA_1762882801 To: devel@lists.libvirt.org Subject: [PATCH 1/4] selinux: Match remember/recall arguments for SavedStateLabel Date: Tue, 11 Nov 2025 12:39:53 -0500 Message-ID: <1fdac215dc9d3164ef594a589ea02a761853dca6.1762881174.git.crobinso@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hb4KRQKphmC4X-7qY3rp3kgfzZWNXzEj1XG_91TDlfo_1762882801 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WOOH34J77NN6A7FJ6ZYU5QRSUEMH52T2 X-Message-ID-Hash: WOOH34J77NN6A7FJ6ZYU5QRSUEMH52T2 X-MailFrom: crobinso@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Cole Robinson X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Cole Robinson via Devel Reply-To: Cole Robinson X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1762882883227158500 Content-Type: text/plain; charset="utf-8" virSecuritySELinuxSetSavedStateLabel uses remember=3Dfalse, but virSecuritySELinuxRestoreSavedStateLabel uses recall=3Dtrue. This doesn't cause problems in practice, just some redundant xattr calls. But Set and Restore calls should be matched here. Signed-off-by: Cole Robinson --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinu= x.c index fa5d1568eb..19e550460c 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -2631,7 +2631,7 @@ virSecuritySELinuxRestoreSavedStateLabel(virSecurityM= anager *mgr, if (!secdef || !secdef->relabel) return 0; =20 - return virSecuritySELinuxRestoreFileLabel(mgr, savefile, true); + return virSecuritySELinuxRestoreFileLabel(mgr, savefile, false); } =20 =20 --=20 2.51.1