[PATCH 1/8] wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt()

Michal Privoznik via Devel posted 8 patches 3 months, 3 weeks ago
[PATCH 1/8] wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt()
Posted by Michal Privoznik via Devel 3 months, 3 weeks ago
From: Michal Privoznik <mprivozn@redhat.com>

Both proto_register_libvirt() and proto_reg_handoff_libvirt() are
declared in packet-libvirt.h which is included from plugin.c.
There's no need to provide another declaration in plugin.c.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/wireshark/src/plugin.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/wireshark/src/plugin.c b/tools/wireshark/src/plugin.c
index 9a83f2ca07..19b25e7b1a 100644
--- a/tools/wireshark/src/plugin.c
+++ b/tools/wireshark/src/plugin.c
@@ -72,9 +72,6 @@ void plugin_register(void)
 
 #else /* WIRESHARK_VERSION >= 2009000 */
 
-void proto_register_libvirt(void);
-void proto_reg_handoff_libvirt(void);
-
 WS_DLL_PUBLIC_DEF const gchar plugin_version[] = PLUGIN_VERSION;
 WS_DLL_PUBLIC_DEF const int plugin_want_major = WIRESHARK_VERSION_MAJOR;
 WS_DLL_PUBLIC_DEF const int plugin_want_minor = WIRESHARK_VERSION_MINOR;
-- 
2.49.1
Re: [PATCH 1/8] wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt()
Posted by Peter Krempa via Devel 3 months, 3 weeks ago
On Tue, Oct 14, 2025 at 08:31:40 +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> Both proto_register_libvirt() and proto_reg_handoff_libvirt() are
> declared in packet-libvirt.h which is included from plugin.c.
> There's no need to provide another declaration in plugin.c.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/wireshark/src/plugin.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>