From nobody Mon Feb 9 03:58:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1760423725; cv=none; d=zohomail.com; s=zohoarc; b=enMEvXCgZ24APsUPC1Uzm901YpTGXxI5y3pKc8KsXOTfll4Opw7JQABYIFIsW9ck19bsh4P13aDqviesdV3qiEoRlyPP6Sb/TcBIfjzozi5eEtLFHFa7GzIinDGE7sMkdAvxMfPf9NV2HUFmCjGmDT9hQydvZ8VIrZiFQheIwyk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760423725; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=m9lCdyecmYFe7iO89oAqjtidLC0LFacmFWS5nHnmFEk=; b=MPVIaO+biK82djA8Ra8raXotcHb5NW+5ZWUTP53E0b+Ti06hUrYgyBiXJdAHL0ZQVYmc1noOQjyOq+pAeW2UrMR1d/LXrQANZTCyahknyurfhsxN01BeEUIVRM4Tcg6HP47msZuvPA5GJ85rISPY8BsBfDfvhuPWkCFzri+SOM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1760423725853156.6046420812869; Mon, 13 Oct 2025 23:35:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D3E0D444A0; Tue, 14 Oct 2025 02:35:22 -0400 (EDT) Received: from [172.19.199.20] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 775504452A; Tue, 14 Oct 2025 02:33:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BBDC144252; Tue, 14 Oct 2025 02:31:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id F2D9F41B73 for ; Tue, 14 Oct 2025 02:31:56 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-B0Pjx3vJNQ2sbca2Dv3dBA-1; Tue, 14 Oct 2025 02:31:54 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2AA821800365 for ; Tue, 14 Oct 2025 06:31:54 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7CB24300018D for ; Tue, 14 Oct 2025 06:31:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760423516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m9lCdyecmYFe7iO89oAqjtidLC0LFacmFWS5nHnmFEk=; b=bQVjaByJll5jsW5lAqtChMsGGJVuy4YX+uPnS7LrFXgPbuPDItOxtgZWV24Utr4GkVhEXy kODptYc4+P3uMeI/VDAa+t/vLCiaJiJOjqvv+EUtrfaFa5tw/BHtsXLdN605FbGkxcOz5H m7dGi4QB458m/0xqjQ1/90Fsm63kXl8= X-MC-Unique: B0Pjx3vJNQ2sbca2Dv3dBA-1 X-Mimecast-MFC-AGG-ID: B0Pjx3vJNQ2sbca2Dv3dBA_1760423514 To: devel@lists.libvirt.org Subject: [PATCH 1/8] wireshark: Drop needless declaration of proto_register_libvirt() and proto_reg_handoff_libvirt() Date: Tue, 14 Oct 2025 08:31:40 +0200 Message-ID: <06251214ab1a919b10ec3afdf859e26102b74959.1760423277.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bkr7c_8gR5OS652pH4_4kM-s2EcpgE8DGFVxfRQw8Qg_1760423514 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: GRZIWMQC4NDIABR2ZQ7BB73PWD22DEGG X-Message-ID-Hash: GRZIWMQC4NDIABR2ZQ7BB73PWD22DEGG X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760423727925158501 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Both proto_register_libvirt() and proto_reg_handoff_libvirt() are declared in packet-libvirt.h which is included from plugin.c. There's no need to provide another declaration in plugin.c. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- tools/wireshark/src/plugin.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/wireshark/src/plugin.c b/tools/wireshark/src/plugin.c index 9a83f2ca07..19b25e7b1a 100644 --- a/tools/wireshark/src/plugin.c +++ b/tools/wireshark/src/plugin.c @@ -72,9 +72,6 @@ void plugin_register(void) =20 #else /* WIRESHARK_VERSION >=3D 2009000 */ =20 -void proto_register_libvirt(void); -void proto_reg_handoff_libvirt(void); - WS_DLL_PUBLIC_DEF const gchar plugin_version[] =3D PLUGIN_VERSION; WS_DLL_PUBLIC_DEF const int plugin_want_major =3D WIRESHARK_VERSION_MAJOR; WS_DLL_PUBLIC_DEF const int plugin_want_minor =3D WIRESHARK_VERSION_MINOR; --=20 2.49.1