[PATCH 1/6] qemuMigrationSrcIsSafe: Drop 'DEBUG' message about qemu supporting cache dropping

Peter Krempa via Devel posted 6 patches 3 weeks, 3 days ago
[PATCH 1/6] qemuMigrationSrcIsSafe: Drop 'DEBUG' message about qemu supporting cache dropping
Posted by Peter Krempa via Devel 3 weeks, 3 days ago
From: Peter Krempa <pkrempa@redhat.com>

The feature exists for a long time, no need to add extra notice about
it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_migration.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index a8f4dd489c..dd171f953c 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1805,14 +1805,10 @@ qemuMigrationSrcIsSafe(virDomainObj *vm,
          * which case cache mode doesn't matter) or used with cache=none or used with cache=directsync */
         if (disk->src->shared ||
             disk->cachemode == VIR_DOMAIN_DISK_CACHE_DISABLE ||
-            disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC)
+            disk->cachemode == VIR_DOMAIN_DISK_CACHE_DIRECTSYNC ||
+            virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE))
             continue;

-        if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE)) {
-            VIR_DEBUG("QEMU supports flushing caches; migration is safe");
-            continue;
-        }
-
         virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                        _("Migration may lead to data corruption if disks use cache other than none or directsync"));
         return false;
-- 
2.51.0