From nobody Sun Oct 5 01:50:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1757512766; cv=none; d=zohomail.com; s=zohoarc; b=KVzt0LcVEtQmkJmxsvpMMY6xu/sFF0Lrrg4NU0T1GEW0Fve2FJ0fkH+ynYHFPt1ks9p+watA34Je4V4JhAOIa+N0Z1UnLbz3uLpXDeyQYB1bhA/cBXDxEK2ghLeu5cdCrPprloD+8TtO5f6TIXC6mZv5T3t25nHnczmE8/7jWpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1757512766; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=24KEd5lSojYW/qLqKwrZO6FzCKQ8Txa3E3QIMANuK+A=; b=PH2Mj3qmeb+kCrjqzRw/hJtTRB7KeWSo9P7OdP6Pin+JBOOCl3091P5Aj5VauhO9anWHPYGr7458ur6nMf4Vhuf6Yym9q2Bxv5yFDmvUG34AraJGhB9RG9mzDx2vTX0bbnqf8NzaQcs8XKYW4EhbNlt6Z4AGBL2PrJM5+X94Zps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1757512766970455.15626281222524; Wed, 10 Sep 2025 06:59:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2275D418E2; Wed, 10 Sep 2025 09:59:26 -0400 (EDT) Received: from [172.19.199.3] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id A3F7741C73; Wed, 10 Sep 2025 09:57:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5232941B9B; Wed, 10 Sep 2025 09:57:49 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A531141B96 for ; Wed, 10 Sep 2025 09:57:48 -0400 (EDT) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-NHv7YiZiOXeYIfdtuYNQgg-1; Wed, 10 Sep 2025 09:57:46 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5FCA219540FE for ; Wed, 10 Sep 2025 13:57:45 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.8]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9E0C6300018D for ; Wed, 10 Sep 2025 13:57:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757512668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=24KEd5lSojYW/qLqKwrZO6FzCKQ8Txa3E3QIMANuK+A=; b=DBSByb/0HGfSKcUMKIR0F9ku8erK2c6M++dvHm73HXxXjsh70ikGUqBWoY0unQePMslKPK ksieDmiTbvVb7gUvInwU2sm4IMEOZ8bWkJNalQpW76oYw73JmcHlO21LeHIsVlmuYaTSXC TO8LkZ6lvCh33Hs4aJAiZFFtjZhbFG8= X-MC-Unique: NHv7YiZiOXeYIfdtuYNQgg-1 X-Mimecast-MFC-AGG-ID: NHv7YiZiOXeYIfdtuYNQgg_1757512665 To: devel@lists.libvirt.org Subject: [PATCH 1/6] qemuMigrationSrcIsSafe: Drop 'DEBUG' message about qemu supporting cache dropping Date: Wed, 10 Sep 2025 15:57:36 +0200 Message-ID: <437fd3f2fb505952ed485f07cfa4fa3958ba13f4.1757512552.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rDNQV63leeSJ18hUytFgy0DN5K6GfHjzAMXlaC0stZU_1757512665 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: P3UXAHCKRTILUDRB774ASUTO2PU5DUB2 X-Message-ID-Hash: P3UXAHCKRTILUDRB774ASUTO2PU5DUB2 X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1757512769248116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The feature exists for a long time, no need to add extra notice about it. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index a8f4dd489c..dd171f953c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1805,14 +1805,10 @@ qemuMigrationSrcIsSafe(virDomainObj *vm, * which case cache mode doesn't matter) or used with cache=3Dnone= or used with cache=3Ddirectsync */ if (disk->src->shared || disk->cachemode =3D=3D VIR_DOMAIN_DISK_CACHE_DISABLE || - disk->cachemode =3D=3D VIR_DOMAIN_DISK_CACHE_DIRECTSYNC) + disk->cachemode =3D=3D VIR_DOMAIN_DISK_CACHE_DIRECTSYNC || + virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE)) continue; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_MIGRATION_FILE_DROP_CACHE))= { - VIR_DEBUG("QEMU supports flushing caches; migration is safe"); - continue; - } - virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s", _("Migration may lead to data corruption if disks u= se cache other than none or directsync")); return false; --=20 2.51.0