[PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements

Jiri Denemark via Devel posted 6 patches 5 months, 1 week ago
[PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements
Posted by Jiri Denemark via Devel 5 months, 1 week ago
From: Jiri Denemark <jdenemar@redhat.com>

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 NEWS.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index d8bd2559f4..4fd12d94f4 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,8 +17,20 @@ v11.6.0 (unreleased)
 
 * **New features**
 
+  * Introduce VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag
+
+    This new flag for virConnectBaselineHypervisorCPU can be used for computing
+    a baseline CPU on any host without being limited to hosts represented by
+    the input CPU definitions.
+
 * **Improvements**
 
+  * Clarify documentation of virConnectBaselineHypervisorCPU
+
+    The documentation makes it clear virConnectBaselineHypervisorCPU is
+    supposed to be called on one of the hosts represented in the input CPU
+    definitions. Otherwise the API will give unexpected results.
+
 * **Bug fixes**
 
 
-- 
2.50.0
Re: [PATCH 7/6] NEWS: Mention virConnectHypervisorBaselineCPU improvements
Posted by Peter Krempa via Devel 4 months, 4 weeks ago
On Fri, Jul 04, 2025 at 16:56:37 +0200, Jiri Denemark via Devel wrote:
> From: Jiri Denemark <jdenemar@redhat.com>
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  NEWS.rst | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index d8bd2559f4..4fd12d94f4 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -17,8 +17,20 @@ v11.6.0 (unreleased)
>  
>  * **New features**
>  
> +  * Introduce VIR_CONNECT_BASELINE_CPU_IGNORE_HOST flag
> +
> +    This new flag for virConnectBaselineHypervisorCPU can be used for computing
> +    a baseline CPU on any host without being limited to hosts represented by
> +    the input CPU definitions.

I think this is a bit confusing.

How about:

  a baseline CPU on any host. Without the VIR_CONNECT_BASELINE_CPU_IGNORE_HOST
  flag the baseline API would return reasonable output only when run
  on one of the hosts that the input CPU definitions were collected
  from.


> +
>  * **Improvements**
>  
> +  * Clarify documentation of virConnectBaselineHypervisorCPU
> +
> +    The documentation makes it clear virConnectBaselineHypervisorCPU is
> +    supposed to be called on one of the hosts represented in the input CPU
> +    definitions. Otherwise the API will give unexpected results.
> +

Reviewed-by: Peter Krempa <pkrempa@redhat.com>