[PATCH 1/7] storage_backend_rbd.c: Make virStorageBackendRBDSetAllocation() stub report an error

Michal Privoznik via Devel posted 7 patches 3 months, 3 weeks ago
[PATCH 1/7] storage_backend_rbd.c: Make virStorageBackendRBDSetAllocation() stub report an error
Posted by Michal Privoznik via Devel 3 months, 3 weeks ago
From: Michal Privoznik <mprivozn@redhat.com>

Inside of storage_backend_rbd.c there are two implementations of
virStorageBackendRBDSetAllocation(). One reports an error on
failure, so the stub implementation should report an error too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/storage/storage_backend_rbd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
index 832f48df16..c2dbf3a307 100644
--- a/src/storage/storage_backend_rbd.c
+++ b/src/storage/storage_backend_rbd.c
@@ -515,6 +515,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDef *vol G_GNUC_UNUSED,
                                   rbd_image_t *image G_GNUC_UNUSED,
                                   rbd_image_info_t *info G_GNUC_UNUSED)
 {
+    virReportUnsupportedError();
     return false;
 }
 #endif
-- 
2.49.0
Re: [PATCH 1/7] storage_backend_rbd.c: Make virStorageBackendRBDSetAllocation() stub report an error
Posted by Peter Krempa via Devel 3 months, 3 weeks ago
On Wed, May 14, 2025 at 16:24:10 +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> Inside of storage_backend_rbd.c there are two implementations of
> virStorageBackendRBDSetAllocation(). One reports an error on
> failure, so the stub implementation should report an error too.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/storage/storage_backend_rbd.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>