From nobody Sun Feb 8 15:40:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747232708; cv=none; d=zohomail.com; s=zohoarc; b=MkVm06IQCp16hRhfMGx/nL93yc3wCHDgnzFbmYZsXDO3YqENwJGKQfPVtTjvIEegw7Fj1Un4PZrZDPQAny9IN05y3ClhQRdSCMb8sAemvE7fYTzjlYYkFtiYAzB7d7LOsTdkLWlwo3/JYZWUtnwh7rv4Z7+bIFTq2ry6/o4h+v8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747232708; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=mENr0fQEfz8I+JQXAbvh78zDcO+8o9qiyf9zXQiOiFs=; b=cW+CgiEHwr8EUnQfLe4g3mA/COdwok5ZMYLZUkHORMxfv2TQhtA58wYMGXAT9dZ6tjM6JcNL1/lmAaCZrP6/GUwiI/lQWTv4izyGgNSry1Kx8/2F8rDZxMzbJRY5r5/7GsUwDNGXlzpsFB+aJlGMvDDBBvSX8DjvZAYtZS+Zkeg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747232708083415.6188020040174; Wed, 14 May 2025 07:25:08 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 6516CD76; Wed, 14 May 2025 10:25:07 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3E91AE5A; Wed, 14 May 2025 10:24:29 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A01E1CA1; Wed, 14 May 2025 10:24:24 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 29021CA5 for ; Wed, 14 May 2025 10:24:24 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-0oWDIWlbP8-O0ofXeF2msA-1; Wed, 14 May 2025 10:24:22 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E37118001EA for ; Wed, 14 May 2025 14:24:21 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CBB331955F24 for ; Wed, 14 May 2025 14:24:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747232663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PqpNOoNVITWSACa7SE1yCG/tGBev+0HlN9U6MmeE6g4=; b=ZEtF2anPQAuS4MS1/oBiB6UquH8cYQ7MdrZUOXpUr1b1qaeSxOdyX71wyVa2/hL8woWvVy 6ikhf6DQ/tkS/+pOdHDSwjxbZDwFWAifJW5Q5KDvXtkSh0wW9Fi/HYMsNu4uhzQ7teQ2xl yVVsXdZ80M0zhoqL0GGlgOH5j8+epfQ= X-MC-Unique: 0oWDIWlbP8-O0ofXeF2msA-1 X-Mimecast-MFC-AGG-ID: 0oWDIWlbP8-O0ofXeF2msA_1747232661 To: devel@lists.libvirt.org Subject: [PATCH 1/7] storage_backend_rbd.c: Make virStorageBackendRBDSetAllocation() stub report an error Date: Wed, 14 May 2025 16:24:10 +0200 Message-ID: <5ca42e2271b9e508fcf8df217d5b8457b963f355.1747232412.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lhFV3dqlCWf3noVA5l_efgRx4LqslGNbHFKJCp-fnjA_1747232661 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BMTHTH5OKPO7MTPFE45Z3MCB4TS6DFQP X-Message-ID-Hash: BMTHTH5OKPO7MTPFE45Z3MCB4TS6DFQP X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747232711267019000 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik Inside of storage_backend_rbd.c there are two implementations of virStorageBackendRBDSetAllocation(). One reports an error on failure, so the stub implementation should report an error too. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/storage/storage_backend_rbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index 832f48df16..c2dbf3a307 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -515,6 +515,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDef *vol= G_GNUC_UNUSED, rbd_image_t *image G_GNUC_UNUSED, rbd_image_info_t *info G_GNUC_UNUSED) { + virReportUnsupportedError(); return false; } #endif --=20 2.49.0