Fix return type of some functions

[PATCH 6/7] virsh-pool.c: Fix return type of virshBuildPoolXML()

Posted by Michal Privoznik via Devel 3 months, 3 weeks ago

From: Michal Privoznik <mprivozn@redhat.com>

The virshBuildPoolXML() function is declared to return an int but
in fact its return type is a boolean. Even its both callers
(cmdPoolCreateAs() and cmdPoolDefineAs()) thread its retval as a
boolean. Switch the return type from integer to boolean.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/virsh-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index 33b130564e..089fde55e2 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -322,7 +322,7 @@ static const vshCmdOptDef opts_pool_define_as[] = {
     {.name = NULL}
 };
 
-static int
+static bool
 virshBuildPoolXML(vshControl *ctl,
                   const vshCmd *cmd,
                   const char **retname,
-- 
2.49.0

Re: [PATCH 6/7] virsh-pool.c: Fix return type of virshBuildPoolXML()

Posted by Peter Krempa via Devel 3 months, 3 weeks ago

On Wed, May 14, 2025 at 16:24:15 +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> The virshBuildPoolXML() function is declared to return an int but
> in fact its return type is a boolean. Even its both callers
> (cmdPoolCreateAs() and cmdPoolDefineAs()) thread its retval as a

treat

> boolean. Switch the return type from integer to boolean.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/virsh-pool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
> index 33b130564e..089fde55e2 100644
> --- a/tools/virsh-pool.c
> +++ b/tools/virsh-pool.c
> @@ -322,7 +322,7 @@ static const vshCmdOptDef opts_pool_define_as[] = {
>      {.name = NULL}
>  };
>  
> -static int
> +static bool
>  virshBuildPoolXML(vshControl *ctl,
>                    const vshCmd *cmd,
>                    const char **retname,
> -- 
> 2.49.0
> 

Reviewed-by: Peter Krempa <pkrempa@redhat.com>