From nobody Tue Sep 9 03:16:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1747232827; cv=none; d=zohomail.com; s=zohoarc; b=fNRQSpMMH0ox/V4w60ILYQRkAdSBTyUCaUm3GErcq8uYp7Ik5cUw5JnUt35U0HndhPXK/x2zG3qwVcOWZtKnZBAcWfyhWBsux/UGtF+sKmefTxxmfwxjCSIYRrEYL5izXGDbNtrb2pTp6qVglROfj9hJNz5qxiiwPh5kHzyVXls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747232827; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=/CEdqu4JR2QRnjJ80QKeQjflKs9yL54zRIlEzxwomaQ=; b=Q8vVkqPUUxSGs7IJ9Juiyz7HUmPTJHM4PrDoFszPrexeSkmj2Qf69dLosQHjvc1uwSNSCUedL04voZbiaYVMncnuxuzCEY7qRHGrrZD/snpl+eRppmC/n0Qe7igfYDsNegbouJ2Tcccyqh3z/9R0uXq4g9xBvMuiltpJ0dXJtBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1747232827452654.065014366135; Wed, 14 May 2025 07:27:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 88CF5CA1; Wed, 14 May 2025 10:27:06 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D732D123A; Wed, 14 May 2025 10:24:50 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 18A7C11E4; Wed, 14 May 2025 10:24:45 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 386DA11EE for ; Wed, 14 May 2025 10:24:31 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-RGb6-eEWN9uyHPAC1bjYLg-1; Wed, 14 May 2025 10:24:29 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6038818004AD for ; Wed, 14 May 2025 14:24:27 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9E1231955F24 for ; Wed, 14 May 2025 14:24:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747232670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zO3iVeHiCYUU9sTXHT1INkilY2k60j/DwM6m+kTKLMU=; b=P+6jPscVsb8dex2Mcn+Zk2Nmiw9vYpshLSYw/v29sbK0phxAnpIi7ASgszfPPM1w/nCWwc mjFZhMG3CSFSP+7djD82PT6rObhPsFkQHGwoHxtgFrgCnITJ3/q7kpEBCtfzqpHWRj9Vb3 4AeQvsJhbcmAZrvLTL9Oq2KHwrK6Cow= X-MC-Unique: RGb6-eEWN9uyHPAC1bjYLg-1 X-Mimecast-MFC-AGG-ID: RGb6-eEWN9uyHPAC1bjYLg_1747232667 To: devel@lists.libvirt.org Subject: [PATCH 6/7] virsh-pool.c: Fix return type of virshBuildPoolXML() Date: Wed, 14 May 2025 16:24:15 +0200 Message-ID: <4f69826e2f251da27b9504657165f55e0e5c1418.1747232412.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UYEaz7mR-N38G4RMEREvU_vHlkMM-pSOBVeCRTM3XZI_1747232667 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: N3LEHWQKLZYSCG756TBLWARMLLNNCT6U X-Message-ID-Hash: N3LEHWQKLZYSCG756TBLWARMLLNNCT6U X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1747232828505116600 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The virshBuildPoolXML() function is declared to return an int but in fact its return type is a boolean. Even its both callers (cmdPoolCreateAs() and cmdPoolDefineAs()) thread its retval as a boolean. Switch the return type from integer to boolean. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- tools/virsh-pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 33b130564e..089fde55e2 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -322,7 +322,7 @@ static const vshCmdOptDef opts_pool_define_as[] =3D { {.name =3D NULL} }; =20 -static int +static bool virshBuildPoolXML(vshControl *ctl, const vshCmd *cmd, const char **retname, --=20 2.49.0