This was reported on virt-manager issue tracker as it was possible to
provide `listen` attribute with properly escaped characters but libvirt
would format XML without escaping it.
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6bb30c6f22..7ce49993b9 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26303,7 +26303,7 @@ virDomainGraphicsListenDefFormat(virBuffer *buf,
!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)))) {
/* address may also be set to show current status when type='network',
* but we don't want to print that if INACTIVE data is requested. */
- virBufferAsprintf(&attrBuf, " address='%s'", def->address);
+ virBufferEscapeString(&attrBuf, " address='%s'", def->address);
}
if (def->network &&
@@ -26392,7 +26392,7 @@ virDomainGraphicsListenDefFormatAddr(virBuffer *buf,
return;
if (glisten->address)
- virBufferAsprintf(buf, " listen='%s'", glisten->address);
+ virBufferEscapeString(buf, " listen='%s'", glisten->address);
}
static void
--
2.48.1