From nobody Wed Mar 12 17:22:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741264087786644.217066993167; Thu, 6 Mar 2025 04:28:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id F1BC7196F; Thu, 6 Mar 2025 07:28:06 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6432B1784; Thu, 6 Mar 2025 07:23:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 56919180C; Thu, 6 Mar 2025 07:23:22 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7ED49180C for ; Thu, 6 Mar 2025 07:22:56 -0500 (EST) Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-pvild0S5MjO1JQ3-BFcuEg-1; Thu, 06 Mar 2025 07:22:54 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3DB91955DDE for ; Thu, 6 Mar 2025 12:22:53 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.44.33.191]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E3334300019E for ; Thu, 6 Mar 2025 12:22:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741263776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HYG3Hg/VumI5+SmIQ2G//EU5H2+O52Pdnd5u6p6OuNc=; b=LSv1jEhnu23jnIZorrZAq5R+Q38KkK/eL7x9AykhYAeZ0g+vS+qz3K05b2HX03SMZOan/w mc3aIcD1CtuY9jXTBE9K+e0lR+JTBmPVkp3RLWIzr+lxuePYvgGlTL+5wL7tkD4HmvKYTH n12l12Ol3991OKSFNkvmfrW0MBF9Oa8= X-MC-Unique: pvild0S5MjO1JQ3-BFcuEg-1 X-Mimecast-MFC-AGG-ID: pvild0S5MjO1JQ3-BFcuEg_1741263773 From: Pavel Hrdina To: devel@lists.libvirt.org Subject: [libvirt PATCH 16/16] domain_conf: graphics: properly escape user provided strings when formatting XML Date: Thu, 6 Mar 2025 13:22:24 +0100 Message-ID: <642434f255e15f2ae7da6f5bca0c359e070fea01.1741263715.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TN_Ee5-JjzWGY57A0LhsoZ9_jCF94hMncHNRibllhJc_1741263773 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: Q7HHQOUQ32CSQ65UXKXY6BD3WSQMNT5X X-Message-ID-Hash: Q7HHQOUQ32CSQ65UXKXY6BD3WSQMNT5X X-MailFrom: phrdina@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741264088195019000 Content-Type: text/plain; charset="utf-8"; x-default="true" This was reported on virt-manager issue tracker as it was possible to provide `listen` attribute with properly escaped characters but libvirt would format XML without escaping it. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6bb30c6f22..7ce49993b9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26303,7 +26303,7 @@ virDomainGraphicsListenDefFormat(virBuffer *buf, !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)))) { /* address may also be set to show current status when type=3D'net= work', * but we don't want to print that if INACTIVE data is requested. = */ - virBufferAsprintf(&attrBuf, " address=3D'%s'", def->address); + virBufferEscapeString(&attrBuf, " address=3D'%s'", def->address); } =20 if (def->network && @@ -26392,7 +26392,7 @@ virDomainGraphicsListenDefFormatAddr(virBuffer *buf, return; =20 if (glisten->address) - virBufferAsprintf(buf, " listen=3D'%s'", glisten->address); + virBufferEscapeString(buf, " listen=3D'%s'", glisten->address); } =20 static void --=20 2.48.1