[PATCH 3/7] virDomainDiskTranslateSourcePool: Don't re-translate already translated defs

Peter Krempa posted 7 patches 2 years, 3 months ago
[PATCH 3/7] virDomainDiskTranslateSourcePool: Don't re-translate already translated defs
Posted by Peter Krempa 2 years, 3 months ago
If a disk definition was already translated re-doing it makes no sense.

Skip the translation if the 'actualtype' is already populated.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3e0989e2e8..e128457b00 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -30529,7 +30529,7 @@ virDomainDiskTranslateSourcePool(virDomainDiskDef *def)
     virStorageSource *n;

     for (n = def->src; virStorageSourceIsBacking(n); n = n->backingStore) {
-        if (n->type != VIR_STORAGE_TYPE_VOLUME || !n->srcpool)
+        if (n->type != VIR_STORAGE_TYPE_VOLUME || !n->srcpool || n->srcpool->actualtype != VIR_STORAGE_TYPE_NONE)
             continue;

         if (!conn) {
-- 
2.41.0
Re: [PATCH 3/7] virDomainDiskTranslateSourcePool: Don't re-translate already translated defs
Posted by Ján Tomko 2 years, 3 months ago
On a Thursday in 2023, Peter Krempa wrote:
>If a disk definition was already translated re-doing it makes no sense.
>
>Skip the translation if the 'actualtype' is already populated.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/domain_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano