From nobody Mon Feb 9 16:53:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1697122391; cv=none; d=zohomail.com; s=zohoarc; b=jeJvIVSehsHNzfzM2spp6Fg6jCljWrgYue5fca4vRRYzyiDSBhcSOrJbADZXlvnhI+9HAFsZCD8eh38KmzVWxBpPb3DklqNyL7hmheuh/RIkxNF54vGN6HolUa6m1BU8dapchwnlO7q/0vX8O5aOdlZ9AJTadhLQQlizhCoUG2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697122391; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=d1Skv3PjIuLi7JB1P+xDZtGiq4ZePI0kAw66tmQ+Qqg=; b=Wu9fUevmXnimW9JZw5r0b2bHdolhCzf0oQ8/Vlvf7TGzZ1mClCIm+8ilnY7gu4EKmldMaqWbkAf/ttb/BR008M+TQr6DAoNGB7YX3QhT1LaRkMQ81XY2StgVcTySdcXMYqZqH7oi74452MoAoUwiez1qUxPznqbwMpyI1/Y8lVA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1697122391808561.2866036279643; Thu, 12 Oct 2023 07:53:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-c_p0nXNjPaKRRw8ttrWlfQ-1; Thu, 12 Oct 2023 10:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93DAC3C0C890; Thu, 12 Oct 2023 14:53:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 803C71C060DF; Thu, 12 Oct 2023 14:53:03 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 219341946588; Thu, 12 Oct 2023 14:53:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 472221946586 for ; Thu, 12 Oct 2023 14:47:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3CB27C15BBC; Thu, 12 Oct 2023 14:47:35 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1D8AC1598B for ; Thu, 12 Oct 2023 14:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697122390; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=d1Skv3PjIuLi7JB1P+xDZtGiq4ZePI0kAw66tmQ+Qqg=; b=aVh6Fq6DnCZsd6u0dksKVDR2d6acPxSSLj7+laN7x3iwMBIqNPa5k48OBbbvBEr6HOJjlg dVs67UCAmgHNcEVfWpuHd/15Q6xAYyHseoAs3Y3GIUiSHkvlMKaco2QP7e987LOIg3vK/2 EFxo+4B/KCg1mYMk0GXKHVNDqE0fvx8= X-MC-Unique: c_p0nXNjPaKRRw8ttrWlfQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 3/7] virDomainDiskTranslateSourcePool: Don't re-translate already translated defs Date: Thu, 12 Oct 2023 16:47:27 +0200 Message-ID: <0e7b24b0b9bb6c16b7af6c69ca921e1037808071.1697121886.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1697122392756100001 Content-Type: text/plain; charset="utf-8" If a disk definition was already translated re-doing it makes no sense. Skip the translation if the 'actualtype' is already populated. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3e0989e2e8..e128457b00 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30529,7 +30529,7 @@ virDomainDiskTranslateSourcePool(virDomainDiskDef *= def) virStorageSource *n; for (n =3D def->src; virStorageSourceIsBacking(n); n =3D n->backingSto= re) { - if (n->type !=3D VIR_STORAGE_TYPE_VOLUME || !n->srcpool) + if (n->type !=3D VIR_STORAGE_TYPE_VOLUME || !n->srcpool || n->srcp= ool->actualtype !=3D VIR_STORAGE_TYPE_NONE) continue; if (!conn) { --=20 2.41.0