[PATCH 0/6] add support for pvpanic-pci device

Kristina Hanicova posted 6 patches 1 year, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1675856890.git.khanicov@redhat.com
There is a newer version of this series
docs/formatdomain.rst                         |  1 +
src/conf/domain_conf.c                        |  1 +
src/conf/domain_conf.h                        |  1 +
src/conf/schemas/domaincommon.rng             |  1 +
src/qemu/qemu_capabilities.c                  |  2 +
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_command.c                       | 19 +++++
src/qemu/qemu_domain_address.c                | 34 ++++++++-
src/qemu/qemu_validate.c                      | 16 +++++
.../caps_6.0.0.aarch64.xml                    |  1 +
.../caps_6.0.0.x86_64.xml                     |  1 +
.../caps_6.1.0.x86_64.xml                     |  1 +
.../caps_6.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 +
.../caps_6.2.0.x86_64.xml                     |  1 +
.../caps_7.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 +
.../caps_7.0.0.x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1 +
.../caps_7.1.0.x86_64.xml                     |  1 +
.../caps_7.2.0.x86_64.xml                     |  1 +
.../caps_8.0.0.riscv64.xml                    |  1 +
.../caps_8.0.0.x86_64.xml                     |  1 +
.../pvpanic-pci-aarch64.aarch64-latest.args   | 43 ++++++++++++
.../qemuxml2argvdata/pvpanic-pci-aarch64.xml  | 20 ++++++
...invalid-address-aarch64.aarch64-latest.err |  1 +
.../pvpanic-pci-invalid-address-aarch64.xml   | 20 ++++++
...pci-no-address-aarch64.aarch64-latest.args | 41 +++++++++++
.../pvpanic-pci-no-address-aarch64.xml        | 18 +++++
.../pvpanic-pci-x86_64.x86_64-latest.args     | 43 ++++++++++++
tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml | 31 +++++++++
tests/qemuxml2argvtest.c                      |  4 ++
.../pvpanic-pci-aarch64.aarch64-latest.xml    | 63 +++++++++++++++++
...-pci-no-address-aarch64.aarch64-latest.xml | 53 ++++++++++++++
.../pvpanic-pci-x86_64.x86_64-latest.xml      | 69 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  4 ++
36 files changed, 499 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.aarch64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.aarch64-latest.err
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.aarch64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-aarch64.aarch64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-no-address-aarch64.aarch64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-x86_64.x86_64-latest.xml
[PATCH 0/6] add support for pvpanic-pci device
Posted by Kristina Hanicova 1 year, 2 months ago
*** BLURB HERE ***

Kristina Hanicova (6):
  qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
  conf: add panic model 'pvpanic'
  tests: add test cases for device pvpanic-pci
  qemu: assign PCI address to device pvpanic-pci
  tests: add case for pvpanic-pci without address
  docs: document panic device 'pvpanic-pci'

 docs/formatdomain.rst                         |  1 +
 src/conf/domain_conf.c                        |  1 +
 src/conf/domain_conf.h                        |  1 +
 src/conf/schemas/domaincommon.rng             |  1 +
 src/qemu/qemu_capabilities.c                  |  2 +
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       | 19 +++++
 src/qemu/qemu_domain_address.c                | 34 ++++++++-
 src/qemu/qemu_validate.c                      | 16 +++++
 .../caps_6.0.0.aarch64.xml                    |  1 +
 .../caps_6.0.0.x86_64.xml                     |  1 +
 .../caps_6.1.0.x86_64.xml                     |  1 +
 .../caps_6.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 +
 .../caps_6.2.0.x86_64.xml                     |  1 +
 .../caps_7.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 +
 .../caps_7.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1 +
 .../caps_7.1.0.x86_64.xml                     |  1 +
 .../caps_7.2.0.x86_64.xml                     |  1 +
 .../caps_8.0.0.riscv64.xml                    |  1 +
 .../caps_8.0.0.x86_64.xml                     |  1 +
 .../pvpanic-pci-aarch64.aarch64-latest.args   | 43 ++++++++++++
 .../qemuxml2argvdata/pvpanic-pci-aarch64.xml  | 20 ++++++
 ...invalid-address-aarch64.aarch64-latest.err |  1 +
 .../pvpanic-pci-invalid-address-aarch64.xml   | 20 ++++++
 ...pci-no-address-aarch64.aarch64-latest.args | 41 +++++++++++
 .../pvpanic-pci-no-address-aarch64.xml        | 18 +++++
 .../pvpanic-pci-x86_64.x86_64-latest.args     | 43 ++++++++++++
 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml | 31 +++++++++
 tests/qemuxml2argvtest.c                      |  4 ++
 .../pvpanic-pci-aarch64.aarch64-latest.xml    | 63 +++++++++++++++++
 ...-pci-no-address-aarch64.aarch64-latest.xml | 53 ++++++++++++++
 .../pvpanic-pci-x86_64.x86_64-latest.xml      | 69 +++++++++++++++++++
 tests/qemuxml2xmltest.c                       |  4 ++
 36 files changed, 499 insertions(+), 1 deletion(-)
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.aarch64-latest.err
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-aarch64.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-no-address-aarch64.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-x86_64.x86_64-latest.xml

-- 
2.39.1
Re: [PATCH 0/6] add support for pvpanic-pci device
Posted by Peter Krempa 1 year, 2 months ago
On Wed, Feb 08, 2023 at 12:48:59 +0100, Kristina Hanicova wrote:
> Kristina Hanicova (6):
>   qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
>   conf: add panic model 'pvpanic'
>   tests: add test cases for device pvpanic-pci
>   qemu: assign PCI address to device pvpanic-pci
>   tests: add case for pvpanic-pci without address

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

>   docs: document panic device 'pvpanic-pci'

If you agree that dropping the 'KVM' part of where pvpanic-pci works is
fine then you can also use my R-b on this one.
Re: [PATCH 0/6] add support for pvpanic-pci device
Posted by Andrea Bolognani 1 year, 2 months ago
On Wed, Feb 08, 2023 at 12:48:59PM +0100, Kristina Hanicova wrote:
>   qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
>   conf: add panic model 'pvpanic'
>   tests: add test cases for device pvpanic-pci
>   qemu: assign PCI address to device pvpanic-pci
>   tests: add case for pvpanic-pci without address
>   docs: document panic device 'pvpanic-pci'

Stray observations:

  * an entry in the release notes would certainly be warranted for
    this nice user-visible improvement;

  * I noticed that panic devices don't currently have aliases
    associated with them: this looks like an oversight rather than a
    conscious design decision, and it would be great if you would
    consider addressing that in a follow-up series :)

-- 
Andrea Bolognani / Red Hat / Virtualization