[PATCH v2 0/6] add support for pvpanic-pci device

Kristina Hanicova posted 6 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1676906829.git.khanicov@redhat.com
docs/formatdomain.rst                         |  1 +
src/conf/domain_conf.c                        |  1 +
src/conf/domain_conf.h                        |  1 +
src/conf/schemas/domaincommon.rng             |  1 +
src/qemu/qemu_capabilities.c                  |  2 ++
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_command.c                       | 17 +++++++++
src/qemu/qemu_domain_address.c                | 34 +++++++++++++++++-
src/qemu/qemu_validate.c                      | 14 ++++++++
.../caps_6.0.0.aarch64.xml                    |  1 +
.../caps_6.0.0.x86_64.xml                     |  1 +
.../caps_6.1.0.x86_64.xml                     |  1 +
.../caps_6.2.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 +
.../caps_6.2.0.x86_64.xml                     |  1 +
.../caps_7.0.0.aarch64.xml                    |  1 +
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 +
.../caps_7.0.0.x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1 +
.../caps_7.1.0.x86_64.xml                     |  1 +
.../caps_7.2.0.x86_64.xml                     |  1 +
.../caps_8.0.0.riscv64.xml                    |  1 +
.../caps_8.0.0.x86_64.xml                     |  1 +
.../pvpanic-pci-aarch64.aarch64-latest.args   | 36 +++++++++++++++++++
.../qemuxml2argvdata/pvpanic-pci-aarch64.xml  | 20 +++++++++++
...invalid-address-aarch64.aarch64-latest.err |  1 +
.../pvpanic-pci-invalid-address-aarch64.xml   | 20 +++++++++++
...pci-no-address-aarch64.aarch64-latest.args | 36 +++++++++++++++++++
.../pvpanic-pci-no-address-aarch64.xml        | 18 ++++++++++
.../pvpanic-pci-x86_64.x86_64-latest.args     | 34 ++++++++++++++++++
tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml | 24 +++++++++++++
tests/qemuxml2argvtest.c                      |  5 +++
.../pvpanic-pci-aarch64.aarch64-latest.xml    | 32 +++++++++++++++++
...-pci-no-address-aarch64.aarch64-latest.xml | 32 +++++++++++++++++
.../pvpanic-pci-x86_64.x86_64-latest.xml      | 32 +++++++++++++++++
tests/qemuxml2xmltest.c                       |  4 +++
36 files changed, 379 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.aarch64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.aarch64-latest.err
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.aarch64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.xml
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-aarch64.aarch64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-no-address-aarch64.aarch64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-x86_64.x86_64-latest.xml
[PATCH v2 0/6] add support for pvpanic-pci device
Posted by Kristina Hanicova 1 year, 1 month ago
v1 here:
https://listman.redhat.com/archives/libvir-list/2023-February/237622.html

diff to v1:
* reduced test files (thanks Andrea)
* removed redundant check for address type (noticed by Peter)
* plugging the device directly into pcie.0 if its address was not
  specified

Kristina Hanicova (6):
  qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
  conf: add panic model 'pvpanic'
  tests: add test cases for device pvpanic-pci
  qemu: assign PCI address to device pvpanic-pci
  tests: add case for pvpanic-pci without address
  docs: document panic device 'pvpanic-pci'

 docs/formatdomain.rst                         |  1 +
 src/conf/domain_conf.c                        |  1 +
 src/conf/domain_conf.h                        |  1 +
 src/conf/schemas/domaincommon.rng             |  1 +
 src/qemu/qemu_capabilities.c                  |  2 ++
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_command.c                       | 17 +++++++++
 src/qemu/qemu_domain_address.c                | 34 +++++++++++++++++-
 src/qemu/qemu_validate.c                      | 14 ++++++++
 .../caps_6.0.0.aarch64.xml                    |  1 +
 .../caps_6.0.0.x86_64.xml                     |  1 +
 .../caps_6.1.0.x86_64.xml                     |  1 +
 .../caps_6.2.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml |  1 +
 .../caps_6.2.0.x86_64.xml                     |  1 +
 .../caps_7.0.0.aarch64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml |  1 +
 .../caps_7.0.0.x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml |  1 +
 .../caps_7.1.0.x86_64.xml                     |  1 +
 .../caps_7.2.0.x86_64.xml                     |  1 +
 .../caps_8.0.0.riscv64.xml                    |  1 +
 .../caps_8.0.0.x86_64.xml                     |  1 +
 .../pvpanic-pci-aarch64.aarch64-latest.args   | 36 +++++++++++++++++++
 .../qemuxml2argvdata/pvpanic-pci-aarch64.xml  | 20 +++++++++++
 ...invalid-address-aarch64.aarch64-latest.err |  1 +
 .../pvpanic-pci-invalid-address-aarch64.xml   | 20 +++++++++++
 ...pci-no-address-aarch64.aarch64-latest.args | 36 +++++++++++++++++++
 .../pvpanic-pci-no-address-aarch64.xml        | 18 ++++++++++
 .../pvpanic-pci-x86_64.x86_64-latest.args     | 34 ++++++++++++++++++
 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml | 24 +++++++++++++
 tests/qemuxml2argvtest.c                      |  5 +++
 .../pvpanic-pci-aarch64.aarch64-latest.xml    | 32 +++++++++++++++++
 ...-pci-no-address-aarch64.aarch64-latest.xml | 32 +++++++++++++++++
 .../pvpanic-pci-x86_64.x86_64-latest.xml      | 32 +++++++++++++++++
 tests/qemuxml2xmltest.c                       |  4 +++
 36 files changed, 379 insertions(+), 1 deletion(-)
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.aarch64-latest.err
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-invalid-address-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.aarch64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-no-address-aarch64.xml
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/pvpanic-pci-x86_64.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-aarch64.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-no-address-aarch64.aarch64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/pvpanic-pci-x86_64.x86_64-latest.xml

-- 
2.39.1
Re: [PATCH v2 0/6] add support for pvpanic-pci device
Posted by Andrea Bolognani 1 year, 1 month ago
On Mon, Feb 20, 2023 at 05:12:53PM +0100, Kristina Hanicova wrote:
> v1 here:
> https://listman.redhat.com/archives/libvir-list/2023-February/237622.html
>
> diff to v1:
> * reduced test files (thanks Andrea)
> * removed redundant check for address type (noticed by Peter)
> * plugging the device directly into pcie.0 if its address was not
>   specified

Just for completeness' sake, note that the use of
VIR_PCI_CONNECT_INTEGRATED results in libvirt outright rejecting
attempts to put the device anywhere but on pcie.0, even when the
address comes directly from the user. This is technically a
limitation compared to what QEMU allows, but in practice the other
configurations are untested and overall it feels like a fair
trade-off. We can also decide to lift this limitation in the future,
if it ever comes to that.

> Kristina Hanicova (6):
>   qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
>   conf: add panic model 'pvpanic'
>   tests: add test cases for device pvpanic-pci
>   qemu: assign PCI address to device pvpanic-pci
>   tests: add case for pvpanic-pci without address
>   docs: document panic device 'pvpanic-pci'

Everything looks great, so

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

The first patch is missing the Signed-off-by tag. Can you please
confirm that you're okay with me adding it before pushing?

I'm also not seeing any updates to the NEWS file. Please post that as
a follow-up patch before release :)

-- 
Andrea Bolognani / Red Hat / Virtualization
Re: [PATCH v2 0/6] add support for pvpanic-pci device
Posted by Kristina Hanicova 1 year, 1 month ago
On Mon, Feb 20, 2023 at 7:17 PM Andrea Bolognani <abologna@redhat.com>
wrote:

> On Mon, Feb 20, 2023 at 05:12:53PM +0100, Kristina Hanicova wrote:
> > v1 here:
> >
> https://listman.redhat.com/archives/libvir-list/2023-February/237622.html
> >
> > diff to v1:
> > * reduced test files (thanks Andrea)
> > * removed redundant check for address type (noticed by Peter)
> > * plugging the device directly into pcie.0 if its address was not
> >   specified
>
> Just for completeness' sake, note that the use of
> VIR_PCI_CONNECT_INTEGRATED results in libvirt outright rejecting
> attempts to put the device anywhere but on pcie.0, even when the
> address comes directly from the user. This is technically a
> limitation compared to what QEMU allows, but in practice the other
> configurations are untested and overall it feels like a fair
> trade-off. We can also decide to lift this limitation in the future,
> if it ever comes to that.
>
> > Kristina Hanicova (6):
> >   qemu: introduce QEMU_CAPS_DEVICE_PANIC_PCI
> >   conf: add panic model 'pvpanic'
> >   tests: add test cases for device pvpanic-pci
> >   qemu: assign PCI address to device pvpanic-pci
> >   tests: add case for pvpanic-pci without address
> >   docs: document panic device 'pvpanic-pci'
>
> Everything looks great, so
>
>   Reviewed-by: Andrea Bolognani <abologna@redhat.com>
>
> The first patch is missing the Signed-off-by tag. Can you please
> confirm that you're okay with me adding it before pushing?
>

Yes, thank you.


>
> I'm also not seeing any updates to the NEWS file. Please post that as
> a follow-up patch before release :)
>
>
Thanks for the reminder, the patch updating NEWS is on the list now.


Kristina