node_device: Tiny code cleanups

[PATCH 0/5] node_device: Tiny code cleanups

Michal Privoznik posted 5 patches 1 year, 6 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1666710738.git.mprivozn@redhat.com

src/node_device/node_device_driver.c |  3 +++
src/node_device/node_device_driver.h | 12 ------------
src/node_device/node_device_udev.c   |  2 ++
src/node_device/node_device_udev.h   |  6 ++----
4 files changed, 7 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH 0/5] node_device: Tiny code cleanups

Posted by Michal Privoznik 1 year, 6 months ago

My aim is to move virNodeDeviceDriver declaration into
node_device_driver.c, eventually. BUT that's going to be more patches
and as I continue my work on that I've noticed couple of almost trivial
patches that can be merged regardless. Even during freeze ;-)

Michal Prívozník (5):
  node_device_udev.h: Drop unused macro
  node_device: Move DMI_DEVPATH into node_device_udev.c
  node_device_udev.h: Drop include of libudev.h
  node_device: Move fwd declaration of udevNodeRegister() into correct
    header file
  node_device_driver.h: Drop nodeDeviceLock() and nodeDeviceUnlock() fwd
    declarations

 src/node_device/node_device_driver.c |  3 +++
 src/node_device/node_device_driver.h | 12 ------------
 src/node_device/node_device_udev.c   |  2 ++
 src/node_device/node_device_udev.h   |  6 ++----
 4 files changed, 7 insertions(+), 16 deletions(-)

-- 
2.37.4

Re: [PATCH 0/5] node_device: Tiny code cleanups

Posted by Jonathon Jongsma 1 year, 6 months ago

On 10/25/22 10:15 AM, Michal Privoznik wrote:
> My aim is to move virNodeDeviceDriver declaration into
> node_device_driver.c, eventually. BUT that's going to be more patches
> and as I continue my work on that I've noticed couple of almost trivial
> patches that can be merged regardless. Even during freeze ;-)
> 
> Michal Prívozník (5):
>    node_device_udev.h: Drop unused macro
>    node_device: Move DMI_DEVPATH into node_device_udev.c
>    node_device_udev.h: Drop include of libudev.h
>    node_device: Move fwd declaration of udevNodeRegister() into correct
>      header file
>    node_device_driver.h: Drop nodeDeviceLock() and nodeDeviceUnlock() fwd
>      declarations
> 
>   src/node_device/node_device_driver.c |  3 +++
>   src/node_device/node_device_driver.h | 12 ------------
>   src/node_device/node_device_udev.c   |  2 ++
>   src/node_device/node_device_udev.h   |  6 ++----
>   4 files changed, 7 insertions(+), 16 deletions(-)
> 


Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>