From nobody Fri May 3 18:22:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666710949; cv=none; d=zohomail.com; s=zohoarc; b=clsfr+Cnh/SyldRF9AM6v73IVtp7OHyJWxDA5pArGy0RWop2CJSeCXYM6i59dE6FkBlRD9/PygqLOv1YpOLZIPOAKtox9g+i2H7xjfZjPeYcr489cihVflDrPL1boMGTyyv1Iv3hMuSNAs3JJbrvlTerQeDGwQ82aObVB1/31gA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666710949; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=be7+W3hGwzJLjM0tRLAqRtR3pkzHMYc99OZkvcyr2+U=; b=lA/3ApA2iU5e3LomayX/9WS7Yb9xFHbsmWlZJcysXRex8QP4NU73agi4fCN27ryAX9E0dqcHD6FWUAJ3HI5m27r4Lvjqh2JC65df8k3uo9KmtZEnXdTcxzDbqfpr11v+tmg+R09hNFIkcKDPnrmXZXWslyuSg9nMTSotSkjwEKU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 166671094912318.899340545329096; Tue, 25 Oct 2022 08:15:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-520-1RSepsglP36pZHk1sgUspA-1; Tue, 25 Oct 2022 11:15:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 024E5855441; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FD4939DB3; Tue, 25 Oct 2022 15:15:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 10E4F1947071; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 23E7D1946597 for ; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 04D1B20290A6; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F5F920290A5 for ; Tue, 25 Oct 2022 15:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710948; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=be7+W3hGwzJLjM0tRLAqRtR3pkzHMYc99OZkvcyr2+U=; b=Nrk5IZEGEZYz+KC+1WkLosGkNm6XeXZL36JWhamTRrucs3KtuqztYIDfX5BPNsT/fhbQdy U9bn9a52aVdazePW6Nd8aG6cjtYtZK4JS6FL2/ONujQDSTGfZuJPXzh/NVpYgnrcqr9tpR Lir4NXmRp49OPWVlPsSQ3FEsVCjn8qc= X-MC-Unique: 1RSepsglP36pZHk1sgUspA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/5] node_device_udev.h: Drop unused macro Date: Tue, 25 Oct 2022 17:15:28 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666710951361100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The SYSFS_DATA_SIZE macro is Unused since its introduction in v0.7.3~48. Sorry Dave. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- src/node_device/node_device_udev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_devi= ce_udev.h index eab22a9182..fac0caf5fb 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -22,5 +22,4 @@ =20 #include =20 -#define SYSFS_DATA_SIZE 4096 #define DMI_DEVPATH "/sys/devices/virtual/dmi/id" --=20 2.37.4 From nobody Fri May 3 18:22:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666710958; cv=none; d=zohomail.com; s=zohoarc; b=S4d1DppcbDcctn2hAjfcbvEd0MffaUqTH1ZvLC5iF2OJuEhgvMju13j3OW/g9BbyGo3RNHb5k75+g/5JCjzmPpopWvhyQxoKz8GCb5d20P8pRV1b+e6Qr+tfPOUZFwKp7oz5CBQ87zdLcSYeRWhHwNCWc1lb7IvoGlOF//6tvKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666710958; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=92hwS8GwsRsUX+E5/RNtcuBUQszRfuXsQwvYSzAdjs8=; b=D/xWbRJwBUoecwNO0IOIqojhyoyp1gGE5sBFqGz7TpVHzQc8Yg+lxDhDXKbgDtLcHqvouiCUwciLieHvVx1bhMOj7Lfqg+oS0h6gs46x+oy1Y7fkB1RgiQRJYke4sCjtnml4SBNsMcxxNvhemSz+6kIwOHJZeaOSpQgFt1ri6ME= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1666710958841922.458673396854; Tue, 25 Oct 2022 08:15:58 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-yZupNEi6OReiExnp-iSeHQ-1; Tue, 25 Oct 2022 11:15:48 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 60EEE185A7A3; Tue, 25 Oct 2022 15:15:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4631742222; Tue, 25 Oct 2022 15:15:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9DC9F19465B2; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A24951946597 for ; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 976242027061; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D42920290A5 for ; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710957; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=92hwS8GwsRsUX+E5/RNtcuBUQszRfuXsQwvYSzAdjs8=; b=SqiqSMlFqK2SRByA1I4ztKalmSybo+2RzUc+Rtfd6cLibky6W4k+PGvi2H401Ck6FBujLn b3z99Noj6tJ/fZVyo6+AtPjuaWxawnZ64hIOubyedc83X8c/oK5U/qxCWp5bS6i5nGZQuz 2kkVfoTRL2w8syj7k1N3B8lL4/r4Zlw= X-MC-Unique: yZupNEi6OReiExnp-iSeHQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 2/5] node_device: Move DMI_DEVPATH into node_device_udev.c Date: Tue, 25 Oct 2022 17:15:29 +0200 Message-Id: <8e23ebf128b379c7e6b0cc7a96f0dd06da2a10ad.1666710738.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666710959292100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The DMI_DEVPATH macro is used exclusively within node_device_udev.c. There's no need to expose it. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- src/node_device/node_device_udev.c | 2 ++ src/node_device/node_device_udev.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_devi= ce_udev.c index 07c10f0d88..24ef1c25a9 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -52,6 +52,8 @@ VIR_LOG_INIT("node_device.node_device_udev"); # define TYPE_RAID 12 #endif =20 +#define DMI_DEVPATH "/sys/devices/virtual/dmi/id" + typedef struct _udevEventData udevEventData; struct _udevEventData { virObjectLockable parent; diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_devi= ce_udev.h index fac0caf5fb..911eda2c80 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -21,5 +21,3 @@ #pragma once =20 #include - -#define DMI_DEVPATH "/sys/devices/virtual/dmi/id" --=20 2.37.4 From nobody Fri May 3 18:22:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666711028; cv=none; d=zohomail.com; s=zohoarc; b=l++GMmG/PRG51Ywr807OGR/CWhR6Qu5pKxHYw26ZSMl5eeGfNbWaxOMFtcxS3N8bL/ZoSlhIIPYITQwhnSrIfuh+vBHXbJVsDjndvGTulrBuLG77eM5Hm2H6sfaMprMmCeHg1mj+1H3kG1jEzIQG2eEWma1lMNcd7wLva9Bmzas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666711028; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0rxf6ddJkNj5K8VnXdVfZn0CZQ36cjEXdA/TXQqSWuY=; b=ePHMX0m7QEzFW9JFsAqW37s+6JVJ0HdKgIZe4LBjMZoMd9AlE/Y9s2xVssrn04oLRZFSreLcFswXwT7CAp+phOcoOxDAs0mS/pVBvWvwy1SqE1ZCpNz9u6IN41C9jDWyc85pWheSJRdzGce2tSrKCtjaPJTGW33qzEm2x+c+Y2s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1666711028674909.6113700848581; Tue, 25 Oct 2022 08:17:08 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-370-fK1kpqm9ObGbjH_hXRAVag-1; Tue, 25 Oct 2022 11:15:42 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8EC0F85704B; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78E7E23177; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 572F419465B2; Tue, 25 Oct 2022 15:15:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 600521946597 for ; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3623C200BA63; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF92F2027061 for ; Tue, 25 Oct 2022 15:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666711026; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0rxf6ddJkNj5K8VnXdVfZn0CZQ36cjEXdA/TXQqSWuY=; b=HKO0oPl7+Hka9Ccpl9OhWqoC5Ru2X8GH05vEXA0Su/nWka33M5uZbbIz5IZX6yge5dbE01 g0p6zLertRpLo9M4s3S9MfryaS63fPDWvB61o2oE+ZEvD3NVAcHd+bTEqs7foAKbXvcknj KLZE4xIiYR8tL6/sBk/QYZ83V5Ns1i4= X-MC-Unique: fK1kpqm9ObGbjH_hXRAVag-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/5] node_device_udev.h: Drop include of libudev.h Date: Tue, 25 Oct 2022 17:15:30 +0200 Message-Id: <221b2defb599ac71d4ee4b5e3d5008d4d4ce5c59.1666710738.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666711029604100003 Content-Type: text/plain; charset="utf-8"; x-default="true" Nothing in the header file requires the include of libudev.h, as the former header file is now empty. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- src/node_device/node_device_udev.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_devi= ce_udev.h index 911eda2c80..8f60cbfe1b 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -19,5 +19,3 @@ */ =20 #pragma once - -#include --=20 2.37.4 From nobody Fri May 3 18:22:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666710953; cv=none; d=zohomail.com; s=zohoarc; b=APNcBihoQfgAArdzp1GbTICTrUTvtwp+26JHPMh7/N4woGaDsFThcBqwpep6ssLDv4QBR2voNa2rPzC56jVjIPm0RG96Fc0yN10YIFf099ZSAKJCrccDnvvupiNMBgNJtjgS5MZosdK5TOX6j54l60qD/GnDSfU0J2s/Sehs8GM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666710953; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PtdrJOqKl1GbjoHYTVQSdMIQF+7tDYqUyR/Rulc2Y7E=; b=VRAuA3NP87bwa71fYDscqxhh5TaEJfdgVeHkbM+zPZYQYPNEQIQDb9RGtLylAzS6Y2JWhbU20cOuCMGjJOhTXbOHDaf6s3V7HJSgvGh8D/+DdFTqIh7NtmSMztdewnRC55dDg0/vsy0ncT1NMnS+UZdvTbwv+hgi0Dw9Gaxalgo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1666710953670885.1327496422546; Tue, 25 Oct 2022 08:15:53 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-7Jml391kMFmMffhZhFyApA-1; Tue, 25 Oct 2022 11:15:49 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBFA985545D; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2F28C15BB2; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 10DB4194706A; Tue, 25 Oct 2022 15:15:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E12471946597 for ; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id C7D43202903F; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DC742028E98 for ; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666710952; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PtdrJOqKl1GbjoHYTVQSdMIQF+7tDYqUyR/Rulc2Y7E=; b=RKgkYDl3ooCRuFeP9N8HxwDpQo6vB/umU8JmXn0bu1keEiIPNwgha0yZrul6B4igcXtfNL TWh5xXsSGup8oKVd5cwNoAUwFZK0v0AeocEQ3g+g6hqnNVyOWiXegQly9d6gLpfpEaYyDr 8ed30uqx1HJ/DWSlSHLuscZlMGiTrdA= X-MC-Unique: 7Jml391kMFmMffhZhFyApA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 4/5] node_device: Move fwd declaration of udevNodeRegister() into correct header file Date: Tue, 25 Oct 2022 17:15:31 +0200 Message-Id: <1c8fb052ad04dc843796b015f507358c3543512c.1666710738.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666710955187100005 Content-Type: text/plain; charset="utf-8"; x-default="true" Currently, udevNodeRegister() is forward declared in node_device_driver.h even though the function is implemented in node_device_udev.c which warrants node_device_udev.h header file. Move the declaration into the correct file. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- src/node_device/node_device_driver.c | 3 +++ src/node_device/node_device_driver.h | 6 ------ src/node_device/node_device_udev.h | 3 +++ 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_de= vice_driver.c index 8e93b0dd6f..5bde05d593 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -35,6 +35,9 @@ #include "node_device_conf.h" #include "node_device_event.h" #include "node_device_driver.h" +#if WITH_UDEV +# include "node_device_udev.h" +#endif #include "virvhba.h" #include "viraccessapicheck.h" #include "virutil.h" diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_de= vice_driver.h index 7311b603ac..6f835bc71a 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -28,12 +28,6 @@ =20 #define LINUX_NEW_DEVICE_WAIT_TIME 60 =20 -#ifdef WITH_UDEV -int -udevNodeRegister(void); -#endif - - typedef enum { MDEVCTL_CMD_START, MDEVCTL_CMD_STOP, diff --git a/src/node_device/node_device_udev.h b/src/node_device/node_devi= ce_udev.h index 8f60cbfe1b..3d1a156863 100644 --- a/src/node_device/node_device_udev.h +++ b/src/node_device/node_device_udev.h @@ -19,3 +19,6 @@ */ =20 #pragma once + +int +udevNodeRegister(void); --=20 2.37.4 From nobody Fri May 3 18:22:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1666711025; cv=none; d=zohomail.com; s=zohoarc; b=UEoWlS0Gg1ALIq+Ljb9KKMfIsKpYMXz2GS261jTpjphauenj3rdiNe/z1FtK3i4eI4C0/0yIO2S1omjKD3+4Ne+yd4rJEr9PxJsedWdNbGIHNl5yO0ra1P4jPLchyLzI8wC6aUidb0ifCHx9FhNZniOzFM5L2QQQSOUDErxfb7I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1666711025; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Io0B8HZxQI4ul/6m8wjJnNkZl2cVwIakgZkoJaAptfw=; b=lA9DM6ih1O5BR4qn00Bt9xnDeZ594fgpXBTzyB2Xmzz40mBTrOv8Bagasxtsx5bZa8+dwjSicsv3YFzRnF7oxG92dXSgpfR1HlbnbLxy5zxNZXbdW1N7mvbGz4IEdIWE1v83LCImL8LmZNXrEIh7d3NK2e7wfcrQXPzlzfBqopY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1666711025926270.1097719694776; Tue, 25 Oct 2022 08:17:05 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-rtugURHqPQO8RMHVM9wxxg-1; Tue, 25 Oct 2022 11:15:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DDE6E3800C24; Tue, 25 Oct 2022 15:15:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C65AA201F402; Tue, 25 Oct 2022 15:15:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6977519465B2; Tue, 25 Oct 2022 15:15:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8194E1947B91 for ; Tue, 25 Oct 2022 15:15:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 65E54200BA63; Tue, 25 Oct 2022 15:15:36 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C1502027061 for ; Tue, 25 Oct 2022 15:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666711024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Io0B8HZxQI4ul/6m8wjJnNkZl2cVwIakgZkoJaAptfw=; b=IbPHNHLprxMd5RUR5IGkiwqW945fpr951QDEmJ6fMQ932dx1BjxZCD02A0RbSTMvtjT7NH c95a1pBlZZLYeIhSTGG1dI9aablvkw0cABRfSyDRLiSTGT5BtKqxmrKxFvCT4ekyrCar8u K/a2W74swzQXcn8yVNDKnT80dtjtreQ= X-MC-Unique: rtugURHqPQO8RMHVM9wxxg-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 5/5] node_device_driver.h: Drop nodeDeviceLock() and nodeDeviceUnlock() fwd declarations Date: Tue, 25 Oct 2022 17:15:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1666711027657100001 Content-Type: text/plain; charset="utf-8"; x-default="true" The node_device_driver.h declares nodeDeviceLock() and nodeDeviceUnlock() functions which used to exist, but after rework to automatic mutex management they exist no more. Their last use was removed in v8.1.0-rc1~122. Signed-off-by: Michal Privoznik Reviewed-by: Jonathon Jongsma --- src/node_device/node_device_driver.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_de= vice_driver.h index 6f835bc71a..c7d5e22daf 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -46,12 +46,6 @@ typedef enum { VIR_ENUM_DECL(virMdevctlCommand); =20 =20 -void -nodeDeviceLock(void); - -void -nodeDeviceUnlock(void); - extern virNodeDeviceDriverState *driver; =20 int --=20 2.37.4