qemu: Update capabilities and use 'tls-hostname' field for NBD

[PATCH 03/10] qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support

Posted by Peter Krempa 3 years, 11 months ago

We do support non-shared storage migration with TLS now. Fix the comment
claiming otherwise.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_migration.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 43ee094486..42fc5c5d62 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -4144,10 +4144,7 @@ qemuMigrationSrcRun(virQEMUDriver *driver,
                 host = spec->dest.host.name;
             }

-            /* Currently libvirt does not support setting up of the NBD
-             * non-shared storage migration with TLS. As we need to honour the
-             * VIR_MIGRATE_TLS flag, we need to reject such migration until
-             * we implement TLS for NBD. */
+            /* Allow migration with TLS only when we also support TLS for the NBD connection */
             if (flags & VIR_MIGRATE_TLS &&
                 !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV_DEL)) {
                 virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
-- 
2.35.1

Re: [PATCH 03/10] qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support

Posted by Ján Tomko 3 years, 11 months ago

On a Thursday in 2022, Peter Krempa wrote:
>We do support non-shared storage migration with TLS now. Fix the comment
>claiming otherwise.
>

Fixes: a8dc146a4d14b6f169f27b6d238452beb254a637

>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_migration.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano