From nobody Mon Feb 9 04:46:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646915162; cv=none; d=zohomail.com; s=zohoarc; b=EUa+vyLnkkTEku7qTYihPKrk0CjDroboRUu0OcY5O9AmL49gjcZ2JJvP402orc8eOQPR9WoK5/Qin5Bj65Tz1oklfAqmNYLUXZ0bpUqVYKxgXHfiusgPZtteg2i4kNwygavX6fReZZ31bcveLeVC2sRGq+JMUndoX6wXfGMgjYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646915162; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=roxtRU/HvBp+1ugWGhXnfTXImF7Qad2hn7Yqw7byr8c=; b=GTJkLlGd4bzTBnUhvuRl4+z1el8el07zlQ28TORPly7PVPms9HMkWvrlHGzcSXICGcS+aJt7Zn534UPFVermMU0F3R3ergi4DPDFeGyszCDyoq5aMWnr51MkbbDjMEFOrQ40WB8Q6OkYJYnuvBV+Fw6uvIpcVirpeXSmay6J1g0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1646915162855925.539817329146; Thu, 10 Mar 2022 04:26:02 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-198-JmL2OEBdMTiMj9IOvBAJcA-1; Thu, 10 Mar 2022 07:25:59 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4113E381AA0F; Thu, 10 Mar 2022 12:25:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E7F2141DED9; Thu, 10 Mar 2022 12:25:57 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 094F3195357C; Thu, 10 Mar 2022 12:25:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5E9EA195356D for ; Thu, 10 Mar 2022 12:25:56 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 0C7ED100687E; Thu, 10 Mar 2022 12:25:56 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69829105B1FD for ; Thu, 10 Mar 2022 12:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646915162; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=roxtRU/HvBp+1ugWGhXnfTXImF7Qad2hn7Yqw7byr8c=; b=fgzs9g+VP7EccPpl2kFZo3jFJS/90Rchv39j1A2UHE5xwMnkOEQVrbMERH9jjOviLPJ7+R pRnohDF3SbODEbmKQl7fUgdbAB6vqnZup71cxPgRX2a6tNNua2oaXxP6124mIVSTG8ixCV dnZn+hAE9tYCFVkA1xTIf5U20vvTeiQ= X-MC-Unique: JmL2OEBdMTiMj9IOvBAJcA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 03/10] qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support Date: Thu, 10 Mar 2022 13:25:22 +0100 Message-Id: <356bf7905a4e8eb8df6b6cc617ecd9f2593d4f04.1646915027.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646915164092100001 Content-Type: text/plain; charset="utf-8" We do support non-shared storage migration with TLS now. Fix the comment claiming otherwise. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_migration.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 43ee094486..42fc5c5d62 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4144,10 +4144,7 @@ qemuMigrationSrcRun(virQEMUDriver *driver, host =3D spec->dest.host.name; } - /* Currently libvirt does not support setting up of the NBD - * non-shared storage migration with TLS. As we need to honour= the - * VIR_MIGRATE_TLS flag, we need to reject such migration until - * we implement TLS for NBD. */ + /* Allow migration with TLS only when we also support TLS for = the NBD connection */ if (flags & VIR_MIGRATE_TLS && !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV_DEL)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", --=20 2.35.1