[PATCH 0/8] kbase: debuglogs: Include guidance how to setup logging with modular daemons

Peter Krempa posted 8 patches 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1642433476.git.pkrempa@redhat.com
There is a newer version of this series
docs/daemons.rst         |  47 ++++++++
docs/kbase/debuglogs.rst | 239 ++++++++++++++++++++++++++++++---------
2 files changed, 235 insertions(+), 51 deletions(-)
[PATCH 0/8] kbase: debuglogs: Include guidance how to setup logging with modular daemons
Posted by Peter Krempa 2 years, 3 months ago
Modular daemons are the default in many cases yet, one of our most
frequented documents neglects to describe the intricacies of the setup.

Browsable result is available at:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/daemons.html#checking-whether-modular-monolithic-mode-is-in-use
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/kbase/debuglogs.html

Sorry for TLS warnings. Gitlab didn't really think through allowing
users to pick username with a dot and I refuse to change it.

Peter Krempa (8):
  docs: daemons: Add section on figuring out whether modular or
    monolithic daemon is in use
  kbase: debuglogs: Use common heading hierarchy
  kbase: debuglogs: Un-nest section on enabling debug logs
  kbase: debuglogs: Section off the settings for legacy libvirt
  kbase: debuglogs: Add a section describing log outputs and filters
  kbase: debuglogs: Extract client library logging setup
  kbase: debuglogs: Emphasise 'virt-admin'
  kbase: debuglogs: Fix for modular daemons

 docs/daemons.rst         |  47 ++++++++
 docs/kbase/debuglogs.rst | 239 ++++++++++++++++++++++++++++++---------
 2 files changed, 235 insertions(+), 51 deletions(-)

-- 
2.34.1

Re: [PATCH 0/8] kbase: debuglogs: Include guidance how to setup logging with modular daemons
Posted by Erik Skultety 2 years, 3 months ago
On Mon, Jan 17, 2022 at 04:39:08PM +0100, Peter Krempa wrote:
> Modular daemons are the default in many cases yet, one of our most
> frequented documents neglects to describe the intricacies of the setup.
> 
> Browsable result is available at:
> https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/daemons.html#checking-whether-modular-monolithic-mode-is-in-use
> https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1983126893/artifacts/website/kbase/debuglogs.html
> 
> Sorry for TLS warnings. Gitlab didn't really think through allowing
> users to pick username with a dot and I refuse to change it.

I had more stylistic nitpicks in 8/8, but overall it looks good. Thank you for
improving our knowledge base documentation.

Erik