[v2] kbase: debuglogs: Include guidance how to setup logging with modular daemons

[PATCH v2 0/3] kbase: debuglogs: Include guidance how to setup logging with modular daemons

Peter Krempa posted 3 patches 2 years, 3 months ago

Diff against v1
Download series mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1642692813.git.pkrempa@redhat.com

docs/daemons.rst             | 52 +++++++++++++++++++
docs/kbase/debuglogs.rst     | 98 +++++++++++++++++++++++++++++-------
docs/manpages/virt-admin.rst | 22 +++++---
3 files changed, 147 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH v2 0/3] kbase: debuglogs: Include guidance how to setup logging with modular daemons

Posted by Peter Krempa 2 years, 3 months ago

v2 includes changes suggested by Erik. Patches 2/8 - 7/8 of the original
series were pushed.

1/3 corresponds to 1/8.

  The issue of which daemons are actually provided by libvirt was solved
  by linking to a chapter above where the daemons are enumerated.

2/3 corresponds to 8/8.

  Eriks changes were incorporated (hopefully).

3/3 is new in this series

  Improve the 'virt-admin' man page to mention how URIs are constructed.

Processed output is at:
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1997481301/artifacts/website/kbase/debuglogs.html
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1997481301/artifacts/website/daemons.html#checking-whether-modular-monolithic-mode-is-in-use
https://pipo.sk.gitlab.io/-/libvirt/-/jobs/1997481301/artifacts/website/manpages/virt-admin.html#notes

Peter Krempa (3):
  docs: daemons: Add section on figuring out whether modular or
    monolithic daemon is in use
  kbase: debuglogs: Fix for modular daemons
  man: virt-admin: Mention monolithic daemon URIs

 docs/daemons.rst             | 52 +++++++++++++++++++
 docs/kbase/debuglogs.rst     | 98 +++++++++++++++++++++++++++++-------
 docs/manpages/virt-admin.rst | 22 +++++---
 3 files changed, 147 insertions(+), 25 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/3] kbase: debuglogs: Include guidance how to setup logging with modular daemons

Posted by Erik Skultety 2 years, 3 months ago

On Thu, Jan 20, 2022 at 04:34:00PM +0100, Peter Krempa wrote:
> v2 includes changes suggested by Erik. Patches 2/8 - 7/8 of the original
> series were pushed.
> 
> 1/3 corresponds to 1/8.
> 
>   The issue of which daemons are actually provided by libvirt was solved
>   by linking to a chapter above where the daemons are enumerated.

Oh yeah, this is actually better, I missed the fact that they're already
enumerated above...