[PATCH 8/8] Do not print error in remote_daemon.c:main

Martin Kletzander posted 8 patches 4 years, 1 month ago
[PATCH 8/8] Do not print error in remote_daemon.c:main
Posted by Martin Kletzander 4 years, 1 month ago
There is no need to do that since both fallible functions do that already.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/remote/remote_daemon.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
index 8a4610da83c8..84157e6cc19a 100644
--- a/src/remote/remote_daemon.c
+++ b/src/remote/remote_daemon.c
@@ -826,10 +826,8 @@ int main(int argc, char **argv) {
     };
 
     if (virGettextInitialize() < 0 ||
-        virInitialize() < 0) {
-        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
+        virInitialize() < 0)
         exit(EXIT_FAILURE);
-    }
 
     virUpdateSelfLastChanged(argv[0]);
 
-- 
2.34.1

Re: [PATCH 8/8] Do not print error in remote_daemon.c:main
Posted by Erik Skultety 4 years, 1 month ago
On Tue, Jan 04, 2022 at 02:47:12PM +0100, Martin Kletzander wrote:
> There is no need to do that since both fallible functions do that already.
> 
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>