From nobody Sun Feb 8 20:58:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1641304065; cv=none; d=zohomail.com; s=zohoarc; b=GDzJkj0BBcnIVAwK1Oe5GAPk2kIK9PMRWuhE+SAGOGkRgD/O8fczbyG2FPKe6OSWiGq61rIlE3p186YmQqqX+vPL4/XjjEcHV0YrxA4ETimqgjF8iRfaeJo+kt9qcsmeDYsciWqXdibB9V0B80qGdrcF44aLY5Ssxc6NX3kCV60= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641304065; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AxNtBR3QbTH8t061JzyRqjM00+iftwUmIzyodr0zays=; b=I6Le8jyXhzlTEziTczWY63lWeGenWlVmpmaVly6KuemDmx+Aym9t99yLJaqQ7yGyS25PWXRx7/ronwuskeUlzolO2zJDtfbIq+w9hhnjqXbpJZC4H3jLfAHkNQn1GrQy5mUTpGyzFVVe80drG0nmP6ExTFMoUM9TqwB06E3L6fw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1641304065113900.1037957718629; Tue, 4 Jan 2022 05:47:45 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-u1urf5IrPomcocwzH0FaEA-1; Tue, 04 Jan 2022 08:47:42 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 966D0802C98; Tue, 4 Jan 2022 13:47:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 669222B4B6; Tue, 4 Jan 2022 13:47:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0AF721809CB9; Tue, 4 Jan 2022 13:47:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 204DlOev019615 for ; Tue, 4 Jan 2022 08:47:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id ED32F2166B41; Tue, 4 Jan 2022 13:47:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E81D02166B2F for ; Tue, 4 Jan 2022 13:47:21 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D56B61064E6A for ; Tue, 4 Jan 2022 13:47:21 +0000 (UTC) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-kZr75ACUNeqPZdU1Npvf5w-1; Tue, 04 Jan 2022 08:47:20 -0500 Received: by mail-wr1-f72.google.com with SMTP id s23-20020adf9797000000b001a24674f0f7so11743703wrb.9 for ; Tue, 04 Jan 2022 05:47:20 -0800 (PST) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id j13sm43326794wmq.11.2022.01.04.05.47.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 05:47:18 -0800 (PST) Received: from wheatley.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id 7D58F2FEE744 for ; Tue, 4 Jan 2022 14:47:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641304064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AxNtBR3QbTH8t061JzyRqjM00+iftwUmIzyodr0zays=; b=ZjYkYar/Kc46G51We9jOM+qoBhkJzLv2rGyylPKu+v8fxDXdPlWtML/B6uYRcmYbzOlNZy 7ieIf5M9H42Zo0vTknpKLq/fNqCDv3FUk2B6OmyQPTzJdupLfRJjaCnKnrCJuy75r9vynA CZu1uw0HUUbo0Y3tv0uKuK1OCgjIigI= X-MC-Unique: u1urf5IrPomcocwzH0FaEA-1 X-MC-Unique: kZr75ACUNeqPZdU1Npvf5w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AxNtBR3QbTH8t061JzyRqjM00+iftwUmIzyodr0zays=; b=v3xxhfhGHJEXGJzlkhs3QKQxPnEux41pRKLhdB0Qoi3aOG1T58crhjBKXiNtUHZGID 8qBkkvtWth++L2q40KqRoDeF/Ma0xiiKMxfN0UA6JhHdBC3hKJw6gbZVWZeb9IvAYo44 X3CCU66OrytRuod5hJGmUntfbSrxalNbxNKb6hr8nH63qTb0moXYpeNZVwk9WgFpqb2H kuHmy/MQ07b1+sCcBWsH4TGEXBAGp37SwZxPxBcwo9tRIXlwXspBMtTh5xi1IeSNIZKF YRMeNUE3mTmEsxeUcYDliP5LQVb5ifpWpQYBGAo4PSPSPUSuhO7jpRVVEUxa+jX03CYy S5KQ== X-Gm-Message-State: AOAM533dPch7b5fR47LwCh9zHnRjNQmrqE2AA82lEFjNBK0ba/ELxoyC Kc2WcAee5PK+NMhK0YxNU/OSJ76QO28RQWG+zYDoYbVG5D6XqmzE5zkj59sUwHS0hEL3z9MhGyx YDTSqKEIwdAo7AID+4cTGDANRGWZtLFAxbBI89WgBMdCtpX3NiM5W1dZxjPT44kuiUFLnfzs= X-Received: by 2002:a5d:6d05:: with SMTP id e5mr42405397wrq.46.1641304039581; Tue, 04 Jan 2022 05:47:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrLRozME8HZC+BwUwDrtqj+Lm6cgrTaFu37ibiyoLXGfbIRS6OcoRH+jUBV7BhwAye0gcrjQ== X-Received: by 2002:a5d:6d05:: with SMTP id e5mr42405390wrq.46.1641304039365; Tue, 04 Jan 2022 05:47:19 -0800 (PST) From: Martin Kletzander To: libvir-list@redhat.com Subject: [PATCH 8/8] Do not print error in remote_daemon.c:main Date: Tue, 4 Jan 2022 14:47:12 +0100 Message-Id: <1e74059c99223d4f43dd6d28dd8e5b17eae08593.1641303832.git.mkletzan@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1641304066382100003 Content-Type: text/plain; charset="utf-8" There is no need to do that since both fallible functions do that already. Signed-off-by: Martin Kletzander Reviewed-by: Erik Skultety --- src/remote/remote_daemon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index 8a4610da83c8..84157e6cc19a 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -826,10 +826,8 @@ int main(int argc, char **argv) { }; =20 if (virGettextInitialize() < 0 || - virInitialize() < 0) { - fprintf(stderr, _("%s: initialization failed\n"), argv[0]); + virInitialize() < 0) exit(EXIT_FAILURE); - } =20 virUpdateSelfLastChanged(argv[0]); =20 --=20 2.34.1