qemu: Type-aware generation of properties for -device (part 1)

[PATCH 044/103] qemuBuildDeviceVideoStr: Properly format virtio options for 'virtio-vga'

Posted by Peter Krempa 4 years, 4 months ago

'virtio-vga' is a virtio device but we didn't use the virtio formatter
for it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index daaccff9b6..dc3320ba9a 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4475,7 +4475,7 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,
     if (!(model = qemuDeviceVideoGetModel(qemuCaps, video, &virtio, &virtioBusSuffix)))
         return NULL;

-    if (virtioBusSuffix) {
+    if (virtio) {
         if (qemuBuildVirtioDevStr(&buf, qemuCaps, VIR_DOMAIN_DEVICE_VIDEO, video) < 0) {
             return NULL;
         }
-- 
2.31.1

Re: [PATCH 044/103] qemuBuildDeviceVideoStr: Properly format virtio options for 'virtio-vga'

Posted by Ján Tomko 4 years, 4 months ago

On a Thursday in 2021, Peter Krempa wrote:
>'virtio-vga' is a virtio device but we didn't use the virtio formatter
>for it.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_command.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano