From nobody Mon Feb 9 09:15:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1633622979; cv=none; d=zohomail.com; s=zohoarc; b=QeqxWNBQhcYZ5GEIDBHxEqDPFnxZR5P4uXaYvhuxG+nk1hqqrcas0sITRmSHCjoXlTnVUpgw1IqfRa40ejAtSo3IbARKZthOE6X3hYlQZK0xrLCom3o15TQfGouOLI37Xe82EfEkH9bkSW3mTJwNi56yA045taJwxyYauaTDSLI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1633622979; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w3NimX6QrLAzESvK5M3BBUv7yeqo/9jkai3Eb7jolPI=; b=PlaJWL9dShZeTXtEpcf5tY4s9wnj21YwXNpITZBPmWQpBWKVHusbBX/wHEac8UFItuRtvkNAiWPRzAQ9ZjgmuhCX8K4CMd0ltWZL4MMVF5qbTEs1AGHJKMcCsmi0L5vitM+ZtKx+W2rZ5/sAHiHlibxAr6bXBLu1K9OpqsA7zYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1633622979653372.1251272615656; Thu, 7 Oct 2021 09:09:39 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-yHWJWZmfNt-zmwiCu4XwMQ-1; Thu, 07 Oct 2021 12:09:35 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DEAC811DAF80; Thu, 7 Oct 2021 15:51:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 978375FCAF; Thu, 7 Oct 2021 15:51:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 09C0B1800B8B; Thu, 7 Oct 2021 15:51:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 197FJNTF023945 for ; Thu, 7 Oct 2021 11:19:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5E0C65F4EE; Thu, 7 Oct 2021 15:19:23 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC5805F4F4 for ; Thu, 7 Oct 2021 15:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633622978; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=w3NimX6QrLAzESvK5M3BBUv7yeqo/9jkai3Eb7jolPI=; b=BQj3eo9tPK4Hnc1fclaoKbXEExJDZGX8BnETbKjjn+Stsc0mb4sn8cof4R28XpFV57j2rZ DEr9vkemxX0P5CpnRVhePBqQu/2P4nLzcPdewQEg2NePINIJyU65NhPWcWAxaWm/5I1XfY 4MYkaEH5acPGH7fgIiuH4q4R5ObCTnw= X-MC-Unique: yHWJWZmfNt-zmwiCu4XwMQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 044/103] qemuBuildDeviceVideoStr: Properly format virtio options for 'virtio-vga' Date: Thu, 7 Oct 2021 17:17:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1633622980901100003 Content-Type: text/plain; charset="utf-8" 'virtio-vga' is a virtio device but we didn't use the virtio formatter for it. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index daaccff9b6..dc3320ba9a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4475,7 +4475,7 @@ qemuBuildDeviceVideoStr(const virDomainDef *def, if (!(model =3D qemuDeviceVideoGetModel(qemuCaps, video, &virtio, &vir= tioBusSuffix))) return NULL; - if (virtioBusSuffix) { + if (virtio) { if (qemuBuildVirtioDevStr(&buf, qemuCaps, VIR_DOMAIN_DEVICE_VIDEO,= video) < 0) { return NULL; } --=20 2.31.1