Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/virsh-secret.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c
index de32f25d64..fcfbe5fe9e 100644
--- a/tools/virsh-secret.c
+++ b/tools/virsh-secret.c
@@ -302,7 +302,6 @@ static bool
 cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
 {
     g_autoptr(virshSecret) secret = NULL;
-    VIR_AUTODISPOSE_STR base64 = NULL;
     g_autofree unsigned char *value = NULL;
     size_t value_size;
     bool plain = vshCommandOptBool(cmd, "plain");
@@ -320,9 +319,10 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
             return false;
         }
     } else {
-        base64 = g_base64_encode(value, value_size);
+        g_autofree char *base64 = g_base64_encode(value, value_size);

         vshPrint(ctl, "%s", base64);
+        virSecureEraseString(base64);
     }

     virSecureErase(value, value_size);
-- 
2.29.2

On Tue, Feb 02, 2021 at 05:56:00PM +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tools/virsh-secret.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|