From nobody Sun Feb 8 18:43:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285146; cv=none; d=zohomail.com; s=zohoarc; b=QFAUOkFS9U4jpCV0AAjX4eckHQCaMjtaCuuqECNQItzQPVthO/kgVrzyaFApkAW3XYeU6R/G2cbQdbFCwrekQAbV4GZwixC2UuizjdVG0g6C2BNUeETxXduL3Uddy8fTdWR4JY4sN4al7x3zOnN//jkCkHNtr0lGgOS+naN5Jss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285146; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AOf3OFTt33r+Ts/w5rFjyVvBxB1fkPerQYjuX73it3c=; b=j6hWWQmFGGMZSA5xtHeIukU8eLr77sbLXEtogDLOs1TxxkbBMXNkdPG5/QQatFLIc8PLQ73M7WVCGNwUg0K9DUAAZw4V4g8pHIItWlK7bNKGkEvaxsZtFuiUKoC/oY82RM34O9CO0igONaujCOVUZBmnEU1ure3+H0A0ps1DHxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612285146949316.24307561357216; Tue, 2 Feb 2021 08:59:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-MadTGbOTNJGKLBpxl8le3g-1; Tue, 02 Feb 2021 11:57:47 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B23415720; Tue, 2 Feb 2021 16:57:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC6EE5C22B; Tue, 2 Feb 2021 16:57:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A3CE618095CC; Tue, 2 Feb 2021 16:57:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 112Gvd2B015531 for ; Tue, 2 Feb 2021 11:57:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 6A82360862; Tue, 2 Feb 2021 16:57:39 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 681916EF46 for ; Tue, 2 Feb 2021 16:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612285145; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AOf3OFTt33r+Ts/w5rFjyVvBxB1fkPerQYjuX73it3c=; b=WIuuMBuacnI/vuQW2TnoXlkCtIdF1PruVMM3Au/i8VJN8CVNmdV+E84/pOOhLi0cZqMQUQ DS/ufP7BhphAuCHIyFUtpL9Oe0VP1iWjZy9ldYRnKnzh5zuGyD71k+ogLi22tauHK9L41E lV1AwH2mIa1kYgqQJ+tkSxLwhvvdixM= X-MC-Unique: MadTGbOTNJGKLBpxl8le3g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 23/27] cmdSecretGetValue: Use virSecureEraseString instead of VIR_AUTODISPOSE_STR Date: Tue, 2 Feb 2021 17:56:00 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/virsh-secret.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index de32f25d64..fcfbe5fe9e 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -302,7 +302,6 @@ static bool cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshSecret) secret =3D NULL; - VIR_AUTODISPOSE_STR base64 =3D NULL; g_autofree unsigned char *value =3D NULL; size_t value_size; bool plain =3D vshCommandOptBool(cmd, "plain"); @@ -320,9 +319,10 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) return false; } } else { - base64 =3D g_base64_encode(value, value_size); + g_autofree char *base64 =3D g_base64_encode(value, value_size); vshPrint(ctl, "%s", base64); + virSecureEraseString(base64); } virSecureErase(value, value_size); --=20 2.29.2