qemu: Add <transient/> disk support

[PATCH v4 08/11] qemu: process: Handle transient disks on VM startup

Posted by Peter Krempa 5 years, 4 months ago

From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

Add overlays after the VM starts before we start executing guest code.

Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_process.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index ffb3afa9c5..9122069cc9 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -60,6 +60,7 @@
 #include "qemu_firmware.h"
 #include "qemu_backup.h"
 #include "qemu_dbus.h"
+#include "qemu_snapshot.h"

 #include "cpu/cpu.h"
 #include "cpu/cpu_x86.h"
@@ -7077,6 +7078,10 @@ qemuProcessLaunch(virConnectPtr conn,
         qemuProcessAutoDestroyAdd(driver, vm, conn) < 0)
         goto cleanup;

+    VIR_DEBUG("Setting up transient disk");
+    if (qemuSnapshotCreateDisksTransient(vm, asyncJob) < 0)
+        goto cleanup;
+
     ret = 0;

  cleanup:
-- 
2.26.2

Re: [PATCH v4 08/11] qemu: process: Handle transient disks on VM startup

Posted by Masayoshi Mizuma 5 years, 4 months ago

On Thu, Sep 24, 2020 at 01:43:55PM +0200, Peter Krempa wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> 
> Add overlays after the VM starts before we start executing guest code.
> 
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_process.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index ffb3afa9c5..9122069cc9 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -60,6 +60,7 @@
>  #include "qemu_firmware.h"
>  #include "qemu_backup.h"
>  #include "qemu_dbus.h"
> +#include "qemu_snapshot.h"
> 
>  #include "cpu/cpu.h"
>  #include "cpu/cpu_x86.h"
> @@ -7077,6 +7078,10 @@ qemuProcessLaunch(virConnectPtr conn,
>          qemuProcessAutoDestroyAdd(driver, vm, conn) < 0)
>          goto cleanup;
> 
> +    VIR_DEBUG("Setting up transient disk");
> +    if (qemuSnapshotCreateDisksTransient(vm, asyncJob) < 0)
> +        goto cleanup;
> +
>      ret = 0;
> 
>   cleanup:
> -- 

Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

Thanks a lot!
Masa