This version:
    - is rebased on top of current refactors
    - has more strict rules in the validation
    - adds tests
    - fixes bug with disk-unplug

Masayoshi Mizuma (5):
  qemu: Block blockjobs when transient disk option is enabled
  qemu: Block disk hotplug when transient disk option is enabled
  qemu: Block migration when transient disk option is enabled
  qemu: process: Handle transient disks on VM startup
  qemu: validate: Allow <transient/> disks

Peter Krempa (6):
  virDomainSnapshotDiskDefFree: Export and register as autoptr func
  qemu: prepare cleanup for <transient/> disk overlays
  qemu: snapshot: Introduce helpers for creating overlays on
    <transient/> disks
  qemu: hotplug: Remove overlay of <transient> disk on disk unplug
  tests: qemuxml2argv: Fix and enable 'disk-transient' case
  TODO: Add news entry

 TODO                                          |  0
 docs/formatdomain.rst                         |  5 +-
 src/conf/snapshot_conf.h                      |  5 +
 src/conf/snapshot_conf_priv.h                 |  3 -
 src/qemu/qemu_domain.c                        |  9 ++
 src/qemu/qemu_domain.h                        |  4 +
 src/qemu/qemu_hotplug.c                       | 15 +++
 src/qemu/qemu_migration.c                     | 10 ++
 src/qemu/qemu_process.c                       | 27 ++++++
 src/qemu/qemu_snapshot.c                      | 91 ++++++++++++++++++-
 src/qemu/qemu_snapshot.h                      |  5 +
 src/qemu/qemu_validate.c                      | 56 ++++++++++--
 .../disk-transient.x86_64-4.1.0.err           |  1 +
 .../disk-transient.x86_64-latest.args         | 42 +++++++++
 tests/qemuxml2argvdata/disk-transient.xml     |  4 +-
 tests/qemuxml2argvtest.c                      |  2 +
 16 files changed, 265 insertions(+), 14 deletions(-)
 create mode 100644 TODO
 create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-4.1.0.err
 create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-latest.args

-- 
2.26.2

On a Thursday in 2020, Peter Krempa wrote:
>This version:
>    - is rebased on top of current refactors
>    - has more strict rules in the validation
>    - adds tests
>    - fixes bug with disk-unplug
>
>Masayoshi Mizuma (5):
>  qemu: Block blockjobs when transient disk option is enabled
>  qemu: Block disk hotplug when transient disk option is enabled
>  qemu: Block migration when transient disk option is enabled
>  qemu: process: Handle transient disks on VM startup
>  qemu: validate: Allow <transient/> disks
>
>Peter Krempa (6):
>  virDomainSnapshotDiskDefFree: Export and register as autoptr func
>  qemu: prepare cleanup for <transient/> disk overlays
>  qemu: snapshot: Introduce helpers for creating overlays on
>    <transient/> disks
>  qemu: hotplug: Remove overlay of <transient> disk on disk unplug
>  tests: qemuxml2argv: Fix and enable 'disk-transient' case

Up to here:

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Ján Tomko <jtomko@redhat.com>

Thank you for this feature!


>  TODO: Add news entry
>

If you wait until another feature freeze with writing the NEWS entry,
you can get a reminder about it from Andrea. That is surely worth it.

Jano

> TODO                                          |  0
> docs/formatdomain.rst                         |  5 +-
> src/conf/snapshot_conf.h                      |  5 +
> src/conf/snapshot_conf_priv.h                 |  3 -
> src/qemu/qemu_domain.c                        |  9 ++
> src/qemu/qemu_domain.h                        |  4 +
> src/qemu/qemu_hotplug.c                       | 15 +++
> src/qemu/qemu_migration.c                     | 10 ++
> src/qemu/qemu_process.c                       | 27 ++++++
> src/qemu/qemu_snapshot.c                      | 91 ++++++++++++++++++-
> src/qemu/qemu_snapshot.h                      |  5 +
> src/qemu/qemu_validate.c                      | 56 ++++++++++--
> .../disk-transient.x86_64-4.1.0.err           |  1 +
> .../disk-transient.x86_64-latest.args         | 42 +++++++++
> tests/qemuxml2argvdata/disk-transient.xml     |  4 +-
> tests/qemuxml2argvtest.c                      |  2 +
> 16 files changed, 265 insertions(+), 14 deletions(-)
> create mode 100644 TODO
> create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-4.1.0.err
> create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-latest.args
>
>-- 
>2.26.2
>

---
 TODO | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 TODO

diff --git a/TODO b/TODO
new file mode 100644
index 0000000000..e69de29bb2
-- 
2.26.2

On 9/24/20 6:43 AM, Peter Krempa wrote:
> ---
>   TODO | 0
>   1 file changed, 0 insertions(+), 0 deletions(-)
>   create mode 100644 TODO
> 
> diff --git a/TODO b/TODO
> new file mode 100644
> index 0000000000..e69de29bb2

TODO: add my review here...

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org