qemu: backup: Fixes and improvements

[libvirt] [PATCH 02/11] qemu: Reset the node-name allocator in qemuDomainObjPrivateDataClear

Posted by Peter Krempa 6 years, 1 month ago

qemuDomainObjPrivateDataClear clears state which become invalid after VM
stopped running and the node name allocator belongs there.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c  | 3 +++
 src/qemu/qemu_process.c | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index ff87720fd1..0e073c25e1 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -2238,6 +2238,9 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr priv)

     virDomainBackupDefFree(priv->backup);
     priv->backup = NULL;
+
+    /* reset node name allocator */
+    qemuDomainStorageIdReset(priv);
 }


diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 7e1db50e8f..e6c6c0bee2 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -7672,9 +7672,6 @@ void qemuProcessStop(virQEMUDriverPtr driver,
     /* clear all private data entries which are no longer needed */
     qemuDomainObjPrivateDataClear(priv);

-    /* reset node name allocator */
-    qemuDomainStorageIdReset(priv);
-
     /* The "release" hook cleans up additional resources */
     if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) {
         char *xml = qemuDomainDefFormatXML(driver, NULL, vm->def, 0);
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/11] qemu: Reset the node-name allocator in qemuDomainObjPrivateDataClear

Posted by Daniel P. Berrangé 6 years, 1 month ago

On Fri, Dec 20, 2019 at 02:25:20PM +0100, Peter Krempa wrote:
> qemuDomainObjPrivateDataClear clears state which become invalid after VM
> stopped running and the node name allocator belongs there.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_domain.c  | 3 +++
>  src/qemu/qemu_process.c | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list