From nobody Sun Feb 8 05:37:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576848364; cv=none; d=zohomail.com; s=zohoarc; b=AnJVxGCA7RAWYS6MuhXOJcfNj2n9GjfJEM2BPUuVCiuw60fK7zoQWbtY+6vdOaKbUFOh7KU85ittcOD95XVNJqTSsvY7e+1LZIlzK/K0hf4KrG3zPZtLFo6+BcyOhisSKf+hlYOBxuOYQ107tZq+6XVNcukutpFYT4nM9w+OZDo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576848364; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Pvxn4T42hWUbhIKtNYHoGfhdyXfmA1PUxsx8LVz1TGA=; b=ap1+cuhrTNZxcYGg3p0UFgz+xclsOphBSRW4L91CFyDbeINJOsd67Sa2vdalwnDjC0q8PQa5kixWwj97vqVhDjxyltfV6fF7am5PDwaLwNBtBlPH1OXPYS9zQK3s8rJ2gj7NdavzzRP5/VrXAbX+cWtoto62t82gQC9sKBaKpgc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1576848364707968.211810297648; Fri, 20 Dec 2019 05:26:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-GVTIuJpkOTCln33O5taDiQ-1; Fri, 20 Dec 2019 08:26:01 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93DEA18543A8; Fri, 20 Dec 2019 13:25:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F15B6B8E6; Fri, 20 Dec 2019 13:25:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2F58C182B015; Fri, 20 Dec 2019 13:25:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBKDPbK2028844 for ; Fri, 20 Dec 2019 08:25:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id BDB1B1CE; Fri, 20 Dec 2019 13:25:37 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 462D963B93 for ; Fri, 20 Dec 2019 13:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576848363; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Pvxn4T42hWUbhIKtNYHoGfhdyXfmA1PUxsx8LVz1TGA=; b=ZF35qnm9brRvxoTYCAVctH46wm6aTL88h7wyDSTHAwvrZ26xts/78YSH9zNLDY/B6q1CUS WQq1+rL4ptHjVaSk4cL4nXcegoHv6HB51gzujzY6aJ0KIQxMN4L5fWKkt8vIyZLsRuYNZA SwO6iuiZVupAlM3G01Ekx8DAuqhbMM0= From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 20 Dec 2019 14:25:20 +0100 Message-Id: <3c8a426e0ca719ef8409ab2bfc46a2ee1bd45003.1576847165.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 02/11] qemu: Reset the node-name allocator in qemuDomainObjPrivateDataClear X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: GVTIuJpkOTCln33O5taDiQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" qemuDomainObjPrivateDataClear clears state which become invalid after VM stopped running and the node name allocator belongs there. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_process.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ff87720fd1..0e073c25e1 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2238,6 +2238,9 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr= priv) virDomainBackupDefFree(priv->backup); priv->backup =3D NULL; + + /* reset node name allocator */ + qemuDomainStorageIdReset(priv); } diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7e1db50e8f..e6c6c0bee2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7672,9 +7672,6 @@ void qemuProcessStop(virQEMUDriverPtr driver, /* clear all private data entries which are no longer needed */ qemuDomainObjPrivateDataClear(priv); - /* reset node name allocator */ - qemuDomainStorageIdReset(priv); - /* The "release" hook cleans up additional resources */ if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { char *xml =3D qemuDomainDefFormatXML(driver, NULL, vm->def, 0); --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list