[libvirt] [PATCH v4 00/20] cleanup current build system

Pavel Hrdina posted 20 patches 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1573227570.git.phrdina@redhat.com
.gitignore                          | 276 ++-------------------
.travis.yml                         |   3 +-
README-hacking                      |  11 +-
README.md                           |  11 +-
bootstrap.conf                      |   6 +
build-aux/syntax-check.mk           |  47 ++--
configure.ac                        |   6 +
docs/compiling.html.in              |  10 +-
docs/windows.html.in                |   3 +-
libvirt.spec.in                     |  10 +-
po/Makefile.am                      |  45 ++--
po/POTFILES                         | 320 -------------------------
po/POTFILES.in                      | 356 ++++++++++++++++++++++++++++
po/README.md                        |   3 +
src/Makefile.am                     |  13 +-
src/access/Makefile.inc.am          |  17 +-
src/admin/Makefile.inc.am           |  24 +-
src/bhyve/Makefile.inc.am           |   1 +
src/esx/Makefile.inc.am             |   9 +-
src/esx/esx_vi_generator.py         |  11 +-
src/hyperv/Makefile.inc.am          |   9 +-
src/hyperv/hyperv_wmi_generator.py  |  11 +-
src/interface/Makefile.inc.am       |   2 +
src/libxl/Makefile.inc.am           |   2 +
src/locking/Makefile.inc.am         |  16 +-
src/logging/Makefile.inc.am         |  18 +-
src/lxc/Makefile.inc.am             |  36 ++-
src/network/Makefile.inc.am         |   2 +
src/node_device/Makefile.inc.am     |   2 +
src/nwfilter/Makefile.inc.am        |   2 +
src/qemu/Makefile.inc.am            |   2 +
src/remote/Makefile.inc.am          |  45 ++--
src/remote/remote_daemon_dispatch.c |   4 +-
src/rpc/Makefile.inc.am             |   8 +-
src/secret/Makefile.inc.am          |   2 +
src/storage/Makefile.inc.am         |   2 +
src/util/Makefile.inc.am            |   6 +-
src/vbox/Makefile.inc.am            |   1 +
src/vz/Makefile.inc.am              |   1 +
tests/Makefile.am                   |   4 +
tools/Makefile.am                   |   1 -
41 files changed, 636 insertions(+), 722 deletions(-)
delete mode 100644 po/POTFILES
create mode 100644 po/POTFILES.in

[libvirt] [PATCH v4 00/20] cleanup current build system

Posted by Pavel Hrdina 1 week ago
As preparation to switch to Meson there are some things that needs be
cleaned up to make the conversion easier.

The important thing in Meson is that there is a strict separation
between source and build directory and the distributed tarball by
default contains only files tracked by git with a possibility to
write a script which would add some other sources into the tarball.

Regardless of the adoption of Meson these patches improve our current
build system to fully support VPATH builds.

Changes in v2:
    - some patches from v1 are pushed now
    - added a patch to mandate build dir != src dir
    - added a patch to cleanup .gitignore
    - added patches to fix sc_po_check
    - improved some patches from v1

Changes in v3:
    - python-zanata-client is the tool our Makefile uses

Pavel Hrdina (20):
  build: mandate use of a build dir != src dir
  .gitignore: cleanup old and obsolete ignores
  syntax-check.mk: fix sc_po_check rule
  syntax-check.mk: cleanup sc_po_check dependencies
  syntax-check.mk: cleanup generated_files list for sc_po_check
  po: generate files into build directory
  po: rewrite the way how we generate files
  po: README.md: add a note about which Zanata client is required
  remote: unify rpc server dispatch generated files
  src: generate source files into build directory
  src: access: generate source files into build directory
  src: admin: generate source files into build directory
  src: esx: generate source files into build directory
  src: hyperv: generate source files into build directory
  src: locking: generate source files into build directory
  src: logging: generate source files into build directory
  src: lxc: generate source files into build directory
  src: remote: generate source files into build directory
  src: stop distributing generated source files
  tools: stop distributing generated source files

 .gitignore                          | 276 ++-------------------
 .travis.yml                         |   3 +-
 README-hacking                      |  11 +-
 README.md                           |  11 +-
 bootstrap.conf                      |   6 +
 build-aux/syntax-check.mk           |  47 ++--
 configure.ac                        |   6 +
 docs/compiling.html.in              |  10 +-
 docs/windows.html.in                |   3 +-
 libvirt.spec.in                     |  10 +-
 po/Makefile.am                      |  45 ++--
 po/POTFILES                         | 320 -------------------------
 po/POTFILES.in                      | 356 ++++++++++++++++++++++++++++
 po/README.md                        |   3 +
 src/Makefile.am                     |  13 +-
 src/access/Makefile.inc.am          |  17 +-
 src/admin/Makefile.inc.am           |  24 +-
 src/bhyve/Makefile.inc.am           |   1 +
 src/esx/Makefile.inc.am             |   9 +-
 src/esx/esx_vi_generator.py         |  11 +-
 src/hyperv/Makefile.inc.am          |   9 +-
 src/hyperv/hyperv_wmi_generator.py  |  11 +-
 src/interface/Makefile.inc.am       |   2 +
 src/libxl/Makefile.inc.am           |   2 +
 src/locking/Makefile.inc.am         |  16 +-
 src/logging/Makefile.inc.am         |  18 +-
 src/lxc/Makefile.inc.am             |  36 ++-
 src/network/Makefile.inc.am         |   2 +
 src/node_device/Makefile.inc.am     |   2 +
 src/nwfilter/Makefile.inc.am        |   2 +
 src/qemu/Makefile.inc.am            |   2 +
 src/remote/Makefile.inc.am          |  45 ++--
 src/remote/remote_daemon_dispatch.c |   4 +-
 src/rpc/Makefile.inc.am             |   8 +-
 src/secret/Makefile.inc.am          |   2 +
 src/storage/Makefile.inc.am         |   2 +
 src/util/Makefile.inc.am            |   6 +-
 src/vbox/Makefile.inc.am            |   1 +
 src/vz/Makefile.inc.am              |   1 +
 tests/Makefile.am                   |   4 +
 tools/Makefile.am                   |   1 -
 41 files changed, 636 insertions(+), 722 deletions(-)
 delete mode 100644 po/POTFILES
 create mode 100644 po/POTFILES.in

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 00/20] cleanup current build system

Posted by Laine Stump 1 week ago
make rpm is now broken. I'm making a rash assumption something in this 
series is the cause (if I have time in the morning I'll investigate further)

+ /usr/bin/mkdir -p 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr AUTHORS 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs+ 
cp -pr ChangeLog 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr NEWS 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr README 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr README.md 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
+ cp -pr 'libvirt-docs/*' 
/home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
cp: cannot stat 'libvirt-docs/*': No such file or directory

On 11/8/19 10:42 AM, Pavel Hrdina wrote:
> As preparation to switch to Meson there are some things that needs be
> cleaned up to make the conversion easier.
>
> The important thing in Meson is that there is a strict separation
> between source and build directory and the distributed tarball by
> default contains only files tracked by git with a possibility to
> write a script which would add some other sources into the tarball.
>
> Regardless of the adoption of Meson these patches improve our current
> build system to fully support VPATH builds.
>
> Changes in v2:
>      - some patches from v1 are pushed now
>      - added a patch to mandate build dir != src dir
>      - added a patch to cleanup .gitignore
>      - added patches to fix sc_po_check
>      - improved some patches from v1
>
> Changes in v3:
>      - python-zanata-client is the tool our Makefile uses
>
> Pavel Hrdina (20):
>    build: mandate use of a build dir != src dir
>    .gitignore: cleanup old and obsolete ignores
>    syntax-check.mk: fix sc_po_check rule
>    syntax-check.mk: cleanup sc_po_check dependencies
>    syntax-check.mk: cleanup generated_files list for sc_po_check
>    po: generate files into build directory
>    po: rewrite the way how we generate files
>    po: README.md: add a note about which Zanata client is required
>    remote: unify rpc server dispatch generated files
>    src: generate source files into build directory
>    src: access: generate source files into build directory
>    src: admin: generate source files into build directory
>    src: esx: generate source files into build directory
>    src: hyperv: generate source files into build directory
>    src: locking: generate source files into build directory
>    src: logging: generate source files into build directory
>    src: lxc: generate source files into build directory
>    src: remote: generate source files into build directory
>    src: stop distributing generated source files
>    tools: stop distributing generated source files
>
>   .gitignore                          | 276 ++-------------------
>   .travis.yml                         |   3 +-
>   README-hacking                      |  11 +-
>   README.md                           |  11 +-
>   bootstrap.conf                      |   6 +
>   build-aux/syntax-check.mk           |  47 ++--
>   configure.ac                        |   6 +
>   docs/compiling.html.in              |  10 +-
>   docs/windows.html.in                |   3 +-
>   libvirt.spec.in                     |  10 +-
>   po/Makefile.am                      |  45 ++--
>   po/POTFILES                         | 320 -------------------------
>   po/POTFILES.in                      | 356 ++++++++++++++++++++++++++++
>   po/README.md                        |   3 +
>   src/Makefile.am                     |  13 +-
>   src/access/Makefile.inc.am          |  17 +-
>   src/admin/Makefile.inc.am           |  24 +-
>   src/bhyve/Makefile.inc.am           |   1 +
>   src/esx/Makefile.inc.am             |   9 +-
>   src/esx/esx_vi_generator.py         |  11 +-
>   src/hyperv/Makefile.inc.am          |   9 +-
>   src/hyperv/hyperv_wmi_generator.py  |  11 +-
>   src/interface/Makefile.inc.am       |   2 +
>   src/libxl/Makefile.inc.am           |   2 +
>   src/locking/Makefile.inc.am         |  16 +-
>   src/logging/Makefile.inc.am         |  18 +-
>   src/lxc/Makefile.inc.am             |  36 ++-
>   src/network/Makefile.inc.am         |   2 +
>   src/node_device/Makefile.inc.am     |   2 +
>   src/nwfilter/Makefile.inc.am        |   2 +
>   src/qemu/Makefile.inc.am            |   2 +
>   src/remote/Makefile.inc.am          |  45 ++--
>   src/remote/remote_daemon_dispatch.c |   4 +-
>   src/rpc/Makefile.inc.am             |   8 +-
>   src/secret/Makefile.inc.am          |   2 +
>   src/storage/Makefile.inc.am         |   2 +
>   src/util/Makefile.inc.am            |   6 +-
>   src/vbox/Makefile.inc.am            |   1 +
>   src/vz/Makefile.inc.am              |   1 +
>   tests/Makefile.am                   |   4 +
>   tools/Makefile.am                   |   1 -
>   41 files changed, 636 insertions(+), 722 deletions(-)
>   delete mode 100644 po/POTFILES
>   create mode 100644 po/POTFILES.in
>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 00/20] cleanup current build system

Posted by Pavel Hrdina 1 week ago
On Fri, Nov 08, 2019 at 06:06:08PM -0500, Laine Stump wrote:
> make rpm is now broken. I'm making a rash assumption something in this
> series is the cause (if I have time in the morning I'll investigate further)
> 
> + /usr/bin/mkdir -p /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> + cp -pr AUTHORS /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs+
> cp -pr ChangeLog /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> + cp -pr NEWS /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> + cp -pr README /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> + cp -pr README.md /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> + cp -pr 'libvirt-docs/*' /home/laine/rpmbuild/BUILDROOT/libvirt-5.10.0-1.fc30.x86_64/usr/share/doc/libvirt-docs
> cp: cannot stat 'libvirt-docs/*': No such file or directory

For some reason it's the first patch that changes rpm build to use vpath
build, I'm looking into it as well.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list