From nobody Fri Apr 19 23:55:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1573227962; cv=none; d=zoho.com; s=zohoarc; b=Ru65ijjVjPyCOIiOTVHbn1XHUpvw1TkWRzIm7JUvLTM2Sne8u9+U2WY/cUOxFTp+G8UcHpDUvVZt5tYtVXVs9obdqjCRiDfRvwi6lxCJ/xcL9JIaMWZivQC96xDW7/O41N/Cyi6ZiA+UujVxIZtWKpmz9IKTYtonpXW9pLIQynU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1573227962; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vA0Utf2fs6B99NoGQw7/SUlyor+u/7qxi7AeS8kwA4s=; b=O0L8vIoKXfkf5JONof41xchpbGD0WnUgfjZ/PU1ejXxSD02KcsXN3WgAJB50hEbkQIGjagzI4KgCkJs80ujgQA+O3RFmf5Jefw035809pNWW56lG5/oUclblZsptUUJTeN4BfjC65LSrZ0UGpDJvqu8QYpwTmatSylLOtrQmeZw= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1573227962505559.567324000542; Fri, 8 Nov 2019 07:46:02 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-t9p3N2MOM0WcaWjL2WH2_w-1; Fri, 08 Nov 2019 10:45:59 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9057E1005500; Fri, 8 Nov 2019 15:45:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 691675DA7F; Fri, 8 Nov 2019 15:45:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D554A18006D1; Fri, 8 Nov 2019 15:45:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xA8FgRdH014020 for ; Fri, 8 Nov 2019 10:42:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id B41D05D6BB; Fri, 8 Nov 2019 15:42:27 +0000 (UTC) Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com [10.40.200.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD4665D6AE for ; Fri, 8 Nov 2019 15:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573227961; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vA0Utf2fs6B99NoGQw7/SUlyor+u/7qxi7AeS8kwA4s=; b=fLT4BpdleX0UpV/PB5LtANClupXbhO8hvrHwgMzTK0u0mIyvAVtOA3O5S3ipfrqSa2zeSA dKxFgATPhWcRseZOxWFQj1WspujEeaUHNV6l+QnjFHjhmJQGJew9GxnisUC9aYSEu+om7B /sbAcL+5DUMaQ2jaq4XkoMDNvfSjmEc= From: Pavel Hrdina To: libvir-list@redhat.com Date: Fri, 8 Nov 2019 16:42:02 +0100 Message-Id: <7e56d3e50833f8c711a3554a88eaaa6fbbc613dd.1573227570.git.phrdina@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v4 01/20] build: mandate use of a build dir != src dir X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: t9p3N2MOM0WcaWjL2WH2_w-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Historically we've allowed builds in the main src dir, but meson does not support this. Explicitly force separate build dir in autotools to align with meson. We must re-enable dependency tracking which the RPM %configure macro turns off. Without this, the build dir doesn't get the source directory tree mirrored. Signed-off-by: Daniel P. Berrang=C3=A9 Signed-off-by: Pavel Hrdina Reviewed-by: Daniel P. Berrang=C3=A9 --- Notes: New in v2. =20 Changes in v4: - Fixed Travis rules and documentation .travis.yml | 3 ++- README-hacking | 11 ++++++++--- README.md | 11 +++++++---- bootstrap.conf | 6 ++++++ configure.ac | 6 ++++++ docs/compiling.html.in | 10 ++++++---- docs/windows.html.in | 3 ++- libvirt.spec.in | 10 +++++++++- 8 files changed, 46 insertions(+), 14 deletions(-) diff --git a/.travis.yml b/.travis.yml index 478909d3bb..8b70c1c937 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,7 +53,8 @@ matrix: script: # We can't run 'distcheck' or 'syntax-check' because they fail on # macOS, but doing 'install' and 'dist' gives us some useful cover= age - - ./autogen.sh --prefix=3D$(pwd)/install-root && make -j3 && make = -j3 install && make -j3 dist + - mkdir build && cd build + - ../autogen.sh --prefix=3D$(pwd)/install-root && make -j3 && make= -j3 install && make -j3 dist =20 git: submodules: true diff --git a/README-hacking b/README-hacking index ec04271c6a..7da940eb13 100644 --- a/README-hacking +++ b/README-hacking @@ -11,7 +11,7 @@ We've opted to keep only the highest-level sources in the= GIT repository. This eases our maintenance burden, (fewer merges etc.), but imposes more requirements on anyone wishing to build from the just-checked-out sources. Note the requirements to build the released archive are much less and -are just the requirements of the standard ./configure && make procedure. +are just the requirements of the standard configure && make procedure. Specific development tools and versions will be checked for and listed by the bootstrap script. =20 @@ -34,10 +34,14 @@ reduce download time and disk space requirements: =20 $ export GNULIB_SRCDIR=3D/path/to/gnulib =20 +We require to have the build directory different than the source directory: + + $ mkdir build && cd build + The next step is to get all required pieces from gnulib, -to run autoreconf, and to invoke ./configure: +to run autoreconf, and to invoke ../autogen.sh: =20 - $ ./autogen.sh + $ ../autogen.sh =20 And there you are! Just =20 @@ -47,6 +51,7 @@ And there you are! Just At this point, there should be no difference between your local copy, and the GIT master copy: =20 + $ cd .. $ git diff =20 should output no difference. diff --git a/README.md b/README.md index 4d1e86259d..44b0dd87c5 100644 --- a/README.md +++ b/README.md @@ -38,11 +38,13 @@ Installation ------------ =20 Libvirt uses the GNU Autotools build system, so in general can be built -and installed with the usual commands. For example, to build in a manner -that is suitable for installing as root, use: +and installed with the usual commands, however, we mandate to have the +build directory different than the source directory. For example, to build +in a manner that is suitable for installing as root, use: =20 ``` -$ ./configure --prefix=3D/usr --sysconfdir=3D/etc --localstatedir=3D/var +$ mkdir build && cd build +$ ../configure --prefix=3D/usr --sysconfdir=3D/etc --localstatedir=3D/var $ make $ sudo make install ``` @@ -50,7 +52,8 @@ $ sudo make install While to build & install as an unprivileged user =20 ``` -$ ./configure --prefix=3D$HOME/usr +$ mkdir build && cd build +$ ../configure --prefix=3D$HOME/usr $ make $ make install ``` diff --git a/bootstrap.conf b/bootstrap.conf index 0c7de2d2aa..4c784487e2 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -164,3 +164,9 @@ bootstrap_post_import_hook() sed 's,\.\./\.\./\.\.,../..,g; s/^TESTS /GNULIB_TESTS /' $m > $m-t mv -f $m-t $m } + +bootstrap_epilogue() +{ + echo "$0: done. Now you can run 'mkdir build && cd build && ../config= ure'." + exit 0 +} diff --git a/configure.ac b/configure.ac index 233fbeaaf3..32b246842e 100644 --- a/configure.ac +++ b/configure.ac @@ -17,6 +17,12 @@ dnl License along with this library. If not, see dnl . =20 AC_INIT([libvirt], [5.10.0], [libvir-list@redhat.com], [], [https://libvir= t.org]) + +if test $srcdir =3D "." +then + AC_MSG_ERROR([Build directory must be different from source directory]) +fi + AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/compiling.html.in b/docs/compiling.html.in index 8dcceb3eb9..5869ebb90f 100644 --- a/docs/compiling.html.in +++ b/docs/compiling.html.in @@ -9,13 +9,15 @@

Compiling a release tarball

=20

- libvirt uses the standard configure/make/install steps: + libvirt uses the standard configure/make/install steps and mandates + that the build directory is different that the source directory:

=20
 $ xz -c libvirt-x.x.x.tar.xz | tar xvf -
 $ cd libvirt-x.x.x
-$ ./configure
+$ mkdir build && cd build +$ ../configure =20

The configure script can be given options to change its defau= lt @@ -28,7 +30,7 @@ $ ./configure

=20
-$ ./configure --help
+$ ../configure --help =20

When you have determined which options you want to use (if any), @@ -49,7 +51,7 @@ $ ./configure --help

=20
-$ ./configure [possible options]
+$ ../configure [possible options]
 $ make
 $ sudo make install
=20 diff --git a/docs/windows.html.in b/docs/windows.html.in index 096d118bf7..a0ff525e1a 100644 --- a/docs/windows.html.in +++ b/docs/windows.html.in @@ -180,7 +180,8 @@

=20
-./configure \
+mkdir build && cd build
+../configure \
   --without-sasl \
   --without-polkit \
   --without-python \
diff --git a/libvirt.spec.in b/libvirt.spec.in
index dcad08cb5f..723ced3535 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1163,7 +1163,13 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{=
_specdir}/%{name}.spec)
 %endif
=20
 rm -f po/stamp-po
-%configure --with-runstatedir=3D%{_rundir} \
+
+%define _configure ../configure
+mkdir %{_vpath_builddir}
+cd %{_vpath_builddir}
+
+%configure --enable-dependency-tracking \
+           --with-runstatedir=3D%{_rundir} \
            %{?arg_qemu} \
            %{?arg_openvz} \
            %{?arg_lxc} \
@@ -1232,6 +1238,7 @@ rm -fr %{buildroot}
=20
 export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_specdir}/%{name}.spec)
=20
+cd %{_vpath_builddir}
 %make_install %{?_smp_mflags} SYSTEMD_UNIT_DIR=3D%{_unitdir} V=3D1
=20
 rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
@@ -1313,6 +1320,7 @@ mv $RPM_BUILD_ROOT%{_datadir}/systemtap/tapset/libvir=
t_qemu_probes.stp \
 %endif
=20
 %check
+cd %{_vpath_builddir}
 if ! make %{?_smp_mflags} check VIR_TEST_DEBUG=3D1
 then
   cat test-suite.log || true
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61
 as permitted sender) client-ip=205.139.110.61;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228028; cv=none;
	d=zoho.com; s=zohoarc;
	b=ORUQg5lj2VAFbpeZk74j7v5Jaz4qBNPbH0ejKpw729otA2HCaoykRr7M3BF2UtruSP3cnIPWypiJUkdPHvAeTc1+yWb2JRssTWnLuKej1Y8rqW2p2VMd+8abNg8ujAB/CltvvxfQ1vu5A4cIlQrgzqAYTRbTjF8YMkMLsu4DpEk=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228028;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=o27zERutcW2rGN4eIF1Dd9cZ67gujj+xog8jEaIjisI=;
	b=DCk5WI9aqIMpQ176VB+Ld+AuOAE6dn/rqmZ+oFKN5/5Dh4mf9aG4kSwo1Xou8pxyRK1DjvS30DKs34KJsOpx6zKI1JKG41Yh0sw3WD8h34NVefk48sriWX7LzRYzHmfrULIAekTZUCbCr/j+X3yc/nxVcTiAX1FWnv07UowkK6k=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
 [205.139.110.61]) by mx.zohomail.com
	with SMTPS id 1573228028966109.7348658499044;
 Fri, 8 Nov 2019 07:47:08 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-34-06pWHxZXOuKYo_xV64n45A-1; Fri, 08 Nov 2019 10:47:04 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EED02107ACC9;
	Fri,  8 Nov 2019 15:46:58 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id CAA0E5C1BB;
	Fri,  8 Nov 2019 15:46:58 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8C6DF4E566;
	Fri,  8 Nov 2019 15:46:58 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgSx5014025 for ;
	Fri, 8 Nov 2019 10:42:28 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id E741D5D70D; Fri,  8 Nov 2019 15:42:28 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 204775D6AE
	for ; Fri,  8 Nov 2019 15:42:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228027;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=o27zERutcW2rGN4eIF1Dd9cZ67gujj+xog8jEaIjisI=;
	b=TknAowhdwNOwWddSxCvvwuuzBVnGbBXYB+u1yN6xqY9+Z1p8yLJklxmDXUqr43D7rkk/TJ
	rxE0aAwmb+baw4Mx+Or3mX175XDxxcr+vDY4n3A5FsdzLUw0aDxBWNnuL0o2a6+Y20EVDq
	rsSHDFFjGmVGIATP/tl4bL/lN+MwxP0=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:03 +0100
Message-Id: 
 <49c4e5a0c965d9763fb215229c15c553ed360d07.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 02/20] [ACKED] .gitignore: cleanup old and
	obsolete ignores
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: 06pWHxZXOuKYo_xV64n45A-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Now that we forbid builds in source directory we can remove a lot of
ignores that are created during build time.  To make the cleanup easier
in the future create a sections in our .gitignore file.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    New in v2.

 .gitignore | 249 ++++++-----------------------------------------------
 1 file changed, 26 insertions(+), 223 deletions(-)

diff --git a/.gitignore b/.gitignore
index c45b8bd098..bd64eb5b1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,44 +1,17 @@
+# vim related ignores
+*.swp
+.lvimrc
+
+# emacs related ignores
 *#*#
 *.#*#
-*.[187]
-*.[187].in
-*.a
-*.cov
-*.exe
-*.exe.manifest
-*.gcda
-*.gcno
-*.gcov
-*.html
-*.i
-*.la
-*.lo
-*.loT
-*.o
-*.orig
-*.pem
-*.pyc
-*.rej
-*.s
-*.service
-*.socket
-*.swp
-*~
 .#*
-.color_coded
-.deps
-.dirstamp
-.gdb_history
-.git
-.git-module-status
-.libs
-.lvimrc
-.memdump
-.sc-start-sc_*
-.ycm_extra_conf.py
+
+# autotools related ignores
+!/m4/virt-*.m4
+*.cov
 /AUTHORS
 /INSTALL
-/NEWS
 /aclocal.m4
 /autom4te.cache
 /build-aux/.gitignore
@@ -46,70 +19,32 @@
 /build-aux/depcomp
 /build-aux/missing
 /build-aux/test-driver
-/build/
-/ci/scratch/
-/confdefs.h
-/config.cache
-/config.guess
-/config.h
 /config.h.in
 /config.log
-/config.rpath
-/config.status
-/config.sub
 /configure
-/configure.lineno
-/conftest.*
-/docs/aclperms.htmlinc
-/docs/apibuild.py.stamp
-/docs/devhelp/libvirt.devhelp
-/docs/hvsupport.html.in
-/docs/libvirt-admin-*.xml
-/docs/libvirt-api.xml
-/docs/libvirt-lxc-*.xml
-/docs/libvirt-qemu-*.xml
-/docs/libvirt-refs.xml
-/docs/news.html.in
-/docs/todo.html.in
-/examples/c/admin/client_close
-/examples/c/admin/client_info
-/examples/c/admin/client_limits
-/examples/c/admin/list_clients
-/examples/c/admin/list_servers
-/examples/c/admin/logging
-/examples/c/admin/threadpool_params
-/examples/c/domain/dommigrate
-/examples/c/domain/domtop
-/examples/c/domain/info1
-/examples/c/domain/rename
-/examples/c/domain/suspend
-/examples/c/misc/event-test
-/examples/c/misc/hellolibvirt
-/examples/c/misc/openauth
+/m4/*
+Makefile.in
+
+# gnulib related ignores
+!/gnulib/lib/Makefile.am
+!/gnulib/tests/Makefile.am
+*.rej
+*~
 /gnulib/lib/*
 /gnulib/m4/*
 /gnulib/tests/*
-/include/libvirt/libvirt-common.h
-/libtool
-/libvirt-*.tar.xz
-/libvirt-[0-9]*
-/libvirt*.pc
-/libvirt.spec
-/ltconfig
-/ltmain.sh
-/m4/*
-/mingw-libvirt.spec
-/mkinstalldirs
+
+# git related ignores
+*.orig
+.git-module-status
+
+# libvirt related ignores
+!/po/*.mini.po
+/build/
+/ci/scratch/
 /po/*gmo
 /po/*po
-!/po/*.mini.po
 /po/*pot
-/proxy/
-/python/
-/run
-/sc_*
-/src/.*.stamp
-/src/*.pc
 /src/access/org.libvirt.api.policy
 /src/access/viraccessapicheck.c
 /src/access/viraccessapicheck.h
@@ -120,151 +55,19 @@
 /src/admin/admin_client.h
 /src/admin/admin_protocol.[ch]
 /src/admin/admin_server_dispatch_stubs.h
-/src/admin/libvirt_admin.def
-/src/admin/libvirt_admin.syms
-/src/bhyve/test_libvirtd_bhyve.aug
-/src/bhyve/test_virtbhyved.aug
-/src/bhyve/virtbhyved.aug
-/src/bhyve/virtbhyved.conf
 /src/esx/*.generated.*
 /src/hyperv/*.generated.*
-/src/interface/test_virtinterfaced.aug
-/src/interface/virtinterfaced.aug
-/src/interface/virtinterfaced.conf
-/src/libvirt*.def
-/src/libvirt.syms
-/src/libvirt_access.syms
-/src/libvirt_access.xml
-/src/libvirt_access_lxc.syms
-/src/libvirt_access_lxc.xml
-/src/libvirt_access_qemu.syms
-/src/libvirt_access_qemu.xml
-/src/libvirt_*.stp
-/src/libvirt_*helper
-/src/libvirt_*probes.h
-/src/libvirt_lxc
-/src/libvirtd
-/src/libvirtd*.logrotate
-/src/libxl/test_libvirtd_libxl.aug
-/src/libxl/test_virtxend.aug
-/src/libxl/virtxend.aug
-/src/libxl/virtxend.conf
-/src/locking/libxl-lockd.conf
-/src/locking/libxl-sanlock.conf
 /src/locking/lock_daemon_dispatch_stubs.h
 /src/locking/lock_protocol.[ch]
-/src/locking/qemu-lockd.conf
-/src/locking/qemu-sanlock.conf
-/src/locking/test_libvirt_sanlock.aug
-/src/locking/test_libvirt_lockd.aug
-/src/locking/test_virtlockd.aug
 /src/logging/log_daemon_dispatch_stubs.h
 /src/logging/log_protocol.[ch]
-/src/logging/test_virtlogd.aug
 /src/lxc/lxc_controller_dispatch.h
 /src/lxc/lxc_monitor_dispatch.h
 /src/lxc/lxc_monitor_protocol.c
 /src/lxc/lxc_monitor_protocol.h
-/src/lxc/lxc_protocol.[ch]
-/src/lxc/test_libvirtd_lxc.aug
-/src/lxc/test_virtlxcd.aug
-/src/lxc/virtlxcd.aug
-/src/lxc/virtlxcd.conf
-/src/network/test_virtnetworkd.aug
-/src/network/virtnetworkd.aug
-/src/network/virtnetworkd.conf
-/src/node_device/test_virtnodedevd.aug
-/src/node_device/virtnodedevd.aug
-/src/node_device/virtnodedevd.conf
-/src/nwfilter/test_virtnwfilterd.aug
-/src/nwfilter/virtnwfilterd.aug
-/src/nwfilter/virtnwfilterd.conf
-/src/qemu/test_libvirtd_qemu.aug
-/src/qemu/test_virtqemud.aug
-/src/qemu/virtqemud.aug
-/src/qemu/virtqemud.conf
 /src/remote/*_client_bodies.h
 /src/remote/*_protocol.[ch]
 /src/remote/*_stubs.h
-/src/remote/libvirtd.aug
-/src/remote/libvirtd.conf
-/src/remote/test_libvirtd.aug
-/src/remote/test_virtproxyd.aug
-/src/remote/virtproxyd.aug
-/src/remote/virtproxyd.conf
 /src/rpc/virkeepaliveprotocol.[ch]
 /src/rpc/virnetprotocol.[ch]
-/src/secret/test_virtsecretd.aug
-/src/secret/virtsecretd.aug
-/src/secret/virtsecretd.conf
-/src/storage/test_virtstoraged.aug
-/src/storage/virtstoraged.aug
-/src/storage/virtstoraged.conf
-/src/test*.aug
-/src/util/virkeycodetable*.h
-/src/util/virkeynametable*.h
-/src/vbox/test_virtvboxd.aug
-/src/vbox/virtvboxd.aug
-/src/vbox/virtvboxd.conf
-/src/virt-aa-helper
-/src/virtbhyved
-/src/virtinterfaced
-/src/virtxend
-/src/virtlockd
-/src/virtlogd
-/src/virtlxcd
-/src/virtnetworkd
-/src/virtnodedevd
-/src/virtnwfilterd
-/src/virtproxyd
-/src/virtqemud
-/src/virtsecretd
-/src/virtstoraged
-/src/virtvboxd
-/src/virtvzd
-/src/virt-guest-shutdown.target
-/src/vz/test_virtvzd.aug
-/src/vz/virtvzd.aug
-/src/vz/virtvzd.conf
-/tests/*.log
-/tests/*.pid
-/tests/*.trs
-/tests/*test
-/tests/commandhelper
-/tests/qemucapsprobe
-!/tests/virsh-self-test
-!/tests/virt-aa-helper-test
-!/tests/virt-admin-self-test
-/tests/reconnect
-/tests/ssh
-/tests/test_file_access.txt
-/tests/test_conf
-/tools/libvirt-guests.sh
-/tools/virt-login-shell
-/tools/virt-login-shell-helper
-/tools/virsh
-/tools/virsh-*-edit.c
-/tools/virt-admin
-/tools/virt-*-validate
-/tools/virt-sanlock-cleanup
-/tools/wireshark/src/libvirt
-/update.log
-GPATH
-GRTAGS
-GTAGS
-Makefile
-Makefile.in
-TAGS
-coverage
-cscope.files
-cscope.in.out
-cscope.out
-cscope.po.out
-results.log
-stamp-h
-stamp-h.in
-stamp-h1
 tags
-!/gnulib/lib/Makefile.am
-!/gnulib/tests/Makefile.am
-!/m4/virt-*.m4
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.61
 as permitted sender) client-ip=205.139.110.61;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228031; cv=none;
	d=zoho.com; s=zohoarc;
	b=OGQUBLW5u5TrUOoc70AbmhRDkOPHx8jlazt8We26NDZjz6J2NZk1vg4KZzbSOYywSpRc+yi4vT2aBIJTRKj+p+7aAuSCubH5Z/6VYD9abfVMGpROzKwgtZQgTdJi/9OvjdQVfJTePBTbkLbAsITQUuUi1K2vIeUMnDXOGTpZKA8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228031;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=wqpcTA4fzPZwp3F+BWeTRi08BJ9Cl5bw5Sx7eINKtgE=;
	b=hKQweQhyeRaNos6NRXKUlFDx3H+1+lKL13+5ErdyUKGyA0QjMf/iI75mnWE+uSeJd/uZg1uNP0uBcZJiYBSk8unLu4iJdfDFqGjHS6G1yOxIYu1sUX4fa/zcSNxPcJOd7l+VxAcX378E5lxf9JECP+bFLbuR96qCmFT3vfVK44Y=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.61 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
 [205.139.110.61]) by mx.zohomail.com
	with SMTPS id 1573228031008544.025351630312;
 Fri, 8 Nov 2019 07:47:11 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-150-33J98dBhP56tdSQKQz_5Ww-1; Fri, 08 Nov 2019 10:47:07 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 601ED1005511;
	Fri,  8 Nov 2019 15:47:02 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D90E5C299;
	Fri,  8 Nov 2019 15:47:02 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id EEAE14E56C;
	Fri,  8 Nov 2019 15:47:01 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgTjj014035 for ;
	Fri, 8 Nov 2019 10:42:29 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id E805B5D6B7; Fri,  8 Nov 2019 15:42:29 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 545805D6AE
	for ; Fri,  8 Nov 2019 15:42:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228029;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=wqpcTA4fzPZwp3F+BWeTRi08BJ9Cl5bw5Sx7eINKtgE=;
	b=ibVx0eVp/gIh1PkeTTVbgtXbdXzdYqU18uQc6ztSIHNDUv0iq2gtSfn8109e2RYt8TwT/4
	qhOPOCf++qledtIsDQPBec3BsGsFCUTn2Q0xQwGqpL+8irSOZPmmEhL3SJQMkfctlUccTO
	6rUqjgwjnXCWTDkTDRcpYteul16KcEw=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:04 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 03/20] [ACKED] syntax-check.mk: fix sc_po_check
	rule
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: 33J98dBhP56tdSQKQz_5Ww-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Commit <22d8e27ccd5faf48ee2bf288a1b9059aa7ffd28b> introduced our
syntax-check.mk file based on gnulib rules. However, the rule was
completely ignored as we don't have POTFILES.in file.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    New in v2.

 build-aux/syntax-check.mk |  2 +-
 po/POTFILES               | 38 +++++++++++++++++++++++++++++++++++---
 2 files changed, 36 insertions(+), 4 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 033eaf70c4..5890f4737f 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1974,7 +1974,7 @@ perl_translatable_files_list_ =3D						\
=20
 # Verify that all source files using _() (more specifically, files that
 # match $(_gl_translatable_string_re)) are listed in po/POTFILES.in.
-po_file ?=3D $(srcdir)/po/POTFILES.in
+po_file ?=3D $(srcdir)/po/POTFILES
 generated_files ?=3D $(srcdir)/lib/*.[ch]
 _gl_translatable_string_re ?=3D \b(N?_|gettext *)\([^)"]*("|$$)
 sc_po_check:
diff --git a/po/POTFILES b/po/POTFILES
index 04eba73725..217d7e2006 100644
--- a/po/POTFILES
+++ b/po/POTFILES
@@ -29,6 +29,7 @@ src/conf/netdev_vport_profile_conf.c
 src/conf/network_conf.c
 src/conf/networkcommon_conf.c
 src/conf/node_device_conf.c
+src/conf/node_device_util.c
 src/conf/numa_conf.c
 src/conf/nwfilter_conf.c
 src/conf/nwfilter_params.c
@@ -38,9 +39,14 @@ src/conf/snapshot_conf.c
 src/conf/storage_adapter_conf.c
 src/conf/storage_conf.c
 src/conf/virchrdev.c
+src/conf/virdomainmomentobjlist.c
 src/conf/virdomainobjlist.c
 src/conf/virnetworkobj.c
+src/conf/virnetworkportdef.c
 src/conf/virnodedeviceobj.c
+src/conf/virnwfilterbindingdef.c
+src/conf/virnwfilterbindingobj.c
+src/conf/virnwfilterbindingobjlist.c
 src/conf/virnwfilterobj.c
 src/conf/virsavecookie.c
 src/conf/virsecretobj.c
@@ -60,6 +66,7 @@ src/esx/esx_storage_backend_vmfs.c
 src/esx/esx_storage_driver.c
 src/esx/esx_stream.c
 src/esx/esx_util.c
+src/esx/esx_util.h
 src/esx/esx_vi.c
 src/esx/esx_vi_methods.c
 src/esx/esx_vi_types.c
@@ -128,16 +135,22 @@ src/phyp/phyp_driver.c
 src/qemu/qemu_agent.c
 src/qemu/qemu_alias.c
 src/qemu/qemu_block.c
+src/qemu/qemu_blockjob.c
 src/qemu/qemu_capabilities.c
 src/qemu/qemu_cgroup.c
+src/qemu/qemu_checkpoint.c
 src/qemu/qemu_command.c
 src/qemu/qemu_conf.c
+src/qemu/qemu_dbus.c
 src/qemu/qemu_domain.c
 src/qemu/qemu_domain_address.c
 src/qemu/qemu_driver.c
+src/qemu/qemu_extdevice.c
+src/qemu/qemu_firmware.c
 src/qemu/qemu_hostdev.c
 src/qemu/qemu_hotplug.c
 src/qemu/qemu_interface.c
+src/qemu/qemu_interop_config.c
 src/qemu/qemu_migration.c
 src/qemu/qemu_migration_cookie.c
 src/qemu/qemu_migration_params.c
@@ -146,12 +159,15 @@ src/qemu/qemu_monitor_json.c
 src/qemu/qemu_monitor_text.c
 src/qemu/qemu_process.c
 src/qemu/qemu_qapi.c
+src/qemu/qemu_slirp.c
+src/qemu/qemu_tpm.c
+src/qemu/qemu_vhost_user.c
+src/qemu/qemu_vhost_user_gpu.c
 src/remote/remote_client_bodies.h
 src/remote/remote_daemon.c
 src/remote/remote_daemon_config.c
 src/remote/remote_daemon_dispatch.c
 src/remote/remote_daemon_dispatch_stubs.h
-src/remote/remote_daemon_dispatch_qemu_stubs.h
 src/remote/remote_daemon_stream.c
 src/remote/remote_driver.c
 src/rpc/virkeepalive.c
@@ -170,11 +186,13 @@ src/rpc/virnetsocket.c
 src/rpc/virnetsshsession.c
 src/rpc/virnettlscontext.c
 src/secret/secret_driver.c
+src/secret/secret_util.c
 src/security/security_apparmor.c
 src/security/security_dac.c
 src/security/security_driver.c
 src/security/security_manager.c
 src/security/security_selinux.c
+src/security/security_util.c
 src/security/virt-aa-helper.c
 src/storage/parthelper.c
 src/storage/storage_backend.c
@@ -182,6 +200,7 @@ src/storage/storage_backend_disk.c
 src/storage/storage_backend_fs.c
 src/storage/storage_backend_gluster.c
 src/storage/storage_backend_iscsi.c
+src/storage/storage_backend_iscsi_direct.c
 src/storage/storage_backend_logical.c
 src/storage/storage_backend_mpath.c
 src/storage/storage_backend_rbd.c
@@ -190,6 +209,8 @@ src/storage/storage_backend_sheepdog.c
 src/storage/storage_backend_vstorage.c
 src/storage/storage_backend_zfs.c
 src/storage/storage_driver.c
+src/storage/storage_file_fs.c
+src/storage/storage_file_gluster.c
 src/storage/storage_util.c
 src/test/test_driver.c
 src/util/iohelper.c
@@ -199,8 +220,11 @@ src/util/viraudit.c
 src/util/virauth.c
 src/util/virauthconfig.c
 src/util/virbitmap.c
-src/util/virbuffer.c
 src/util/vircgroup.c
+src/util/vircgroupbackend.c
+src/util/vircgroupbackend.h
+src/util/vircgroupv1.c
+src/util/vircgroupv2.c
 src/util/virclosecallbacks.c
 src/util/vircommand.c
 src/util/virconf.c
@@ -215,6 +239,7 @@ src/util/virfdstream.c
 src/util/virfile.c
 src/util/virfilecache.c
 src/util/virfirewall.c
+src/util/virfirewalld.c
 src/util/virfirmware.c
 src/util/virhash.c
 src/util/virhook.c
@@ -232,6 +257,7 @@ src/util/virlockspace.c
 src/util/virlog.c
 src/util/virmacmap.c
 src/util/virmdev.c
+src/util/virmodule.c
 src/util/virnetdev.c
 src/util/virnetdevbandwidth.c
 src/util/virnetdevbridge.c
@@ -266,15 +292,18 @@ src/util/virstoragefile.c
 src/util/virstoragefilebackend.c
 src/util/virstring.c
 src/util/virsysinfo.c
+src/util/virsystemd.c
 src/util/virthreadjob.c
 src/util/virthreadpool.c
 src/util/virtime.c
 src/util/virtpm.c
+src/util/virtypedparam-public.c
 src/util/virtypedparam.c
 src/util/viruri.c
 src/util/virusb.c
 src/util/virutil.c
 src/util/virvhba.c
+src/util/virvsock.c
 src/util/virxml.c
 src/vbox/vbox_MSCOMGlue.c
 src/vbox/vbox_XPCOMCGlue.c
@@ -294,6 +323,7 @@ src/vz/vz_utils.h
 tests/virpolkittest.c
 tools/libvirt-guests.sh.in
 tools/virsh-checkpoint.c
+tools/virsh-completer-host.c
 tools/virsh-console.c
 tools/virsh-domain-monitor.c
 tools/virsh-domain.c
@@ -309,12 +339,14 @@ tools/virsh-snapshot.c
 tools/virsh-util.c
 tools/virsh-volume.c
 tools/virsh.c
+tools/virsh.h
 tools/virt-admin.c
 tools/virt-host-validate-bhyve.c
 tools/virt-host-validate-common.c
 tools/virt-host-validate-lxc.c
 tools/virt-host-validate-qemu.c
 tools/virt-host-validate.c
-tools/virt-login-shell.c
+tools/virt-login-shell-helper.c
+tools/vsh-table.c
 tools/vsh.c
 tools/vsh.h
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228035; cv=none;
	d=zoho.com; s=zohoarc;
	b=S69Kv6Ab2ggs+3wDpRgLunkd+RRF0A9bApvqj7OXocdIq572h1Isoxbys4vqh1Q1d0iWJcs+AOfZv7DN3rrlfCx53ZMhXYYiLuwpD1akiugD+XO2ORKYo8kTXu3c97lxW3X+rpxNyp8vVBQt5lR2txh/dJu/bDMDhVUlFjxzd40=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228035;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=Ed5hBNmOBTRowV5HS6RpY9a8fk7zbfKd5lKpCqDvSuI=;
	b=TwaaEcMDyHcwrhyC3UBfXyktnEM+KrBXajJjj4yzuxGUf/weQtBgCazSxCd9S/ojpzU8xsPo0DWwiRcsc/04wRxaLfH5Z28nDf60maA6LZYFg3eVJ3yZ/Qx3ii/ofotZ0r6kKn6e9COHi23DCLR+iWvPAjwV39i8AG0Y0Ks+vx8=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573228035123698.5162353789918;
 Fri, 8 Nov 2019 07:47:15 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-391-9skdYE61P1qlBQtph8VDUw-1; Fri, 08 Nov 2019 10:47:11 -0500
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C33E107ACC9;
	Fri,  8 Nov 2019 15:47:06 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 518775D6BB;
	Fri,  8 Nov 2019 15:47:06 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 09FFF18005C5;
	Fri,  8 Nov 2019 15:47:06 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgV2t014045 for ;
	Fri, 8 Nov 2019 10:42:31 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 2D0AE5D6B7; Fri,  8 Nov 2019 15:42:31 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 5D6205D6AE
	for ; Fri,  8 Nov 2019 15:42:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228034;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=Ed5hBNmOBTRowV5HS6RpY9a8fk7zbfKd5lKpCqDvSuI=;
	b=Ntown4yNTXt+ouGJrENTfH4wPWgeuSxjCUXNZZIAUAzuMfZNZllgbqiG2Ya/4C7cVYUNWA
	XHQQHCFTdZwGap9nLYG9yznfBb33i8zGBLwCa0fX/w8F0EcNp/GWvM0TiNCDqp9KsW4o7O
	dPhvZLV6jgRRpaavgfarJWN54ZT2wO4=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:05 +0100
Message-Id: 
 <0dd0516b5674f517a86b66b2ff596de0aaa43907.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 04/20] [ACKED] syntax-check.mk: cleanup
	sc_po_check dependencies
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-MC-Unique: 9skdYE61P1qlBQtph8VDUw-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Introduce new rule 'generated-sources' as a helper for PO files check
to make sure that all generated files are prepared and to not duplicate
the list on different places.  This will be used as a dependency for
sc_po_check rule instead of duplicated list of generated files.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    New in v2.

 build-aux/syntax-check.mk | 25 ++++++-------------------
 src/Makefile.am           |  3 +++
 2 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 5890f4737f..6acda4eea3 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1953,6 +1953,9 @@ sc_m4_quote_check:
 	halt=3D'quote the first arg to AC_DEF*'				\
 	  $(_sc_search_regexp)
=20
+gen_source_files:
+	$(MAKE) -C src generated-sources
+
 fix_po_file_diag =3D \
 'you have changed the set of files with translatable diagnostics;\n\
 apply the above patch\n'
@@ -1977,7 +1980,9 @@ perl_translatable_files_list_ =3D						\
 po_file ?=3D $(srcdir)/po/POTFILES
 generated_files ?=3D $(srcdir)/lib/*.[ch]
 _gl_translatable_string_re ?=3D \b(N?_|gettext *)\([^)"]*("|$$)
-sc_po_check:
+
+# sc_po_check can fail if generated files are not built first
+sc_po_check: gen_source_files
 	@if test -f $(po_file); then					\
 	  $(GREP) -E -v '^(#|$$)' $(po_file)				\
 	    | $(GREP) -v '^src/false\.c$$' | sort > $@-1;		\
@@ -2160,24 +2165,6 @@ test-wrap-argv:
 group-qemu-caps:
 	$(AM_V_GEN)$(PERL) $(top_srcdir)/tests/group-qemu-caps.pl --check $(top_s=
rcdir)/
=20
-# sc_po_check can fail if generated files are not built first
-sc_po_check: \
-		$(srcdir)/src/remote/remote_daemon_dispatch_stubs.h \
-		$(srcdir)/src/remote/remote_daemon_dispatch_qemu_stubs.h \
-		$(srcdir)/src/remote/remote_client_bodies.h \
-		$(srcdir)/src/admin/admin_server_dispatch_stubs.h \
-		$(srcdir)/src/admin/admin_client.h
-$(srcdir)/src/remote/remote_daemon_dispatch_stubs.h: $(srcdir)/src/remote/=
remote_protocol.x
-	$(MAKE) -C src remote/remote_daemon_dispatch_stubs.h
-$(srcdir)/src/remote/remote_daemon_dispatch_qemu_stubs.h: $(srcdir)/src/re=
mote/qemu_protocol.x
-	$(MAKE) -C src remote/remote_daemon_dispatch_qemu_stubs.h
-$(srcdir)/src/remote/remote_client_bodies.h: $(srcdir)/src/remote/remote_p=
rotocol.x
-	$(MAKE) -C src remote/remote_client_bodies.h
-$(srcdir)/src/admin/admin_server_dispatch_stubs.h: $(srcdir)/src/admin/adm=
in_protocol.x
-	$(MAKE) -C src admin/admin_server_dispatch_stubs.h
-$(srcdir)/src/admin/admin_client.h: $(srcdir)/src/admin/admin_protocol.x
-	$(MAKE) -C src admin/admin_client.h
-
 # List all syntax-check exemptions:
 exclude_file_name_regexp--sc_avoid_strcase =3D ^tools/vsh\.h$$
=20
diff --git a/src/Makefile.am b/src/Makefile.am
index ebc24610e2..e0b917fcdd 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -717,6 +717,9 @@ libvirt_iohelper_CFLAGS =3D \
 endif WITH_LIBVIRTD
=20
=20
+generated-sources: $(BUILT_SOURCES)
+
+
 install-data-local: $(INSTALL_DATA_LOCAL) \
 		$(INSTALL_DATA_DIRS:%=3Dinstall-data-%)
 	$(MKDIR_P) "$(DESTDIR)$(localstatedir)/cache/libvirt"
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228038; cv=none;
	d=zoho.com; s=zohoarc;
	b=MToNukZdZmA8SNoCmBSeurjSMlVkf6OJnkGmfKWIkJpQ6zKFCfhlV+qQYru9MMql6g1nwM5H4h+wPatME0b1sFTVsendZZ/NPRMM7RxFtnqOuvmgxUQmtKs/4BcrND5zZChEqlzQSozsa/nar3tHxPPu00PiVN46qh6H2admNmQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228038;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=eqlqX/c2MIJyuHPRH/u0p09S9B5+BVQ0Bu1ikr5uKJ8=;
	b=ccz00gbuGKywQTe4UjRhgMf7mjMbVAw7HuJgYdMlb5IHWCka8TdfHmXOSdy83vFRXu/IMx1PLgA+Tfg2kk2vl4fhVjuyT5hVVsri+mrWUXnAN1Wpzqojo0vEW+NN7jDiI0hePETDq0wuLeFX64pOyaFBwPFcHVw5KkpZrkIrnoI=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 1573228038589689.8057964333367;
 Fri, 8 Nov 2019 07:47:18 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-374-r-ctKZWKNImGkc1Xaea5vA-1; Fri, 08 Nov 2019 10:47:16 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D32BB801E68;
	Fri,  8 Nov 2019 15:47:09 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A4D8960C18;
	Fri,  8 Nov 2019 15:47:09 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 680E14E56E;
	Fri,  8 Nov 2019 15:47:09 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgWiY014057 for ;
	Fri, 8 Nov 2019 10:42:32 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 644DE5D6BB; Fri,  8 Nov 2019 15:42:32 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id C7E215D6AE
	for ; Fri,  8 Nov 2019 15:42:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228037;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=eqlqX/c2MIJyuHPRH/u0p09S9B5+BVQ0Bu1ikr5uKJ8=;
	b=YaUfnHDqu2ntWtjZ+CAOAGdVHrQ15w8+12crY3IWF6kNMjTUJHPSjmVqFJe2wI+zpYD6r+
	4H/zKYpaW8uRqhNp9wt4SLUJmC1JSuymftxcJmCAdUqPSv5bkINEhjt6JtdF/sIHPe3+oP
	ow1ROv9/PM2KZY5lU33cNZwqdN4y0ww=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:06 +0100
Message-Id: 
 <866689858edae399667d52f48b10065dd9c23a22.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 05/20] [ACKED] syntax-check.mk: cleanup
	generated_files list for sc_po_check
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-MC-Unique: r-ctKZWKNImGkc1Xaea5vA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Move generated_files variable closer to the sc_po_check rule and
remove non-existent gnulib internal path.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    New in v2.

 build-aux/syntax-check.mk | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 6acda4eea3..985739b373 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -134,15 +134,6 @@ syntax-check: $(local-check)
 # We use .gnulib, not gnulib.
 gnulib_dir =3D $(srcdir)/.gnulib
=20
-# List of additional files that we want to pick up in our POTFILES.in
-# This is all gnulib files, as well as generated files for RPC code.
-generated_files =3D \
-  $(srcdir)/src/*/{remote_daemon,admin_server,log_daemon,lock_daemon}_disp=
atch_*stubs.h \
-  $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
-  $(srcdir)/src/remote/*_client_bodies.h \
-  $(srcdir)/src/*/*_protocol.[ch] \
-  $(srcdir)/gnulib/lib/*.[ch]
-
 # We haven't converted all scripts to using gnulib's init.sh yet.
 _test_script_regex =3D \<\(init\|test-lib\)\.sh\>
=20
@@ -1978,7 +1969,16 @@ perl_translatable_files_list_ =3D						\
 # Verify that all source files using _() (more specifically, files that
 # match $(_gl_translatable_string_re)) are listed in po/POTFILES.in.
 po_file ?=3D $(srcdir)/po/POTFILES
-generated_files ?=3D $(srcdir)/lib/*.[ch]
+
+# List of additional files that we want to pick up in our POTFILES.in
+# This is all gnulib files, as well as generated files for RPC code.
+generated_files =3D \
+  $(srcdir)/src/*/{remote_daemon,admin_server,log_daemon,lock_daemon}_disp=
atch_*stubs.h \
+  $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
+  $(srcdir)/src/remote/*_client_bodies.h \
+  $(srcdir)/src/*/*_protocol.[ch] \
+  $(srcdir)/gnulib/lib/*.[ch]
+
 _gl_translatable_string_re ?=3D \b(N?_|gettext *)\([^)"]*("|$$)
=20
 # sc_po_check can fail if generated files are not built first
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228085; cv=none;
	d=zoho.com; s=zohoarc;
	b=oGVl0Ck3ekU3KgPz7mqgsf6xbc/YAFKGTLR0QNZstrzEbWDgStmL1GyoJuXTVtL6MN99fxkGeXHkGGzQ8B40wi1bG1ZteXC0dyBy2Vky5TYvUv/A7nHHfYesCvrBvGmiiK9EsBkhCJsVKKFUYD1Tw5MFZEW/lX4dAcuMAJGFkD4=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228085;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=hP5yrFxtbA6keSZ4nECF1hEe396eS1icRTlr2TSL8KE=;
	b=ncTqnKLrdy4GuxVO6JtQN7h+SF+HVSKYpO6Fl0aDccRnqUDWygp2Y6OhWKtmGl1T1PfK6FUjGeV1gtC+UrWU0x2UXVKbG9oVLQ1Ljf9xbC1p/nlGAhpd7Tb3IgrzVN4liQar7nXhWM5NxHGxEU4hwwADZDshKcBxQUdI7xIgCIs=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573228085117225.60194307509244;
 Fri, 8 Nov 2019 07:48:05 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-430-7gg4cfnlOc2QzI4vIwQOVw-1; Fri, 08 Nov 2019 10:47:18 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EB62107ACC7;
	Fri,  8 Nov 2019 15:47:13 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 571C0608B3;
	Fri,  8 Nov 2019 15:47:13 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E8FE18184BC;
	Fri,  8 Nov 2019 15:47:13 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgXjL014066 for ;
	Fri, 8 Nov 2019 10:42:33 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 62F4A5D6B7; Fri,  8 Nov 2019 15:42:33 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id C60F35D6AE
	for ; Fri,  8 Nov 2019 15:42:32 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228084;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=hP5yrFxtbA6keSZ4nECF1hEe396eS1icRTlr2TSL8KE=;
	b=RLTS8GuAiEBMvkkGuoL39GMFXkET16oaz5SJi2PUDpGhtJHTwd3qsiOTtVi+EnB09/nGIr
	5EB8MwU8zTIncWi6PtAc6pr301Gsx3i07DSAfegaz39+LlppjoHShQzta5eMQDuRdtUKcD
	xZ+wtpfPamun7epHr0EGV4UIVH0kP9g=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:07 +0100
Message-Id: 
 <5f112bc5eae304d85d3949defdeb928dfddc9162.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 06/20] po: generate files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: 7gg4cfnlOc2QzI4vIwQOVw-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Historically we did not support VPATH builds and everything was
generated into source directory.  The introduction of VPATH builds
did not changed the way how our translation files are handled.

This patch changes the rules to generate everything into build
directory and stops distributing generated files in order to have
properly separated VPATH builds.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - keep the zanata binary name, this will be fixed by separate patch
   =20
    Chnages in v3:
        - update --transdir and --srcdir options as they are used by
          python-zanata-client
   =20
    Changes in v4:
        - reverted the HAVE_GNU_GETTEXT_TOOLS move

 .gitignore     |  4 ----
 po/Makefile.am | 31 +++++++++++++++++++------------
 2 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/.gitignore b/.gitignore
index bd64eb5b1a..4c4807019c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -39,12 +39,8 @@ Makefile.in
 .git-module-status
=20
 # libvirt related ignores
-!/po/*.mini.po
 /build/
 /ci/scratch/
-/po/*gmo
-/po/*po
-/po/*pot
 /src/access/org.libvirt.api.policy
 /src/access/viraccessapicheck.c
 /src/access/viraccessapicheck.h
diff --git a/po/Makefile.am b/po/Makefile.am
index b0e2c15d44..89e831f839 100644
--- a/po/Makefile.am
+++ b/po/Makefile.am
@@ -16,17 +16,16 @@ LANGS :=3D \
=20
=20
 POTFILE_DEPS :=3D $(shell $(SED) 's,^,$(top_srcdir)/,' $(srcdir)/POTFILES)
-POTFILE :=3D $(srcdir)/$(DOMAIN).pot
-POFILES :=3D $(LANGS:%=3D$(srcdir)/%.po)
-GMOFILES :=3D $(LANGS:%=3D$(srcdir)/%.gmo)
+POTFILE :=3D $(DOMAIN).pot
+POMINIFILES :=3D $(LANGS:%=3D%.mini.po)
+POFILES :=3D $(LANGS:%=3D%.po)
+GMOFILES :=3D $(LANGS:%=3D%.gmo)
=20
-MAINTAINERCLEANFILES =3D $(POTFILE) $(POFILES) $(GMOFILES)
+CLEANFILES =3D $(POTFILE) $(POFILES) $(GMOFILES)
=20
 EXTRA_DIST =3D \
 	POTFILES \
-	$(POTFILE) \
-	$(POFILES) \
-	$(GMOFILES)
+	$(POMINIFILES)
=20
 if HAVE_GNU_GETTEXT_TOOLS
=20
@@ -63,10 +62,18 @@ update-mini-po: $(POTFILE)
 	done
=20
 push-pot: $(POTFILE)
-	zanata push --push-type=3Dsource
+	zanata push \
+		--project-config $(srcdir)/zanata.xml \
+		--push-type=3Dsource \
+		--transdir $(builddir) \
+		--srcdir $(srcdir)
=20
 pull-po: $(POTFILE)
-	zanata pull --create-skeletons
+	zanata pull \
+		--project-config $(srcdir)/zanata.xml \
+		--create-skeletons \
+		--transdir $(builddir) \
+		--srcdir $(srcdir)
 	$(MAKE) update-mini-po
 	$(MAKE) update-gmo
=20
@@ -76,11 +83,11 @@ $(POTFILE): POTFILES $(POTFILE_DEPS)
 	$(SED) $(SED_PO_FIXUP_ARGS) < $@-t > $@
 	rm -f $@-t
=20
-$(srcdir)/%.po: $(srcdir)/%.mini.po $(POTFILE)
+%.po: %.mini.po $(POTFILE)
 	$(MSGMERGE) --no-fuzzy-matching $< $(POTFILE) | \
 	  $(SED) $(SED_PO_FIXUP_ARGS) > $@
=20
-$(srcdir)/%.gmo: $(srcdir)/%.po
+%.gmo: %.po
 	rm -f $@ $@-t
 	$(MSGFMT) -c -o $@-t $<
 	mv $@-t $@
@@ -99,7 +106,7 @@ install-data-hook: $(GMOFILES)
 	for lang in $(LANGS); do \
 	  d=3D$(DESTDIR)$(langinstdir)/$$lang/LC_MESSAGES; \
 	  mkdir -p $$d; \
-	  install -m 0644 $(srcdir)/$$lang.gmo $$d/$(DOMAIN).mo; \
+	  install -m 0644 $$lang.gmo $$d/$(DOMAIN).mo; \
 	done
=20
 uninstall-hook:
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228096; cv=none;
	d=zoho.com; s=zohoarc;
	b=JVqyfEWvJNI+OSUmEoRy8Axlxp/v+xaKwdXgIbFz7NRm8z6luYb7xIjcapR1HZltR5D/6F4hcm1Ixl5wdfIZWssLOiNEIXB9tCc762pwuhEjeEh6kPbT6AWEexCvKh+orzcKKC48U79bEeDMMhya9NC+cXo03/nDs5rc/ayw48M=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228096;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=MsXKu+KAAZ4Lew+SUNl6s8UzjLZMyIfpuq58g8mA010=;
	b=LcEPtLqwQ7puF4dvMKIwKV1SaovvcK9OcUCcqvKjn3gWsH3WdtjUHutUs4PpaI2swnkWVRUrHONef9KpQ4wO/8xbCkrjIC0cgxh0g6REKcO/00267rFdxhUldlNKZb+wI7J0iAQxsPnbVWql+MHS3h7RzU1Baorjw+zeNviBtKA=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573228096210467.0293140260901;
 Fri, 8 Nov 2019 07:48:16 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-272-CDSCafqAPdGqTNEw-cU9Dg-1; Fri, 08 Nov 2019 10:47:22 -0500
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F3E61804976;
	Fri,  8 Nov 2019 15:47:17 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 0903C1001DC0;
	Fri,  8 Nov 2019 15:47:17 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id B746A4E56F;
	Fri,  8 Nov 2019 15:47:16 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgYRp014078 for ;
	Fri, 8 Nov 2019 10:42:34 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 951DD5D6B7; Fri,  8 Nov 2019 15:42:34 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id C0CA55D6AE
	for ; Fri,  8 Nov 2019 15:42:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228095;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=MsXKu+KAAZ4Lew+SUNl6s8UzjLZMyIfpuq58g8mA010=;
	b=BV0nt+eGP9nSspDM4VWX2Eqed8xeXq+VNar5IQfnzwXkNhjhtfc4oZorTKfUfoDqGAWidP
	t6TyE1pOW3k89eWowTsnHtBm0QDlwg6cPFav1i8Dig21gzdhncqSamHD/XgeIK/g+Sqa4B
	W9iWeaNnE61jz88Xhoqc1kMW15dCEQY=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:08 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 07/20] [ACKED] po: rewrite the way how we
	generate files
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-MC-Unique: CDSCafqAPdGqTNEw-cU9Dg-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

There was no need to handle files for translation from build directory
but that will change with following patches where we will stop
generating source files into source directory.

In order to have them included for translation we have to prefix each
file with SRCDIR or BUILDDIR.

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - add builddir paths for sc_po_check to detect generated source
          files and generate correct diff if the check fails

 build-aux/syntax-check.mk |   8 +-
 po/Makefile.am            |  14 +-
 po/POTFILES               | 352 --------------------------------------
 po/POTFILES.in            | 352 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 367 insertions(+), 359 deletions(-)
 delete mode 100644 po/POTFILES
 create mode 100644 po/POTFILES.in

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 985739b373..75993ee284 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -56,6 +56,7 @@ VC_LIST_ALWAYS_EXCLUDE_REGEX ?=3D ^$$
 # when $(srcdir) is a pathological name like "....", the leading sed comma=
nd
 # removes only the intended prefix.
 _dot_escaped_srcdir =3D $(subst .,\.,$(srcdir))
+_dot_escaped_builddir =3D $(subst .,\.,$(builddir))
=20
 # Post-process $(VC_LIST) output, prepending $(srcdir)/, but only
 # when $(srcdir) is not ".".
@@ -1968,11 +1969,13 @@ perl_translatable_files_list_ =3D						\
=20
 # Verify that all source files using _() (more specifically, files that
 # match $(_gl_translatable_string_re)) are listed in po/POTFILES.in.
-po_file ?=3D $(srcdir)/po/POTFILES
+po_file ?=3D $(srcdir)/po/POTFILES.in
=20
 # List of additional files that we want to pick up in our POTFILES.in
 # This is all gnulib files, as well as generated files for RPC code.
 generated_files =3D \
+  $(builddir)/src/*.[ch] \
+  $(builddir)/src/*/*.[ch] \
   $(srcdir)/src/*/{remote_daemon,admin_server,log_daemon,lock_daemon}_disp=
atch_*stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
@@ -1989,7 +1992,8 @@ sc_po_check: gen_source_files
 	  { $(VC_LIST_EXCEPT); echo $(generated_files); }		\
 	    | xargs perl $(perl_translatable_files_list_)		\
 	    | xargs $(GREP) -E -l '$(_gl_translatable_string_re)'	\
-	    | $(SED) 's|^$(_dot_escaped_srcdir)/||'			\
+	    | $(SED) 's|^$(_dot_escaped_srcdir)|@SRCDIR@|'		\
+	    | $(SED) 's|^$(_dot_escaped_builddir)|@BUILDDIR@|'		\
 	    | sort -u > $@-2;						\
 	  diff -u -L $(po_file) -L $(po_file) $@-1 $@-2			\
 	    || { printf '$(ME): '$(fix_po_file_diag) 1>&2; exit 1; };	\
diff --git a/po/Makefile.am b/po/Makefile.am
index 89e831f839..443d8a4dc1 100644
--- a/po/Makefile.am
+++ b/po/Makefile.am
@@ -15,16 +15,21 @@ LANGS :=3D \
 	uk ur vi wba yo zh_CN zh_HK zh_TW zu
=20
=20
-POTFILE_DEPS :=3D $(shell $(SED) 's,^,$(top_srcdir)/,' $(srcdir)/POTFILES)
+POTFILES_IN =3D $(srcdir)/POTFILES.in
+POTFILES: $(POTFILES_IN)
+	$(AM_V_GEN) cat $(POTFILES_IN) | \
+		$(SED) 's|[@]SRCDIR[@]|$(top_srcdir)|' | \
+		$(SED) 's|[@]BUILDDIR[@]|$(top_builddir)|' > $@
+POTFILE_DEPS =3D $(shell cat POTFILES)
 POTFILE :=3D $(DOMAIN).pot
 POMINIFILES :=3D $(LANGS:%=3D%.mini.po)
 POFILES :=3D $(LANGS:%=3D%.po)
 GMOFILES :=3D $(LANGS:%=3D%.gmo)
=20
-CLEANFILES =3D $(POTFILE) $(POFILES) $(GMOFILES)
+CLEANFILES =3D $(POTFILE) $(POFILES) $(GMOFILES) POTFILES
=20
 EXTRA_DIST =3D \
-	POTFILES \
+	$(POTFILES_IN) \
 	$(POMINIFILES)
=20
 if HAVE_GNU_GETTEXT_TOOLS
@@ -38,7 +43,6 @@ XGETTEXT_ARGS =3D \
 	--package-name=3D"$(PACKAGE_NAME)" \
 	--package-version=3D"$(PACKAGE_VERSION)" \
 	--msgid-bugs-address=3D"$(MSGID_BUGS_ADDRESS)" \
-	--directory=3D$(top_srcdir) \
 	$(NULL)
=20
 SED_PO_FIXUP_ARGS =3D \
@@ -79,7 +83,7 @@ pull-po: $(POTFILE)
=20
 $(POTFILE): POTFILES $(POTFILE_DEPS)
 	$(XGETTEXT) -o $@-t $(XGETTEXT_ARGS) \
-	  --files-from=3D$(abs_srcdir)/POTFILES
+	  --files-from=3D$(abs_builddir)/POTFILES
 	$(SED) $(SED_PO_FIXUP_ARGS) < $@-t > $@
 	rm -f $@-t
=20
diff --git a/po/POTFILES b/po/POTFILES
deleted file mode 100644
index 217d7e2006..0000000000
--- a/po/POTFILES
+++ /dev/null
@@ -1,352 +0,0 @@
-gnulib/lib/gai_strerror.c
-gnulib/lib/regcomp.c
-src/access/viraccessdriverpolkit.c
-src/access/viraccessmanager.c
-src/admin/admin_server.c
-src/admin/admin_server_dispatch.c
-src/admin/admin_server_dispatch_stubs.h
-src/admin/libvirt-admin.c
-src/bhyve/bhyve_capabilities.c
-src/bhyve/bhyve_command.c
-src/bhyve/bhyve_device.c
-src/bhyve/bhyve_domain.c
-src/bhyve/bhyve_driver.c
-src/bhyve/bhyve_monitor.c
-src/bhyve/bhyve_parse_command.c
-src/bhyve/bhyve_process.c
-src/conf/capabilities.c
-src/conf/checkpoint_conf.c
-src/conf/cpu_conf.c
-src/conf/device_conf.c
-src/conf/domain_addr.c
-src/conf/domain_capabilities.c
-src/conf/domain_conf.c
-src/conf/domain_event.c
-src/conf/interface_conf.c
-src/conf/netdev_bandwidth_conf.c
-src/conf/netdev_vlan_conf.c
-src/conf/netdev_vport_profile_conf.c
-src/conf/network_conf.c
-src/conf/networkcommon_conf.c
-src/conf/node_device_conf.c
-src/conf/node_device_util.c
-src/conf/numa_conf.c
-src/conf/nwfilter_conf.c
-src/conf/nwfilter_params.c
-src/conf/object_event.c
-src/conf/secret_conf.c
-src/conf/snapshot_conf.c
-src/conf/storage_adapter_conf.c
-src/conf/storage_conf.c
-src/conf/virchrdev.c
-src/conf/virdomainmomentobjlist.c
-src/conf/virdomainobjlist.c
-src/conf/virnetworkobj.c
-src/conf/virnetworkportdef.c
-src/conf/virnodedeviceobj.c
-src/conf/virnwfilterbindingdef.c
-src/conf/virnwfilterbindingobj.c
-src/conf/virnwfilterbindingobjlist.c
-src/conf/virnwfilterobj.c
-src/conf/virsavecookie.c
-src/conf/virsecretobj.c
-src/conf/virstorageobj.c
-src/cpu/cpu.c
-src/cpu/cpu_arm.c
-src/cpu/cpu_map.c
-src/cpu/cpu_ppc64.c
-src/cpu/cpu_s390.c
-src/cpu/cpu_x86.c
-src/datatypes.c
-src/driver.c
-src/esx/esx_driver.c
-src/esx/esx_network_driver.c
-src/esx/esx_storage_backend_iscsi.c
-src/esx/esx_storage_backend_vmfs.c
-src/esx/esx_storage_driver.c
-src/esx/esx_stream.c
-src/esx/esx_util.c
-src/esx/esx_util.h
-src/esx/esx_vi.c
-src/esx/esx_vi_methods.c
-src/esx/esx_vi_types.c
-src/hyperv/hyperv_driver.c
-src/hyperv/hyperv_util.c
-src/hyperv/hyperv_wmi.c
-src/interface/interface_backend_netcf.c
-src/interface/interface_backend_udev.c
-src/internal.h
-src/libvirt-domain-checkpoint.c
-src/libvirt-domain-snapshot.c
-src/libvirt-domain.c
-src/libvirt-host.c
-src/libvirt-lxc.c
-src/libvirt-network.c
-src/libvirt-nodedev.c
-src/libvirt-nwfilter.c
-src/libvirt-qemu.c
-src/libvirt-secret.c
-src/libvirt-storage.c
-src/libvirt-stream.c
-src/libvirt.c
-src/libxl/libxl_capabilities.c
-src/libxl/libxl_conf.c
-src/libxl/libxl_domain.c
-src/libxl/libxl_driver.c
-src/libxl/libxl_migration.c
-src/libxl/xen_common.c
-src/libxl/xen_xl.c
-src/libxl/xen_xm.c
-src/locking/lock_daemon.c
-src/locking/lock_daemon_dispatch.c
-src/locking/lock_driver_lockd.c
-src/locking/lock_driver_sanlock.c
-src/locking/lock_manager.c
-src/locking/sanlock_helper.c
-src/logging/log_daemon.c
-src/logging/log_daemon_dispatch.c
-src/logging/log_handler.c
-src/logging/log_manager.c
-src/lxc/lxc_cgroup.c
-src/lxc/lxc_conf.c
-src/lxc/lxc_container.c
-src/lxc/lxc_controller.c
-src/lxc/lxc_domain.c
-src/lxc/lxc_driver.c
-src/lxc/lxc_fuse.c
-src/lxc/lxc_hostdev.c
-src/lxc/lxc_native.c
-src/lxc/lxc_process.c
-src/network/bridge_driver.c
-src/network/bridge_driver_linux.c
-src/network/leaseshelper.c
-src/node_device/node_device_driver.c
-src/node_device/node_device_hal.c
-src/node_device/node_device_udev.c
-src/nwfilter/nwfilter_dhcpsnoop.c
-src/nwfilter/nwfilter_driver.c
-src/nwfilter/nwfilter_ebiptables_driver.c
-src/nwfilter/nwfilter_gentech_driver.c
-src/nwfilter/nwfilter_learnipaddr.c
-src/openvz/openvz_conf.c
-src/openvz/openvz_driver.c
-src/openvz/openvz_util.c
-src/phyp/phyp_driver.c
-src/qemu/qemu_agent.c
-src/qemu/qemu_alias.c
-src/qemu/qemu_block.c
-src/qemu/qemu_blockjob.c
-src/qemu/qemu_capabilities.c
-src/qemu/qemu_cgroup.c
-src/qemu/qemu_checkpoint.c
-src/qemu/qemu_command.c
-src/qemu/qemu_conf.c
-src/qemu/qemu_dbus.c
-src/qemu/qemu_domain.c
-src/qemu/qemu_domain_address.c
-src/qemu/qemu_driver.c
-src/qemu/qemu_extdevice.c
-src/qemu/qemu_firmware.c
-src/qemu/qemu_hostdev.c
-src/qemu/qemu_hotplug.c
-src/qemu/qemu_interface.c
-src/qemu/qemu_interop_config.c
-src/qemu/qemu_migration.c
-src/qemu/qemu_migration_cookie.c
-src/qemu/qemu_migration_params.c
-src/qemu/qemu_monitor.c
-src/qemu/qemu_monitor_json.c
-src/qemu/qemu_monitor_text.c
-src/qemu/qemu_process.c
-src/qemu/qemu_qapi.c
-src/qemu/qemu_slirp.c
-src/qemu/qemu_tpm.c
-src/qemu/qemu_vhost_user.c
-src/qemu/qemu_vhost_user_gpu.c
-src/remote/remote_client_bodies.h
-src/remote/remote_daemon.c
-src/remote/remote_daemon_config.c
-src/remote/remote_daemon_dispatch.c
-src/remote/remote_daemon_dispatch_stubs.h
-src/remote/remote_daemon_stream.c
-src/remote/remote_driver.c
-src/rpc/virkeepalive.c
-src/rpc/virnetclient.c
-src/rpc/virnetclientprogram.c
-src/rpc/virnetclientstream.c
-src/rpc/virnetdaemon.c
-src/rpc/virnetlibsshsession.c
-src/rpc/virnetmessage.c
-src/rpc/virnetsaslcontext.c
-src/rpc/virnetserver.c
-src/rpc/virnetserverclient.c
-src/rpc/virnetserverprogram.c
-src/rpc/virnetserverservice.c
-src/rpc/virnetsocket.c
-src/rpc/virnetsshsession.c
-src/rpc/virnettlscontext.c
-src/secret/secret_driver.c
-src/secret/secret_util.c
-src/security/security_apparmor.c
-src/security/security_dac.c
-src/security/security_driver.c
-src/security/security_manager.c
-src/security/security_selinux.c
-src/security/security_util.c
-src/security/virt-aa-helper.c
-src/storage/parthelper.c
-src/storage/storage_backend.c
-src/storage/storage_backend_disk.c
-src/storage/storage_backend_fs.c
-src/storage/storage_backend_gluster.c
-src/storage/storage_backend_iscsi.c
-src/storage/storage_backend_iscsi_direct.c
-src/storage/storage_backend_logical.c
-src/storage/storage_backend_mpath.c
-src/storage/storage_backend_rbd.c
-src/storage/storage_backend_scsi.c
-src/storage/storage_backend_sheepdog.c
-src/storage/storage_backend_vstorage.c
-src/storage/storage_backend_zfs.c
-src/storage/storage_driver.c
-src/storage/storage_file_fs.c
-src/storage/storage_file_gluster.c
-src/storage/storage_util.c
-src/test/test_driver.c
-src/util/iohelper.c
-src/util/viralloc.c
-src/util/virarptable.c
-src/util/viraudit.c
-src/util/virauth.c
-src/util/virauthconfig.c
-src/util/virbitmap.c
-src/util/vircgroup.c
-src/util/vircgroupbackend.c
-src/util/vircgroupbackend.h
-src/util/vircgroupv1.c
-src/util/vircgroupv2.c
-src/util/virclosecallbacks.c
-src/util/vircommand.c
-src/util/virconf.c
-src/util/vircrypto.c
-src/util/virdbus.c
-src/util/virdnsmasq.c
-src/util/virerror.c
-src/util/virerror.h
-src/util/vireventpoll.c
-src/util/virfcp.c
-src/util/virfdstream.c
-src/util/virfile.c
-src/util/virfilecache.c
-src/util/virfirewall.c
-src/util/virfirewalld.c
-src/util/virfirmware.c
-src/util/virhash.c
-src/util/virhook.c
-src/util/virhostcpu.c
-src/util/virhostdev.c
-src/util/virhostmem.c
-src/util/viridentity.c
-src/util/virinitctl.c
-src/util/viriptables.c
-src/util/viriscsi.c
-src/util/virjson.c
-src/util/virkeyfile.c
-src/util/virlease.c
-src/util/virlockspace.c
-src/util/virlog.c
-src/util/virmacmap.c
-src/util/virmdev.c
-src/util/virmodule.c
-src/util/virnetdev.c
-src/util/virnetdevbandwidth.c
-src/util/virnetdevbridge.c
-src/util/virnetdevip.c
-src/util/virnetdevmacvlan.c
-src/util/virnetdevmidonet.c
-src/util/virnetdevopenvswitch.c
-src/util/virnetdevtap.c
-src/util/virnetdevveth.c
-src/util/virnetdevvportprofile.c
-src/util/virnetlink.c
-src/util/virnodesuspend.c
-src/util/virnuma.c
-src/util/virobject.c
-src/util/virpci.c
-src/util/virperf.c
-src/util/virpidfile.c
-src/util/virpolkit.c
-src/util/virportallocator.c
-src/util/virprocess.c
-src/util/virqemu.c
-src/util/virrandom.c
-src/util/virresctrl.c
-src/util/virrotatingfile.c
-src/util/virscsi.c
-src/util/virscsihost.c
-src/util/virscsivhost.c
-src/util/virsecret.c
-src/util/virsocketaddr.c
-src/util/virstorageencryption.c
-src/util/virstoragefile.c
-src/util/virstoragefilebackend.c
-src/util/virstring.c
-src/util/virsysinfo.c
-src/util/virsystemd.c
-src/util/virthreadjob.c
-src/util/virthreadpool.c
-src/util/virtime.c
-src/util/virtpm.c
-src/util/virtypedparam-public.c
-src/util/virtypedparam.c
-src/util/viruri.c
-src/util/virusb.c
-src/util/virutil.c
-src/util/virvhba.c
-src/util/virvsock.c
-src/util/virxml.c
-src/vbox/vbox_MSCOMGlue.c
-src/vbox/vbox_XPCOMCGlue.c
-src/vbox/vbox_common.c
-src/vbox/vbox_driver.c
-src/vbox/vbox_network.c
-src/vbox/vbox_snapshot_conf.c
-src/vbox/vbox_storage.c
-src/vbox/vbox_tmpl.c
-src/vmware/vmware_conf.c
-src/vmware/vmware_driver.c
-src/vmx/vmx.c
-src/vz/vz_driver.c
-src/vz/vz_sdk.c
-src/vz/vz_utils.c
-src/vz/vz_utils.h
-tests/virpolkittest.c
-tools/libvirt-guests.sh.in
-tools/virsh-checkpoint.c
-tools/virsh-completer-host.c
-tools/virsh-console.c
-tools/virsh-domain-monitor.c
-tools/virsh-domain.c
-tools/virsh-edit.c
-tools/virsh-host.c
-tools/virsh-interface.c
-tools/virsh-network.c
-tools/virsh-nodedev.c
-tools/virsh-nwfilter.c
-tools/virsh-pool.c
-tools/virsh-secret.c
-tools/virsh-snapshot.c
-tools/virsh-util.c
-tools/virsh-volume.c
-tools/virsh.c
-tools/virsh.h
-tools/virt-admin.c
-tools/virt-host-validate-bhyve.c
-tools/virt-host-validate-common.c
-tools/virt-host-validate-lxc.c
-tools/virt-host-validate-qemu.c
-tools/virt-host-validate.c
-tools/virt-login-shell-helper.c
-tools/vsh-table.c
-tools/vsh.c
-tools/vsh.h
diff --git a/po/POTFILES.in b/po/POTFILES.in
new file mode 100644
index 0000000000..a422d3659e
--- /dev/null
+++ b/po/POTFILES.in
@@ -0,0 +1,352 @@
+@SRCDIR@/gnulib/lib/gai_strerror.c
+@SRCDIR@/gnulib/lib/regcomp.c
+@SRCDIR@/src/access/viraccessdriverpolkit.c
+@SRCDIR@/src/access/viraccessmanager.c
+@SRCDIR@/src/admin/admin_server.c
+@SRCDIR@/src/admin/admin_server_dispatch.c
+@SRCDIR@/src/admin/admin_server_dispatch_stubs.h
+@SRCDIR@/src/admin/libvirt-admin.c
+@SRCDIR@/src/bhyve/bhyve_capabilities.c
+@SRCDIR@/src/bhyve/bhyve_command.c
+@SRCDIR@/src/bhyve/bhyve_device.c
+@SRCDIR@/src/bhyve/bhyve_domain.c
+@SRCDIR@/src/bhyve/bhyve_driver.c
+@SRCDIR@/src/bhyve/bhyve_monitor.c
+@SRCDIR@/src/bhyve/bhyve_parse_command.c
+@SRCDIR@/src/bhyve/bhyve_process.c
+@SRCDIR@/src/conf/capabilities.c
+@SRCDIR@/src/conf/checkpoint_conf.c
+@SRCDIR@/src/conf/cpu_conf.c
+@SRCDIR@/src/conf/device_conf.c
+@SRCDIR@/src/conf/domain_addr.c
+@SRCDIR@/src/conf/domain_capabilities.c
+@SRCDIR@/src/conf/domain_conf.c
+@SRCDIR@/src/conf/domain_event.c
+@SRCDIR@/src/conf/interface_conf.c
+@SRCDIR@/src/conf/netdev_bandwidth_conf.c
+@SRCDIR@/src/conf/netdev_vlan_conf.c
+@SRCDIR@/src/conf/netdev_vport_profile_conf.c
+@SRCDIR@/src/conf/network_conf.c
+@SRCDIR@/src/conf/networkcommon_conf.c
+@SRCDIR@/src/conf/node_device_conf.c
+@SRCDIR@/src/conf/node_device_util.c
+@SRCDIR@/src/conf/numa_conf.c
+@SRCDIR@/src/conf/nwfilter_conf.c
+@SRCDIR@/src/conf/nwfilter_params.c
+@SRCDIR@/src/conf/object_event.c
+@SRCDIR@/src/conf/secret_conf.c
+@SRCDIR@/src/conf/snapshot_conf.c
+@SRCDIR@/src/conf/storage_adapter_conf.c
+@SRCDIR@/src/conf/storage_conf.c
+@SRCDIR@/src/conf/virchrdev.c
+@SRCDIR@/src/conf/virdomainmomentobjlist.c
+@SRCDIR@/src/conf/virdomainobjlist.c
+@SRCDIR@/src/conf/virnetworkobj.c
+@SRCDIR@/src/conf/virnetworkportdef.c
+@SRCDIR@/src/conf/virnodedeviceobj.c
+@SRCDIR@/src/conf/virnwfilterbindingdef.c
+@SRCDIR@/src/conf/virnwfilterbindingobj.c
+@SRCDIR@/src/conf/virnwfilterbindingobjlist.c
+@SRCDIR@/src/conf/virnwfilterobj.c
+@SRCDIR@/src/conf/virsavecookie.c
+@SRCDIR@/src/conf/virsecretobj.c
+@SRCDIR@/src/conf/virstorageobj.c
+@SRCDIR@/src/cpu/cpu.c
+@SRCDIR@/src/cpu/cpu_arm.c
+@SRCDIR@/src/cpu/cpu_map.c
+@SRCDIR@/src/cpu/cpu_ppc64.c
+@SRCDIR@/src/cpu/cpu_s390.c
+@SRCDIR@/src/cpu/cpu_x86.c
+@SRCDIR@/src/datatypes.c
+@SRCDIR@/src/driver.c
+@SRCDIR@/src/esx/esx_driver.c
+@SRCDIR@/src/esx/esx_network_driver.c
+@SRCDIR@/src/esx/esx_storage_backend_iscsi.c
+@SRCDIR@/src/esx/esx_storage_backend_vmfs.c
+@SRCDIR@/src/esx/esx_storage_driver.c
+@SRCDIR@/src/esx/esx_stream.c
+@SRCDIR@/src/esx/esx_util.c
+@SRCDIR@/src/esx/esx_util.h
+@SRCDIR@/src/esx/esx_vi.c
+@SRCDIR@/src/esx/esx_vi_methods.c
+@SRCDIR@/src/esx/esx_vi_types.c
+@SRCDIR@/src/hyperv/hyperv_driver.c
+@SRCDIR@/src/hyperv/hyperv_util.c
+@SRCDIR@/src/hyperv/hyperv_wmi.c
+@SRCDIR@/src/interface/interface_backend_netcf.c
+@SRCDIR@/src/interface/interface_backend_udev.c
+@SRCDIR@/src/internal.h
+@SRCDIR@/src/libvirt-domain-checkpoint.c
+@SRCDIR@/src/libvirt-domain-snapshot.c
+@SRCDIR@/src/libvirt-domain.c
+@SRCDIR@/src/libvirt-host.c
+@SRCDIR@/src/libvirt-lxc.c
+@SRCDIR@/src/libvirt-network.c
+@SRCDIR@/src/libvirt-nodedev.c
+@SRCDIR@/src/libvirt-nwfilter.c
+@SRCDIR@/src/libvirt-qemu.c
+@SRCDIR@/src/libvirt-secret.c
+@SRCDIR@/src/libvirt-storage.c
+@SRCDIR@/src/libvirt-stream.c
+@SRCDIR@/src/libvirt.c
+@SRCDIR@/src/libxl/libxl_capabilities.c
+@SRCDIR@/src/libxl/libxl_conf.c
+@SRCDIR@/src/libxl/libxl_domain.c
+@SRCDIR@/src/libxl/libxl_driver.c
+@SRCDIR@/src/libxl/libxl_migration.c
+@SRCDIR@/src/libxl/xen_common.c
+@SRCDIR@/src/libxl/xen_xl.c
+@SRCDIR@/src/libxl/xen_xm.c
+@SRCDIR@/src/locking/lock_daemon.c
+@SRCDIR@/src/locking/lock_daemon_dispatch.c
+@SRCDIR@/src/locking/lock_driver_lockd.c
+@SRCDIR@/src/locking/lock_driver_sanlock.c
+@SRCDIR@/src/locking/lock_manager.c
+@SRCDIR@/src/locking/sanlock_helper.c
+@SRCDIR@/src/logging/log_daemon.c
+@SRCDIR@/src/logging/log_daemon_dispatch.c
+@SRCDIR@/src/logging/log_handler.c
+@SRCDIR@/src/logging/log_manager.c
+@SRCDIR@/src/lxc/lxc_cgroup.c
+@SRCDIR@/src/lxc/lxc_conf.c
+@SRCDIR@/src/lxc/lxc_container.c
+@SRCDIR@/src/lxc/lxc_controller.c
+@SRCDIR@/src/lxc/lxc_domain.c
+@SRCDIR@/src/lxc/lxc_driver.c
+@SRCDIR@/src/lxc/lxc_fuse.c
+@SRCDIR@/src/lxc/lxc_hostdev.c
+@SRCDIR@/src/lxc/lxc_native.c
+@SRCDIR@/src/lxc/lxc_process.c
+@SRCDIR@/src/network/bridge_driver.c
+@SRCDIR@/src/network/bridge_driver_linux.c
+@SRCDIR@/src/network/leaseshelper.c
+@SRCDIR@/src/node_device/node_device_driver.c
+@SRCDIR@/src/node_device/node_device_hal.c
+@SRCDIR@/src/node_device/node_device_udev.c
+@SRCDIR@/src/nwfilter/nwfilter_dhcpsnoop.c
+@SRCDIR@/src/nwfilter/nwfilter_driver.c
+@SRCDIR@/src/nwfilter/nwfilter_ebiptables_driver.c
+@SRCDIR@/src/nwfilter/nwfilter_gentech_driver.c
+@SRCDIR@/src/nwfilter/nwfilter_learnipaddr.c
+@SRCDIR@/src/openvz/openvz_conf.c
+@SRCDIR@/src/openvz/openvz_driver.c
+@SRCDIR@/src/openvz/openvz_util.c
+@SRCDIR@/src/phyp/phyp_driver.c
+@SRCDIR@/src/qemu/qemu_agent.c
+@SRCDIR@/src/qemu/qemu_alias.c
+@SRCDIR@/src/qemu/qemu_block.c
+@SRCDIR@/src/qemu/qemu_blockjob.c
+@SRCDIR@/src/qemu/qemu_capabilities.c
+@SRCDIR@/src/qemu/qemu_cgroup.c
+@SRCDIR@/src/qemu/qemu_checkpoint.c
+@SRCDIR@/src/qemu/qemu_command.c
+@SRCDIR@/src/qemu/qemu_conf.c
+@SRCDIR@/src/qemu/qemu_dbus.c
+@SRCDIR@/src/qemu/qemu_domain.c
+@SRCDIR@/src/qemu/qemu_domain_address.c
+@SRCDIR@/src/qemu/qemu_driver.c
+@SRCDIR@/src/qemu/qemu_extdevice.c
+@SRCDIR@/src/qemu/qemu_firmware.c
+@SRCDIR@/src/qemu/qemu_hostdev.c
+@SRCDIR@/src/qemu/qemu_hotplug.c
+@SRCDIR@/src/qemu/qemu_interface.c
+@SRCDIR@/src/qemu/qemu_interop_config.c
+@SRCDIR@/src/qemu/qemu_migration.c
+@SRCDIR@/src/qemu/qemu_migration_cookie.c
+@SRCDIR@/src/qemu/qemu_migration_params.c
+@SRCDIR@/src/qemu/qemu_monitor.c
+@SRCDIR@/src/qemu/qemu_monitor_json.c
+@SRCDIR@/src/qemu/qemu_monitor_text.c
+@SRCDIR@/src/qemu/qemu_process.c
+@SRCDIR@/src/qemu/qemu_qapi.c
+@SRCDIR@/src/qemu/qemu_slirp.c
+@SRCDIR@/src/qemu/qemu_tpm.c
+@SRCDIR@/src/qemu/qemu_vhost_user.c
+@SRCDIR@/src/qemu/qemu_vhost_user_gpu.c
+@SRCDIR@/src/remote/remote_client_bodies.h
+@SRCDIR@/src/remote/remote_daemon.c
+@SRCDIR@/src/remote/remote_daemon_config.c
+@SRCDIR@/src/remote/remote_daemon_dispatch.c
+@SRCDIR@/src/remote/remote_daemon_dispatch_stubs.h
+@SRCDIR@/src/remote/remote_daemon_stream.c
+@SRCDIR@/src/remote/remote_driver.c
+@SRCDIR@/src/rpc/virkeepalive.c
+@SRCDIR@/src/rpc/virnetclient.c
+@SRCDIR@/src/rpc/virnetclientprogram.c
+@SRCDIR@/src/rpc/virnetclientstream.c
+@SRCDIR@/src/rpc/virnetdaemon.c
+@SRCDIR@/src/rpc/virnetlibsshsession.c
+@SRCDIR@/src/rpc/virnetmessage.c
+@SRCDIR@/src/rpc/virnetsaslcontext.c
+@SRCDIR@/src/rpc/virnetserver.c
+@SRCDIR@/src/rpc/virnetserverclient.c
+@SRCDIR@/src/rpc/virnetserverprogram.c
+@SRCDIR@/src/rpc/virnetserverservice.c
+@SRCDIR@/src/rpc/virnetsocket.c
+@SRCDIR@/src/rpc/virnetsshsession.c
+@SRCDIR@/src/rpc/virnettlscontext.c
+@SRCDIR@/src/secret/secret_driver.c
+@SRCDIR@/src/secret/secret_util.c
+@SRCDIR@/src/security/security_apparmor.c
+@SRCDIR@/src/security/security_dac.c
+@SRCDIR@/src/security/security_driver.c
+@SRCDIR@/src/security/security_manager.c
+@SRCDIR@/src/security/security_selinux.c
+@SRCDIR@/src/security/security_util.c
+@SRCDIR@/src/security/virt-aa-helper.c
+@SRCDIR@/src/storage/parthelper.c
+@SRCDIR@/src/storage/storage_backend.c
+@SRCDIR@/src/storage/storage_backend_disk.c
+@SRCDIR@/src/storage/storage_backend_fs.c
+@SRCDIR@/src/storage/storage_backend_gluster.c
+@SRCDIR@/src/storage/storage_backend_iscsi.c
+@SRCDIR@/src/storage/storage_backend_iscsi_direct.c
+@SRCDIR@/src/storage/storage_backend_logical.c
+@SRCDIR@/src/storage/storage_backend_mpath.c
+@SRCDIR@/src/storage/storage_backend_rbd.c
+@SRCDIR@/src/storage/storage_backend_scsi.c
+@SRCDIR@/src/storage/storage_backend_sheepdog.c
+@SRCDIR@/src/storage/storage_backend_vstorage.c
+@SRCDIR@/src/storage/storage_backend_zfs.c
+@SRCDIR@/src/storage/storage_driver.c
+@SRCDIR@/src/storage/storage_file_fs.c
+@SRCDIR@/src/storage/storage_file_gluster.c
+@SRCDIR@/src/storage/storage_util.c
+@SRCDIR@/src/test/test_driver.c
+@SRCDIR@/src/util/iohelper.c
+@SRCDIR@/src/util/viralloc.c
+@SRCDIR@/src/util/virarptable.c
+@SRCDIR@/src/util/viraudit.c
+@SRCDIR@/src/util/virauth.c
+@SRCDIR@/src/util/virauthconfig.c
+@SRCDIR@/src/util/virbitmap.c
+@SRCDIR@/src/util/vircgroup.c
+@SRCDIR@/src/util/vircgroupbackend.c
+@SRCDIR@/src/util/vircgroupbackend.h
+@SRCDIR@/src/util/vircgroupv1.c
+@SRCDIR@/src/util/vircgroupv2.c
+@SRCDIR@/src/util/virclosecallbacks.c
+@SRCDIR@/src/util/vircommand.c
+@SRCDIR@/src/util/virconf.c
+@SRCDIR@/src/util/vircrypto.c
+@SRCDIR@/src/util/virdbus.c
+@SRCDIR@/src/util/virdnsmasq.c
+@SRCDIR@/src/util/virerror.c
+@SRCDIR@/src/util/virerror.h
+@SRCDIR@/src/util/vireventpoll.c
+@SRCDIR@/src/util/virfcp.c
+@SRCDIR@/src/util/virfdstream.c
+@SRCDIR@/src/util/virfile.c
+@SRCDIR@/src/util/virfilecache.c
+@SRCDIR@/src/util/virfirewall.c
+@SRCDIR@/src/util/virfirewalld.c
+@SRCDIR@/src/util/virfirmware.c
+@SRCDIR@/src/util/virhash.c
+@SRCDIR@/src/util/virhook.c
+@SRCDIR@/src/util/virhostcpu.c
+@SRCDIR@/src/util/virhostdev.c
+@SRCDIR@/src/util/virhostmem.c
+@SRCDIR@/src/util/viridentity.c
+@SRCDIR@/src/util/virinitctl.c
+@SRCDIR@/src/util/viriptables.c
+@SRCDIR@/src/util/viriscsi.c
+@SRCDIR@/src/util/virjson.c
+@SRCDIR@/src/util/virkeyfile.c
+@SRCDIR@/src/util/virlease.c
+@SRCDIR@/src/util/virlockspace.c
+@SRCDIR@/src/util/virlog.c
+@SRCDIR@/src/util/virmacmap.c
+@SRCDIR@/src/util/virmdev.c
+@SRCDIR@/src/util/virmodule.c
+@SRCDIR@/src/util/virnetdev.c
+@SRCDIR@/src/util/virnetdevbandwidth.c
+@SRCDIR@/src/util/virnetdevbridge.c
+@SRCDIR@/src/util/virnetdevip.c
+@SRCDIR@/src/util/virnetdevmacvlan.c
+@SRCDIR@/src/util/virnetdevmidonet.c
+@SRCDIR@/src/util/virnetdevopenvswitch.c
+@SRCDIR@/src/util/virnetdevtap.c
+@SRCDIR@/src/util/virnetdevveth.c
+@SRCDIR@/src/util/virnetdevvportprofile.c
+@SRCDIR@/src/util/virnetlink.c
+@SRCDIR@/src/util/virnodesuspend.c
+@SRCDIR@/src/util/virnuma.c
+@SRCDIR@/src/util/virobject.c
+@SRCDIR@/src/util/virpci.c
+@SRCDIR@/src/util/virperf.c
+@SRCDIR@/src/util/virpidfile.c
+@SRCDIR@/src/util/virpolkit.c
+@SRCDIR@/src/util/virportallocator.c
+@SRCDIR@/src/util/virprocess.c
+@SRCDIR@/src/util/virqemu.c
+@SRCDIR@/src/util/virrandom.c
+@SRCDIR@/src/util/virresctrl.c
+@SRCDIR@/src/util/virrotatingfile.c
+@SRCDIR@/src/util/virscsi.c
+@SRCDIR@/src/util/virscsihost.c
+@SRCDIR@/src/util/virscsivhost.c
+@SRCDIR@/src/util/virsecret.c
+@SRCDIR@/src/util/virsocketaddr.c
+@SRCDIR@/src/util/virstorageencryption.c
+@SRCDIR@/src/util/virstoragefile.c
+@SRCDIR@/src/util/virstoragefilebackend.c
+@SRCDIR@/src/util/virstring.c
+@SRCDIR@/src/util/virsysinfo.c
+@SRCDIR@/src/util/virsystemd.c
+@SRCDIR@/src/util/virthreadjob.c
+@SRCDIR@/src/util/virthreadpool.c
+@SRCDIR@/src/util/virtime.c
+@SRCDIR@/src/util/virtpm.c
+@SRCDIR@/src/util/virtypedparam-public.c
+@SRCDIR@/src/util/virtypedparam.c
+@SRCDIR@/src/util/viruri.c
+@SRCDIR@/src/util/virusb.c
+@SRCDIR@/src/util/virutil.c
+@SRCDIR@/src/util/virvhba.c
+@SRCDIR@/src/util/virvsock.c
+@SRCDIR@/src/util/virxml.c
+@SRCDIR@/src/vbox/vbox_MSCOMGlue.c
+@SRCDIR@/src/vbox/vbox_XPCOMCGlue.c
+@SRCDIR@/src/vbox/vbox_common.c
+@SRCDIR@/src/vbox/vbox_driver.c
+@SRCDIR@/src/vbox/vbox_network.c
+@SRCDIR@/src/vbox/vbox_snapshot_conf.c
+@SRCDIR@/src/vbox/vbox_storage.c
+@SRCDIR@/src/vbox/vbox_tmpl.c
+@SRCDIR@/src/vmware/vmware_conf.c
+@SRCDIR@/src/vmware/vmware_driver.c
+@SRCDIR@/src/vmx/vmx.c
+@SRCDIR@/src/vz/vz_driver.c
+@SRCDIR@/src/vz/vz_sdk.c
+@SRCDIR@/src/vz/vz_utils.c
+@SRCDIR@/src/vz/vz_utils.h
+@SRCDIR@/tests/virpolkittest.c
+@SRCDIR@/tools/libvirt-guests.sh.in
+@SRCDIR@/tools/virsh-checkpoint.c
+@SRCDIR@/tools/virsh-completer-host.c
+@SRCDIR@/tools/virsh-console.c
+@SRCDIR@/tools/virsh-domain-monitor.c
+@SRCDIR@/tools/virsh-domain.c
+@SRCDIR@/tools/virsh-edit.c
+@SRCDIR@/tools/virsh-host.c
+@SRCDIR@/tools/virsh-interface.c
+@SRCDIR@/tools/virsh-network.c
+@SRCDIR@/tools/virsh-nodedev.c
+@SRCDIR@/tools/virsh-nwfilter.c
+@SRCDIR@/tools/virsh-pool.c
+@SRCDIR@/tools/virsh-secret.c
+@SRCDIR@/tools/virsh-snapshot.c
+@SRCDIR@/tools/virsh-util.c
+@SRCDIR@/tools/virsh-volume.c
+@SRCDIR@/tools/virsh.c
+@SRCDIR@/tools/virsh.h
+@SRCDIR@/tools/virt-admin.c
+@SRCDIR@/tools/virt-host-validate-bhyve.c
+@SRCDIR@/tools/virt-host-validate-common.c
+@SRCDIR@/tools/virt-host-validate-lxc.c
+@SRCDIR@/tools/virt-host-validate-qemu.c
+@SRCDIR@/tools/virt-host-validate.c
+@SRCDIR@/tools/virt-login-shell-helper.c
+@SRCDIR@/tools/vsh-table.c
+@SRCDIR@/tools/vsh.c
+@SRCDIR@/tools/vsh.h
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender) client-ip=207.211.31.81;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228010; cv=none;
	d=zoho.com; s=zohoarc;
	b=UGZHvRCvK50UdFgmaCPYcxew1yozcRypXlM9f73dl/H7zegeAEx0KXVjswSXBsyQLaXEZflQxBSb28R3M+peIsDmh9Ih6/i2ElsRg5bBn3zNge45kb39DU5fb0W7T/q7z1PW8/szFO/ORNxrZQlAQcrEgKw/dnuRcSQ7fnf3uUw=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228010;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=0W3Gyw0vl70G6NnDQKMH1YfBHwN61w9Q9+Jc4fCf2MI=;
	b=MkEepKZEsprmdyWt8AGHpGKZbcUBha7aR0I7Mdh6GD6cApfgU8fjJgq9eESqIcjHP7nr42zkJAdv9AysrMG9VUJ8fO3MxqxMtmyt0n9O9h+OXhVeqGTGZ2lwFpZJCiyEKkqcsEHQvLa1uxObnIEAQhE2D7HVw/mHRLFrJ1X4JLE=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
 [207.211.31.81]) by mx.zohomail.com
	with SMTPS id 1573228010831238.47698600415345;
 Fri, 8 Nov 2019 07:46:50 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-153-d6g8_TluNpOtL7MJUuLRoA-1; Fri, 08 Nov 2019 10:46:47 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08D07800686;
	Fri,  8 Nov 2019 15:46:43 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D9B825C1BB;
	Fri,  8 Nov 2019 15:46:42 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9BB8E4BB78;
	Fri,  8 Nov 2019 15:46:42 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgZEW014093 for ;
	Fri, 8 Nov 2019 10:42:35 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 8A7C35D6B7; Fri,  8 Nov 2019 15:42:35 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id EE7635D6AE
	for ; Fri,  8 Nov 2019 15:42:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228009;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=0W3Gyw0vl70G6NnDQKMH1YfBHwN61w9Q9+Jc4fCf2MI=;
	b=EyPZxCRUdEhn3lGW3kKEA1TbqcVpFMQJdsImsjxVjv0R7aYP01WFpAMmNDu6qC7RO9/siP
	gT2VnOAmOV3qqas7rx3g11JkfQPEPsNOwY29FlM9lWbWEBpkTt8PT66Lc4CR2cJ94YHigh
	puTcQ14u4xuxYLWz54OUN99YnLVGYJg=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:09 +0100
Message-Id: 
 <95f0cb46e11882fb410408d838600aac6255ae3b.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 08/20] [ACKED] po: README.md: add a note about
	which Zanata client is required
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: d6g8_TluNpOtL7MJUuLRoA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    New in v3.

 po/README.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/po/README.md b/po/README.md
index 71b5793a2d..2f77c5d48c 100644
--- a/po/README.md
+++ b/po/README.md
@@ -4,6 +4,9 @@ Libvirt Message Translation
 Libvirt translatable messages are maintained using the GNU Gettext tools a=
nd
 file formats, in combination with the Zanata web service.
=20
+python-zanata-client is required in order to use make to pull/push transla=
tions
+from/to Zanata server.
+
 Source repository
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=20
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573227970; cv=none;
	d=zoho.com; s=zohoarc;
	b=gglCbuTqWwBtjUDiV+v8enY/mRk1Lw7Lo4ZCUnPFEmK7wx7IJ/SU2xGyEnJe5kY/OXcm2PBQbwQ/UFxFJPGylByq606AvE2+QcDD+tLi5MZq7R5+cWkN9FZM9Z8hFiRjvBaWMG383ucA75VWAEA1evolTCe2NMOBZQZhqF6zT1Q=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573227970;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=BHNIEZcCo3xEAwpWzMgAtbs1znaL80qgZIesq1Ii+e4=;
	b=ByCuH5Nk1Nke1YVW5ptV0kduuArP/xu4LRADroSkvzdtANVq7115QDH25D3nwt8bG0zXgBVaQcEJbAUWP2letPgqABKIlij27KqhhWtDawruJYQujC6RlRM2olOORz31Fmg+An75HQZ1KJZrLeQEoeCj0kYnGzrvVTJJoqixph0=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 157322797097556.6022768166074;
 Fri, 8 Nov 2019 07:46:10 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-147-7PcLtCS6Pkq9v4WC1R9ieA-1; Fri, 08 Nov 2019 10:46:07 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7AF4E1800DFB;
	Fri,  8 Nov 2019 15:46:02 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 335A766D25;
	Fri,  8 Nov 2019 15:46:02 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id D7A264BB78;
	Fri,  8 Nov 2019 15:46:01 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8Fgafm014101 for ;
	Fri, 8 Nov 2019 10:42:36 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 8B6425D6B7; Fri,  8 Nov 2019 15:42:36 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E8CF95D6AE
	for ; Fri,  8 Nov 2019 15:42:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573227969;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=BHNIEZcCo3xEAwpWzMgAtbs1znaL80qgZIesq1Ii+e4=;
	b=W5NJJ3goY5C2yV5fQV1nJQcnuKPphdr1bZXfOvBS7a90jx1MoayW6zhqY8/UJ1/RcisgN2
	phOYu472eIz90zjkAbZFw+TxBC+HFPbpUbE0IsNJPO97LylF0UhQ30dpJG/WAb5W/QtH0o
	q/7ucARLMYKBY2GGn2P8s72UropTAIA=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:10 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 09/20] [ACKED] remote: unify rpc server
	dispatch generated files
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: 7PcLtCS6Pkq9v4WC1R9ieA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Our naming was not consistent.  Use the protocol name as prefix for all
generated files.

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - modify generated_files in for sc_po_check as well

 build-aux/syntax-check.mk           |  3 ++-
 src/remote/Makefile.inc.am          | 12 ++++++------
 src/remote/remote_daemon_dispatch.c |  4 ++--
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 75993ee284..156c72d452 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1976,7 +1976,8 @@ po_file ?=3D $(srcdir)/po/POTFILES.in
 generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
-  $(srcdir)/src/*/{remote_daemon,admin_server,log_daemon,lock_daemon}_disp=
atch_*stubs.h \
+  $(srcdir)/src/*/{remote,qemu,lxc,log,lock}_daemon_dispatch_stubs.h \
+  $(srcdir)/src/admin/admin_server_dispatch_stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/src/*/*_protocol.[ch] \
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 00f2212909..5c5f5f4d2c 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -20,8 +20,8 @@ REMOTE_DRIVER_SOURCES =3D \
=20
 REMOTE_DAEMON_GENERATED =3D \
 	remote/remote_daemon_dispatch_stubs.h \
-	remote/remote_daemon_dispatch_lxc_stubs.h \
-	remote/remote_daemon_dispatch_qemu_stubs.h \
+	remote/lxc_daemon_dispatch_stubs.h \
+	remote/qemu_daemon_dispatch_stubs.h \
 	$(NULL)
=20
 REMOTE_DAEMON_SOURCES =3D \
@@ -442,17 +442,17 @@ remote/remote_daemon_dispatch_stubs.h: $(srcdir)/rpc/=
gendispatch.pl \
 	  --mode=3Dserver remote REMOTE $(REMOTE_PROTOCOL) \
 	  > $(srcdir)/remote/remote_daemon_dispatch_stubs.h
=20
-remote/remote_daemon_dispatch_lxc_stubs.h: $(srcdir)/rpc/gendispatch.pl \
+remote/lxc_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(LXC_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \
 	  --mode=3Dserver lxc LXC $(LXC_PROTOCOL) \
-	  > $(srcdir)/remote/remote_daemon_dispatch_lxc_stubs.h
+	  > $(srcdir)/remote/lxc_daemon_dispatch_stubs.h
=20
-remote/remote_daemon_dispatch_qemu_stubs.h: $(srcdir)/rpc/gendispatch.pl \
+remote/qemu_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(QEMU_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \
 	  --mode=3Dserver qemu QEMU $(QEMU_PROTOCOL) \
-	  > $(srcdir)/remote/remote_daemon_dispatch_qemu_stubs.h
+	  > $(srcdir)/remote/qemu_daemon_dispatch_stubs.h
=20
 libvirtd.8.in: remote/libvirtd.pod
 	$(AM_V_GEN)$(POD2MAN) --section=3D8 $< $@-t1 && \
diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon=
_dispatch.c
index be20556128..66693ff7ae 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -131,8 +131,8 @@ remoteGetStorageConn(virNetServerClientPtr client);
=20
=20
 #include "remote_daemon_dispatch_stubs.h"
-#include "remote_daemon_dispatch_qemu_stubs.h"
-#include "remote_daemon_dispatch_lxc_stubs.h"
+#include "qemu_daemon_dispatch_stubs.h"
+#include "lxc_daemon_dispatch_stubs.h"
=20
=20
 /* Prototypes */
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228014; cv=none;
	d=zoho.com; s=zohoarc;
	b=bG4B6dP2eWDOYaZV7eTY+iLHvv6zGy9Z9sTd0pt7Xe5aKYpZP6zxGTQQyCD/PitVRSPAn1GTQMbdVePQ1CVNkxBWrk11gPzCIIANFdJGu7PeFU3XTn+6XCI4pU8lui4HHacZORtLxX6OJcZRiDCNNvFQJ9x2wFkroWLa6f3qx9g=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228014;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=XCQuva8qdDCmpSgaDSqxCosJ5YDy+d8m8GMYtECkjpo=;
	b=LzV4TqGrz4RVJrpJZFbwBziWxzWHHoMF6C9fLoVzVLxwPAh0QxD/z7DpYP9Tfeqo5QPwA6DjEH+FIviilDLd9Xojx3fp/OBvM1MSWX0yhTZs1KIvWmQxJrR9YyKRy/6Hsrv+QzLE1QvUPyjr81vdCzNPYI71JlOy+UhUY7PKDic=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 1573228014796989.3378812183197;
 Fri, 8 Nov 2019 07:46:54 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-154-8a95jbaYO--Oyl6d-b8IhA-1; Fri, 08 Nov 2019 10:46:51 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BC1D0801E54;
	Fri,  8 Nov 2019 15:46:46 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 93E1F5DA7F;
	Fri,  8 Nov 2019 15:46:46 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F6FF4E562;
	Fri,  8 Nov 2019 15:46:46 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgbjD014111 for ;
	Fri, 8 Nov 2019 10:42:37 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 86A815D6BB; Fri,  8 Nov 2019 15:42:37 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E70D05D6AE
	for ; Fri,  8 Nov 2019 15:42:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228013;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=XCQuva8qdDCmpSgaDSqxCosJ5YDy+d8m8GMYtECkjpo=;
	b=etOYvYi2S+g/l0SrJjUvZoZw57Xtgn76kwIIVYWEPlwq8IA62Fsg6VWjpbvalAWXMX88gV
	/QgQ7ZWzKhtGmBlGmH25LpUuK6fqTzOIkBMvniqmagIYMMnivqla/990M3vexgOrNUm/Ck
	i5y3gwkignaS98ab0T4IifxmZow5/W4=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:11 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 10/20] [ACKED] src: generate source files into
	build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-MC-Unique: 8a95jbaYO--Oyl6d-b8IhA-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

This affects more than src/Makefile.am as the rule to generate source
files for protocols is generic for all sub-directories.

Affected files are:
    src/admin/admin_protocol.{h,c}
    src/locking/lock_protocol.{h,c}
    src/logging/log_protocol.{h,c}
    src/lxc/lxc_monitor_protocol.{h,c}
    src/remote/{lxc,qemu,remote}_protocol.{h,c}
    src/rpc/{virkeepalive,virnet}protocol.{h,c}

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                  | 8 --------
 build-aux/syntax-check.mk   | 1 -
 src/Makefile.am             | 4 ++--
 src/admin/Makefile.inc.am   | 3 +++
 src/locking/Makefile.inc.am | 6 ++++++
 src/logging/Makefile.inc.am | 4 ++++
 src/lxc/Makefile.inc.am     | 4 ++++
 src/remote/Makefile.inc.am  | 4 ++++
 src/rpc/Makefile.inc.am     | 3 +++
 tests/Makefile.am           | 1 +
 10 files changed, 27 insertions(+), 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index 4c4807019c..6f8d59987e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -49,21 +49,13 @@ Makefile.in
 /src/access/viraccessapicheckqemu.c
 /src/access/viraccessapicheckqemu.h
 /src/admin/admin_client.h
-/src/admin/admin_protocol.[ch]
 /src/admin/admin_server_dispatch_stubs.h
 /src/esx/*.generated.*
 /src/hyperv/*.generated.*
 /src/locking/lock_daemon_dispatch_stubs.h
-/src/locking/lock_protocol.[ch]
 /src/logging/log_daemon_dispatch_stubs.h
-/src/logging/log_protocol.[ch]
 /src/lxc/lxc_controller_dispatch.h
 /src/lxc/lxc_monitor_dispatch.h
-/src/lxc/lxc_monitor_protocol.c
-/src/lxc/lxc_monitor_protocol.h
 /src/remote/*_client_bodies.h
-/src/remote/*_protocol.[ch]
 /src/remote/*_stubs.h
-/src/rpc/virkeepaliveprotocol.[ch]
-/src/rpc/virnetprotocol.[ch]
 tags
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 156c72d452..b83e98860d 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1980,7 +1980,6 @@ generated_files =3D \
   $(srcdir)/src/admin/admin_server_dispatch_stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
-  $(srcdir)/src/*/*_protocol.[ch] \
   $(srcdir)/gnulib/lib/*.[ch]
=20
 _gl_translatable_string_re ?=3D \b(N?_|gettext *)\([^)"]*("|$$)
diff --git a/src/Makefile.am b/src/Makefile.am
index e0b917fcdd..da7e2e6c80 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -394,11 +394,11 @@ GENERATED_SYM_FILES +=3D \
=20
 %protocol.c: %protocol.x %protocol.h $(srcdir)/rpc/genprotocol.pl
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/genprotocol.pl $(RPCGEN) -c \
-	       $< $(srcdir)/$(subst $(srcdir)/,,$@)
+	       $< $(subst $(srcdir)/,,$@)
=20
 %protocol.h: %protocol.x $(srcdir)/rpc/genprotocol.pl
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/genprotocol.pl $(RPCGEN) -h \
-	       $< $(srcdir)/$(subst $(srcdir)/,,$@)
+	       $< $(subst $(srcdir)/,,$@)
=20
 check-local: check-augeas
=20
diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index 4fd7878e5c..bea0967aaf 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -30,6 +30,7 @@ libvirt_driver_admin_la_CFLAGS =3D \
 	$(XDR_CFLAGS) \
 	-I$(top_srcdir)/src/util \
 	-I$(top_srcdir)/src/admin \
+	-I$(top_builddir)/src/rpc \
 	$(NULL)
 libvirt_driver_admin_la_LIBADD =3D ../gnulib/lib/libgnu.la
 libvirt_driver_admin_la_LDFLAGS =3D -module -avoid-version $(AM_LDFLAGS)
@@ -87,8 +88,10 @@ endif WITH_DTRACE_PROBES
=20
 libvirt_admin_la_CFLAGS =3D \
 	$(AM_CFLAGS) \
+	-I$(builddir)/admin \
 	-I$(srcdir)/remote \
 	-I$(srcdir)/rpc \
+	-I$(builddir)/rpc \
 	$(XDR_CFLAGS) \
 	$(CAPNG_CFLAGS) \
 	$(YAJL_CFLAGS) \
diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am
index 2b1c030041..ba7a9ea2ea 100644
--- a/src/locking/Makefile.inc.am
+++ b/src/locking/Makefile.inc.am
@@ -109,6 +109,9 @@ lockd_la_SOURCES =3D \
 	$(NULL)
 lockd_la_CFLAGS =3D \
 	-I$(srcdir)/conf \
+	-I$(srcdir)/locking \
+	-I$(builddir)/locking \
+	-I$(builddir)/rpc \
 	$(XDR_CFLAGS) \
 	$(AM_CFLAGS) \
 	$(NULL)
@@ -146,6 +149,9 @@ virtlockd_SOURCES =3D \
 	$(LOCK_DAEMON_GENERATED) \
 	$(NULL)
 virtlockd_CFLAGS =3D \
+	-I$(srcdir)/locking \
+	-I$(builddir)/locking \
+	-I$(builddir)/rpc \
 	$(AM_CFLAGS) \
 	$(PIE_CFLAGS) \
 	$(XDR_CFLAGS) \
diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am
index 7d10b646ea..bb7ea7338d 100644
--- a/src/logging/Makefile.inc.am
+++ b/src/logging/Makefile.inc.am
@@ -67,6 +67,8 @@ libvirt_driver_log_la_SOURCES =3D \
 	$(LOG_DRIVER_SOURCES) \
 	$(NULL)
 libvirt_driver_log_la_CFLAGS =3D \
+	-I$(builddir)/logging \
+	-I$(builddir)/rpc \
 	$(AM_CFLAGS) \
 	$(XDR_CFLAGS) \
 	$(NULL)
@@ -82,6 +84,8 @@ virtlogd_SOURCES =3D \
 		$(LOG_DAEMON_GENERATED) \
 		$(NULL)
 virtlogd_CFLAGS =3D \
+		-I$(builddir)/logging \
+		-I$(builddir)/rpc \
 		$(AM_CFLAGS) \
 		$(PIE_CFLAGS) \
 		$(XDR_CFLAGS) \
diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index b6db70af7d..78f14bf37a 100644
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -95,6 +95,8 @@ libvirt_driver_lxc_impl_la_CFLAGS =3D \
 	$(XDR_CFLAGS) \
 	-I$(srcdir)/access \
 	-I$(srcdir)/conf \
+	-I$(builddir)/lxc \
+	-I$(builddir)/rpc \
 	$(AM_CFLAGS) \
 	$(NULL)
 libvirt_driver_lxc_impl_la_LIBADD =3D \
@@ -199,6 +201,8 @@ endif WITH_DTRACE_PROBES
 libvirt_lxc_LDADD +=3D $(SECDRIVER_LIBS)
 libvirt_lxc_CFLAGS =3D \
 	-I$(srcdir)/conf \
+	-I$(builddir)/lxc \
+	-I$(builddir)/rpc \
 	$(AM_CFLAGS) \
 	$(PIE_CFLAGS) \
 	$(CAPNG_CFLAGS) \
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 5c5f5f4d2c..6b0ae586d1 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -50,6 +50,8 @@ REMOTE_DAEMON_CFLAGS =3D \
 	-I$(srcdir)/access \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/rpc \
+	-I$(builddir)/rpc \
+	-I$(builddir)/remote \
 	$(NULL)
=20
 REMOTE_DAEMON_LD_FLAGS =3D \
@@ -174,6 +176,8 @@ libvirt_driver_remote_la_CFLAGS =3D \
 	$(XDR_CFLAGS) \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/rpc \
+	-I$(builddir)/rpc \
+	-I$(builddir)/remote \
 	$(AM_CFLAGS) \
 	$(NULL)
 libvirt_driver_remote_la_LDFLAGS =3D $(AM_LDFLAGS)
diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am
index b8ca53c69a..4aa38db1ab 100644
--- a/src/rpc/Makefile.inc.am
+++ b/src/rpc/Makefile.inc.am
@@ -79,6 +79,7 @@ EXTRA_DIST +=3D \
 endif ! WITH_LIBSSH
=20
 libvirt_net_rpc_la_CFLAGS =3D \
+	-I$(builddir)/rpc \
 	$(GNUTLS_CFLAGS) \
 	$(SASL_CFLAGS) \
 	$(SSH2_CFLAGS) \
@@ -109,6 +110,7 @@ libvirt_net_rpc_server_la_SOURCES =3D \
 	rpc/virnetserver.c \
 	$(NULL)
 libvirt_net_rpc_server_la_CFLAGS =3D \
+	-I$(builddir)/rpc \
 	$(DBUS_CFLAGS) \
 	$(XDR_CFLAGS) \
 	$(SASL_CFLAGS) \
@@ -129,6 +131,7 @@ libvirt_net_rpc_client_la_SOURCES =3D \
 	rpc/virnetclient.c \
 	$(NULL)
 libvirt_net_rpc_client_la_CFLAGS =3D \
+	-I$(builddir)/rpc \
 	$(AM_CFLAGS) \
 	$(XDR_CFLAGS) \
 	$(NULL)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 10a309bd76..014d0ddd39 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -25,6 +25,7 @@ AM_CPPFLAGS =3D \
 	-I$(top_builddir)/src -I$(top_srcdir)/src \
 	-I$(top_srcdir)/src/util \
 	-I$(top_srcdir)/src/conf \
+	-I$(top_builddir)/src/rpc \
 	$(NULL)
=20
 WARN_CFLAGS +=3D $(RELAXED_FRAME_LIMIT_CFLAGS)
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228019; cv=none;
	d=zoho.com; s=zohoarc;
	b=cspwpBnIwDgeUIymu765DUcZk3T99drGfMa4qqBFIs649whW0Wls4kw/F1StpoxHH/E5c5midjkZRXUu0KOdKKf/JEwnkr5eYUo2IYgovgF/VbpOw3iYW6LKzQqRodeOCiGIPoBqqPngCjfRk+7LxMdKqsrdJ8IJiCEjn6498nc=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228019;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=Hw93YdjHl5sFrXIFQv/1OGnEBOoy7NdhMgmpJov2IrM=;
	b=PyTLrmTZiNSYLLgtZUKnGGyZA3HDzVyLqaMW1/zHXLuZ/yMucHLy2DFSAhgdEj2rNu+XweLgDln1DmKTDXeyWkU1TsSH3Sm2naQuc7ZDMtEiWLx9V1mz8CGYWMC7HL+uvJtZ2YAbpfDqLINbe9vVHMSqX4y4wIIkwBEz4z5tKGo=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573228019877471.6275709956084;
 Fri, 8 Nov 2019 07:46:59 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-335-ufBopixqO4WQXXu7UngavQ-1; Fri, 08 Nov 2019 10:46:57 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 31B881804974;
	Fri,  8 Nov 2019 15:46:50 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 06F7360856;
	Fri,  8 Nov 2019 15:46:50 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id AC09018005C1;
	Fri,  8 Nov 2019 15:46:49 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8Fgcdl014124 for ;
	Fri, 8 Nov 2019 10:42:38 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 7F3495D6B7; Fri,  8 Nov 2019 15:42:38 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E152A5D6AE
	for ; Fri,  8 Nov 2019 15:42:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228018;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=Hw93YdjHl5sFrXIFQv/1OGnEBOoy7NdhMgmpJov2IrM=;
	b=KLr2VtFfOuKnU9Wv6RwzJS3h5Bwk0yu+PsQrundPuy02RmpCZZq6CtD0nQg+fOrcIO6DuC
	k0DXYTJUZ3x2kQxR+3P0eCMfE9jh6QdjydLfH14NY+T0FP46k/w5UG87IxekWy0jDNBqTE
	rGM01ZQoTXPEZIh9ZkjYVmqh4IfOm08=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:12 +0100
Message-Id: 
 <53633f92ab7dc95718b0e03b4242cb3c39f0251e.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 11/20] [ACKED] src: access: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: ufBopixqO4WQXXu7UngavQ-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore

 .gitignore                      |  7 -------
 po/POTFILES.in                  |  3 +++
 src/access/Makefile.inc.am      | 14 +++++++-------
 src/admin/Makefile.inc.am       |  1 +
 src/interface/Makefile.inc.am   |  1 +
 src/libxl/Makefile.inc.am       |  1 +
 src/lxc/Makefile.inc.am         |  1 +
 src/network/Makefile.inc.am     |  1 +
 src/node_device/Makefile.inc.am |  1 +
 src/nwfilter/Makefile.inc.am    |  1 +
 src/qemu/Makefile.inc.am        |  1 +
 src/remote/Makefile.inc.am      |  1 +
 src/secret/Makefile.inc.am      |  1 +
 src/storage/Makefile.inc.am     |  1 +
 14 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/.gitignore b/.gitignore
index 6f8d59987e..8c1078c56c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,13 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/access/org.libvirt.api.policy
-/src/access/viraccessapicheck.c
-/src/access/viraccessapicheck.h
-/src/access/viraccessapichecklxc.c
-/src/access/viraccessapichecklxc.h
-/src/access/viraccessapicheckqemu.c
-/src/access/viraccessapicheckqemu.h
 /src/admin/admin_client.h
 /src/admin/admin_server_dispatch_stubs.h
 /src/esx/*.generated.*
diff --git a/po/POTFILES.in b/po/POTFILES.in
index a422d3659e..6f4bfeeb3d 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,3 +1,6 @@
+@BUILDDIR@/src/access/viraccessapicheck.c
+@BUILDDIR@/src/access/viraccessapichecklxc.c
+@BUILDDIR@/src/access/viraccessapicheckqemu.c
 @SRCDIR@/gnulib/lib/gai_strerror.c
 @SRCDIR@/gnulib/lib/regcomp.c
 @SRCDIR@/src/access/viraccessdriverpolkit.c
diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am
index ea27adbe0b..2d871ec8aa 100644
--- a/src/access/Makefile.inc.am
+++ b/src/access/Makefile.inc.am
@@ -38,7 +38,7 @@ ACCESS_DRIVER_POLKIT_SOURCES =3D \
 	access/viraccessdriverpolkit.c \
 	$(NULL)
=20
-ACCESS_DRIVER_POLKIT_POLICY =3D $(srcdir)/access/org.libvirt.api.policy
+ACCESS_DRIVER_POLKIT_POLICY =3D access/org.libvirt.api.policy
=20
 GENERATED_SYM_FILES +=3D $(ACCESS_DRIVER_SYM_FILES)
=20
@@ -122,31 +122,31 @@ access/viraccessapicheck.h: $(srcdir)/rpc/gendispatch=
.pl \
 			$(REMOTE_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclheader \
 	  remote REMOTE $(REMOTE_PROTOCOL) \
-	  > $(srcdir)/access/viraccessapicheck.h
+	  > access/viraccessapicheck.h
 access/viraccessapicheck.c: $(srcdir)/rpc/gendispatch.pl \
 			$(REMOTE_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclbody \
 	  remote REMOTE $(REMOTE_PROTOCOL) access/viraccessapicheck.h \
-	  > $(srcdir)/access/viraccessapicheck.c
+	  > access/viraccessapicheck.c
=20
 access/viraccessapicheckqemu.h: $(srcdir)/rpc/gendispatch.pl \
 			$(QEMU_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclheader \
 	  qemu QEMU $(QEMU_PROTOCOL) \
-	  > $(srcdir)/access/viraccessapicheckqemu.h
+	  > access/viraccessapicheckqemu.h
 access/viraccessapicheckqemu.c: $(srcdir)/rpc/gendispatch.pl \
 			$(QEMU_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclbody \
 	  qemu QEMU $(QEMU_PROTOCOL) access/viraccessapicheckqemu.h \
-	  > $(srcdir)/access/viraccessapicheckqemu.c
+	  > access/viraccessapicheckqemu.c
=20
 access/viraccessapichecklxc.h: $(srcdir)/rpc/gendispatch.pl \
 			$(LXC_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclheader \
 	  lxc LXC $(LXC_PROTOCOL) \
-	  > $(srcdir)/access/viraccessapichecklxc.h
+	  > access/viraccessapichecklxc.h
 access/viraccessapichecklxc.c: $(srcdir)/rpc/gendispatch.pl \
 			$(LXC_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Daclbody \
 	  lxc LXC $(LXC_PROTOCOL) access/viraccessapichecklxc.h \
-	  > $(srcdir)/access/viraccessapichecklxc.c
+	  > access/viraccessapichecklxc.c
diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index bea0967aaf..94cbed9972 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -89,6 +89,7 @@ endif WITH_DTRACE_PROBES
 libvirt_admin_la_CFLAGS =3D \
 	$(AM_CFLAGS) \
 	-I$(builddir)/admin \
+	-I$(builddir)/access \
 	-I$(srcdir)/remote \
 	-I$(srcdir)/rpc \
 	-I$(builddir)/rpc \
diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am
index 780b2277ba..30ea98ad15 100644
--- a/src/interface/Makefile.inc.am
+++ b/src/interface/Makefile.inc.am
@@ -21,6 +21,7 @@ if WITH_INTERFACE
 mod_LTLIBRARIES +=3D libvirt_driver_interface.la
 libvirt_driver_interface_la_CFLAGS =3D \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	$(AM_CFLAGS) \
 	$(LIBNL_CFLAGS) \
diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am
index ef8e9613f5..5d9cf14f7f 100644
--- a/src/libxl/Makefile.inc.am
+++ b/src/libxl/Makefile.inc.am
@@ -44,6 +44,7 @@ libvirt_driver_libxl_impl_la_CFLAGS =3D \
 	$(LIBXL_CFLAGS) \
 	$(LIBXML_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/secret \
 	$(AM_CFLAGS) \
diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index 78f14bf37a..f22a53e58d 100644
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -94,6 +94,7 @@ libvirt_driver_lxc_impl_la_CFLAGS =3D \
 	$(FUSE_CFLAGS) \
 	$(XDR_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	-I$(builddir)/lxc \
 	-I$(builddir)/rpc \
diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am
index b58b5ea645..2f7932ae60 100644
--- a/src/network/Makefile.inc.am
+++ b/src/network/Makefile.inc.am
@@ -44,6 +44,7 @@ libvirt_driver_network_impl_la_CFLAGS =3D \
 	$(LIBNL_CFLAGS) \
 	$(DBUS_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	$(AM_CFLAGS) \
 	$(NULL)
diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc=
.am
index 9b58636a0c..1dfa0a5274 100644
--- a/src/node_device/Makefile.inc.am
+++ b/src/node_device/Makefile.inc.am
@@ -39,6 +39,7 @@ libvirt_driver_nodedev_la_SOURCES =3D $(NODE_DEVICE_DRIVE=
R_SOURCES)
=20
 libvirt_driver_nodedev_la_CFLAGS =3D \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	$(AM_CFLAGS) \
 	$(LIBNL_CFLAGS) \
diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am
index e24e8aa2a0..ca05cba934 100644
--- a/src/nwfilter/Makefile.inc.am
+++ b/src/nwfilter/Makefile.inc.am
@@ -37,6 +37,7 @@ libvirt_driver_nwfilter_impl_la_CFLAGS =3D \
 	$(LIBNL_CFLAGS) \
 	$(DBUS_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	$(AM_CFLAGS) \
 	$(NULL)
diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
index 2074a5f54f..69e290c428 100644
--- a/src/qemu/Makefile.inc.am
+++ b/src/qemu/Makefile.inc.am
@@ -95,6 +95,7 @@ libvirt_driver_qemu_impl_la_CFLAGS =3D \
 	$(SELINUX_CFLAGS) \
 	$(XDR_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/secret \
 	$(AM_CFLAGS) \
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 6b0ae586d1..7361d02cf4 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -48,6 +48,7 @@ REMOTE_DAEMON_CFLAGS =3D \
 	$(PIE_CFLAGS) \
 	$(COVERAGE_CFLAGS) \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/rpc \
 	-I$(builddir)/rpc \
diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am
index fd7c90a137..94f293d418 100644
--- a/src/secret/Makefile.inc.am
+++ b/src/secret/Makefile.inc.am
@@ -28,6 +28,7 @@ if WITH_SECRETS
 mod_LTLIBRARIES +=3D libvirt_driver_secret.la
 libvirt_driver_secret_la_CFLAGS =3D \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	$(AM_CFLAGS) \
 	$(NULL)
diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am
index 08a9f4e86c..ec35ab7665 100644
--- a/src/storage/Makefile.inc.am
+++ b/src/storage/Makefile.inc.am
@@ -119,6 +119,7 @@ storagefile_LTLIBRARIES =3D
 libvirt_driver_storage_impl_la_SOURCES =3D
 libvirt_driver_storage_impl_la_CFLAGS =3D \
 	-I$(srcdir)/access \
+	-I$(builddir)/access \
 	-I$(srcdir)/conf \
 	-I$(srcdir)/secret \
 	$(AM_CFLAGS) \
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228049; cv=none;
	d=zoho.com; s=zohoarc;
	b=f0bGfuI4H7bHkJoihhh4isQJUG/wbRtmlH54ZyC8jz5aE1c1zfxUdQQtYYIEEYuLmFD76ofhxdhd6yd6N2hr5Gb9woVY52FybOlulHsdg2B/Pf1kTEbCZPcZBu+cDpNon99mqYuu5HDsCCjxvuBb0cOG+fsXCUXeSldMTrYF9o4=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228049;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=4biQaq2gFJqfQ9nkpmYHtPYRdPIxW0zvuIKEcDrhMD8=;
	b=QHenMZWFbatEzHCcP6W4p2Rdr6ZI30Kq/d/8sv1ExOpwR1uFlxDqi7ROEiIfBLlEsGC0vZDjTN7fmvjAuvY/mB82I20OowPqE9VpVlN+cBwNfw7epfb6QlTTAW3u1aReFlZFQmgfrdMf6z/YSV14/1KbGgHVv1vTACxoWbCGCR8=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 1573228049015141.86057808946066;
 Fri, 8 Nov 2019 07:47:29 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-78-0rhoVD7WOmycGl8NsD4MKg-1; Fri, 08 Nov 2019 10:47:25 -0500
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA038103;
	Fri,  8 Nov 2019 15:47:20 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A81AE60126;
	Fri,  8 Nov 2019 15:47:20 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5B8181819ACE;
	Fri,  8 Nov 2019 15:47:20 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgdBO014132 for ;
	Fri, 8 Nov 2019 10:42:39 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 802705D6D8; Fri,  8 Nov 2019 15:42:39 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E27145D6AE
	for ; Fri,  8 Nov 2019 15:42:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228047;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=4biQaq2gFJqfQ9nkpmYHtPYRdPIxW0zvuIKEcDrhMD8=;
	b=hzlHMRSeNJDoOfjSII7q5FWtLDqflhTHcsrBOoEPNnBxhyvQ9JmNrVxmWj+Qp/TFTjpRrP
	dg6moLiUAK9MmhWFc993j9fzQMdAGldSDGGt3MkTaGUIvazv4qgSAIpcdOe3uPrBNju8Ua
	8AXoWt01nujaV0xMqeiXAukZ3mBQQYU=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:13 +0100
Message-Id: 
 <61b8ffc6faf911599e96dcf371ae714e3c029334.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 12/20] [ACKED] src: admin: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-MC-Unique: 0rhoVD7WOmycGl8NsD4MKg-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                | 2 --
 build-aux/syntax-check.mk | 1 -
 po/POTFILES.in            | 3 ++-
 src/admin/Makefile.inc.am | 7 ++++---
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8c1078c56c..8989b3e3e3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,8 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/admin/admin_client.h
-/src/admin/admin_server_dispatch_stubs.h
 /src/esx/*.generated.*
 /src/hyperv/*.generated.*
 /src/locking/lock_daemon_dispatch_stubs.h
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index b83e98860d..cf60e890d2 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1977,7 +1977,6 @@ generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
   $(srcdir)/src/*/{remote,qemu,lxc,log,lock}_daemon_dispatch_stubs.h \
-  $(srcdir)/src/admin/admin_server_dispatch_stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/gnulib/lib/*.[ch]
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 6f4bfeeb3d..ebd86a6cd3 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,13 +1,14 @@
 @BUILDDIR@/src/access/viraccessapicheck.c
 @BUILDDIR@/src/access/viraccessapichecklxc.c
 @BUILDDIR@/src/access/viraccessapicheckqemu.c
+@BUILDDIR@/src/admin/admin_client.h
+@BUILDDIR@/src/admin/admin_server_dispatch_stubs.h
 @SRCDIR@/gnulib/lib/gai_strerror.c
 @SRCDIR@/gnulib/lib/regcomp.c
 @SRCDIR@/src/access/viraccessdriverpolkit.c
 @SRCDIR@/src/access/viraccessmanager.c
 @SRCDIR@/src/admin/admin_server.c
 @SRCDIR@/src/admin/admin_server_dispatch.c
-@SRCDIR@/src/admin/admin_server_dispatch_stubs.h
 @SRCDIR@/src/admin/libvirt-admin.c
 @SRCDIR@/src/bhyve/bhyve_capabilities.c
 @SRCDIR@/src/bhyve/bhyve_command.c
diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index 94cbed9972..448f7e1203 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -28,8 +28,9 @@ libvirt_driver_admin_la_SOURCES =3D \
 libvirt_driver_admin_la_CFLAGS =3D \
 	$(AM_CFLAGS) \
 	$(XDR_CFLAGS) \
-	-I$(top_srcdir)/src/util \
 	-I$(top_srcdir)/src/admin \
+	-I$(top_builddir)/src/admin \
+	-I$(top_srcdir)/src/util \
 	-I$(top_builddir)/src/rpc \
 	$(NULL)
 libvirt_driver_admin_la_LIBADD =3D ../gnulib/lib/libgnu.la
@@ -123,13 +124,13 @@ admin/admin_client.h: $(srcdir)/rpc/gendispatch.pl \
 		$(ADMIN_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \
 	  admin ADMIN $(ADMIN_PROTOCOL) \
-	  > $(srcdir)/admin/admin_client.h
+	  > admin/admin_client.h
=20
 admin/admin_server_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(ADMIN_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dserver \
 	  admin ADMIN $(ADMIN_PROTOCOL) \
-	  > $(srcdir)/admin/admin_server_dispatch_stubs.h
+	  > admin/admin_server_dispatch_stubs.h
=20
 admin/libvirt_admin.syms: admin/libvirt_admin_public.syms $(ADMIN_SYM_FILE=
S) \
 		$(top_builddir)/config.status
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228087; cv=none;
	d=zoho.com; s=zohoarc;
	b=k5vPGeV3dZOvSmIztQvZIAgeGZyqzW/+VG+fkLwwpriusP0wVLXgmQh3QvSfJ8hI8dqHNOBZfB05LB5sR9pi+2CRUuRm9BYUrAmLRD1UxLsLBGMGaioVBZuulgOekc/83lA/eDfs6qRhbGTX7Yxqxd9a27exjOPNJ6do5lgKqxk=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228087;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=bTSNOkQ1NlZGpXLh6+nZi0ywV94THR3CT9jKlGIzPnA=;
	b=Xrb2wLmB8PI2h9p7VSfvYN0GNoz7FAMdJNYUEyt9iSnPNwJdH+U5OJxp8z1KCIhfV9slRcubcJ0HwXnws5pHllJdd+m6a+xuSCR7IBbGpTKXdBXLTAQeRgUWomIT8jjItKRAIaPgsE672oCpGsrwBLUG0GsDWCHdnVkC8ILgML8=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 157322808725154.64192777494429;
 Fri, 8 Nov 2019 07:48:07 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-310-lqBry6g0Ppe-i_gYfEpQ-g-1; Fri, 08 Nov 2019 10:46:58 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96231103;
	Fri,  8 Nov 2019 15:46:53 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 741311A8D8;
	Fri,  8 Nov 2019 15:46:53 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3557C4E562;
	Fri,  8 Nov 2019 15:46:53 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgeQB014142 for ;
	Fri, 8 Nov 2019 10:42:40 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 846785D6AE; Fri,  8 Nov 2019 15:42:40 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E7E7A5D6BB
	for ; Fri,  8 Nov 2019 15:42:39 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228086;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=bTSNOkQ1NlZGpXLh6+nZi0ywV94THR3CT9jKlGIzPnA=;
	b=T1SaHcCmqhglkqjxUl+GbiQeFdwSz5fVcwAh2VOlUrJiFQjuyEti1wKvYKJNhD5vxZHnYy
	sou0UqIgAFaIl76/JFrj7qllAd24FFgQpuevqbscG1i3D558KK7AccSUwHqLYkuHn/ioaX
	dwBGzUm0zHIgCdPCSDINHShGFlTZXrk=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:14 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 13/20] [ACKED] src: esx: generate source files
	into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-MC-Unique: lqBry6g0Ppe-i_gYfEpQ-g-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore

 .gitignore                  |  1 -
 src/esx/Makefile.inc.am     |  5 +++--
 src/esx/esx_vi_generator.py | 11 ++++-------
 tests/Makefile.am           |  3 +++
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8989b3e3e3..46f6f98045 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,7 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/esx/*.generated.*
 /src/hyperv/*.generated.*
 /src/locking/lock_daemon_dispatch_stubs.h
 /src/logging/log_daemon_dispatch_stubs.h
diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am
index 3dab05d71c..7ba9fd1758 100644
--- a/src/esx/Makefile.inc.am
+++ b/src/esx/Makefile.inc.am
@@ -63,8 +63,8 @@ $(ESX_DRIVER_GENERATED): $(ESX_GENERATED_STAMP)
=20
 $(ESX_GENERATED_STAMP): $(srcdir)/esx/esx_vi_generator.input \
                          $(srcdir)/esx/esx_vi_generator.py
-	$(AM_V_GEN)srcdir=3D$(srcdir) $(RUNUTF8) $(PYTHON) \
-		$(srcdir)/esx/esx_vi_generator.py && touch $@
+	$(AM_V_GEN) $(RUNUTF8) $(PYTHON) \
+		$(srcdir)/esx/esx_vi_generator.py $(srcdir) $(builddir) && touch $@
=20
 MAINTAINERCLEANFILES +=3D $(ESX_DRIVER_GENERATED) $(ESX_GENERATED_STAMP)
=20
@@ -81,6 +81,7 @@ libvirt_la_BUILT_LIBADD +=3D libvirt_driver_esx.la
 libvirt_driver_esx_la_CFLAGS =3D \
 	$(CURL_CFLAGS) \
 	-I$(srcdir)/conf \
+	-I$(builddir)/esx \
 	-I$(srcdir)/vmx \
 	$(AM_CFLAGS) \
 	$(NULL)
diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 28d440a6df..c77de6e60c 100755
--- a/src/esx/esx_vi_generator.py
+++ b/src/esx/esx_vi_generator.py
@@ -1379,14 +1379,11 @@ additional_object_features =3D {
=20
 removed_object_features =3D {}
=20
+if len(sys.argv) !=3D 3:
+    report_error("usage: %s srcdir builddir" % sys.argv[0])
=20
-
-if "srcdir" in os.environ:
-    input_filename =3D os.path.join(os.environ["srcdir"], "esx/esx_vi_gene=
rator.input")
-    output_dirname =3D os.path.join(os.environ["srcdir"], "esx")
-else:
-    input_filename =3D os.path.join(os.getcwd(), "esx_vi_generator.input")
-    output_dirname =3D os.getcwd()
+input_filename =3D os.path.join(sys.argv[1], "esx/esx_vi_generator.input")
+output_dirname =3D os.path.join(sys.argv[2], "esx")
=20
=20
=20
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 014d0ddd39..9d9c582e42 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -756,6 +756,9 @@ esxutilstest_SOURCES =3D \
 	esxutilstest.c \
 	testutils.c testutils.h
 esxutilstest_LDADD =3D $(LDADDS)
+esxutilstest_CFLAGS =3D \
+	-I$(top_builddir)/src/esx \
+	$(AM_CFLAGS)
 else ! WITH_ESX
 EXTRA_DIST +=3D esxutilstest.c
 endif ! WITH_ESX
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573227978; cv=none;
	d=zoho.com; s=zohoarc;
	b=Kyft44OL8MZ17DfUiHh637SYE4NbhWZide7s3+jvaw5UhteIo/bMupCN0zqF2eHwVZZiHcy3Tl7zAPE21+YFP6y88BcJW5GcqTKz4OcevFXs+0HkpgvhwfkUTSj8yPkBKrZQan3sOg4Re0dEcil2q0rD96Wle/eZMhTQwywXgK0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573227978;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=njBzvfO2BVukKlC/vzzJoGD5rxGlYh2pk0lOE4Bppl4=;
	b=cY/dPs5HTKNh4G1+v1InRFcGgTIMQi609tihroRXVLjU/aK83C+7AhUI857mLpyxPBTVYXf0Sq8Rr7WWrnE7QbLYHr4apSerGd87g83P4+5yTEsGCF1yiikCw3HZooe4q4wBx8qxBfaktap4ZkEzXSCjXVREgd3FyZZJQuZ9Cwg=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573227978832990.5602747748674;
 Fri, 8 Nov 2019 07:46:18 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-63-s0egm9jqN9quldXZEbOozw-1; Fri, 08 Nov 2019 10:46:14 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53D65801E54;
	Fri,  8 Nov 2019 15:46:06 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F2905C299;
	Fri,  8 Nov 2019 15:46:06 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id DD2D418006D2;
	Fri,  8 Nov 2019 15:46:05 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8Fgf6W014153 for ;
	Fri, 8 Nov 2019 10:42:41 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 87C805D6B7; Fri,  8 Nov 2019 15:42:41 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E7FD45D6AE
	for ; Fri,  8 Nov 2019 15:42:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573227977;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=njBzvfO2BVukKlC/vzzJoGD5rxGlYh2pk0lOE4Bppl4=;
	b=g1tNBrozhcGA+65oXQ+JbHHm8WUGZ5+ubLomOpEo0ZKUVZxEhQIkPGasBrASPAwYnrk2So
	zwwLKECxZvcscoiPisYlglw44mCK4jCUxjP8N28hxzY2cTgJSsjxJYPqNC23sCkMjwNUMT
	ECKvm6NbdyFl5KHcC93LMmAZEbBSKio=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:15 +0100
Message-Id: 
 <11be65cda4307abdc7fd81668feb704ce702dfc8.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 14/20] [ACKED] src: hyperv: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-MC-Unique: s0egm9jqN9quldXZEbOozw-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore

 .gitignore                         |  1 -
 src/hyperv/Makefile.inc.am         |  5 +++--
 src/hyperv/hyperv_wmi_generator.py | 11 +++++------
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/.gitignore b/.gitignore
index 46f6f98045..85a417112d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,7 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/hyperv/*.generated.*
 /src/locking/lock_daemon_dispatch_stubs.h
 /src/logging/log_daemon_dispatch_stubs.h
 /src/lxc/lxc_controller_dispatch.h
diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am
index 6728b39c90..79e94d09bb 100644
--- a/src/hyperv/Makefile.inc.am
+++ b/src/hyperv/Makefile.inc.am
@@ -41,8 +41,8 @@ $(HYPERV_DRIVER_GENERATED): $(HYPERV_GENERATED_STAMP)
=20
 $(HYPERV_GENERATED_STAMP): $(srcdir)/hyperv/hyperv_wmi_generator.input \
                             $(srcdir)/hyperv/hyperv_wmi_generator.py
-	$(AM_V_GEN)srcdir=3D$(srcdir) $(RUNUTF8) $(PYTHON) \
-	  $(srcdir)/hyperv/hyperv_wmi_generator.py \
+	$(AM_V_GEN) $(RUNUTF8) $(PYTHON) \
+	  $(srcdir)/hyperv/hyperv_wmi_generator.py $(srcdir) $(builddir) \
 	  && touch $@
=20
 MAINTAINERCLEANFILES +=3D $(HYPERV_DRIVER_GENERATED) $(HYPERV_GENERATED_ST=
AMP)
@@ -53,6 +53,7 @@ libvirt_la_BUILT_LIBADD +=3D libvirt_driver_hyperv.la
 libvirt_driver_hyperv_la_CFLAGS =3D \
 	$(OPENWSMAN_CFLAGS) \
 	-I$(srcdir)/conf \
+	-I$(builddir)/hyperv \
 	$(AM_CFLAGS) \
 	$(NULL)
 libvirt_driver_hyperv_la_LDFLAGS =3D $(AM_LDFLAGS)
diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_gen=
erator.py
index a9ece0ff00..c3cd39cc76 100755
--- a/src/hyperv/hyperv_wmi_generator.py
+++ b/src/hyperv/hyperv_wmi_generator.py
@@ -454,12 +454,11 @@ def parse_class(block):
=20
=20
 def main():
-    if "srcdir" in os.environ:
-        input_filename =3D os.path.join(os.environ["srcdir"], "hyperv/hype=
rv_wmi_generator.input")
-        output_dirname =3D os.path.join(os.environ["srcdir"], "hyperv")
-    else:
-        input_filename =3D os.path.join(os.getcwd(), "hyperv_wmi_generator=
.input")
-        output_dirname =3D os.getcwd()
+    if len(sys.argv) !=3D 3:
+        report_error("usage: %s srcdir builddir" % sys.argv[0])
+
+    input_filename =3D os.path.join(sys.argv[1], "hyperv", "hyperv_wmi_gen=
erator.input")
+    output_dirname =3D os.path.join(sys.argv[2], "hyperv")
=20
     classes_typedef =3D open_and_print(os.path.join(output_dirname, "hyper=
v_wmi_classes.generated.typedef"))
     classes_header =3D open_and_print(os.path.join(output_dirname, "hyperv=
_wmi_classes.generated.h"))
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender) client-ip=207.211.31.81;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228086; cv=none;
	d=zoho.com; s=zohoarc;
	b=U/fAG6uJQMmzXmuFpvCgmnfYlsf3vHxVlQrNUhm9Tk44939YDLH8MWOb0AlD+BiwFeTYoNK/GAeTDZnph+ZQJZCCW698pBJRaU8YLCrjW0KKSXsO6J57ffv7h5xMMQdhbe/JgH2rkOg6q1Bm9oDaOaxTevbu5qwzw8GE7n640y8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228086;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=p/o6y2apUUnqaTgJLB6ht8ASTtvItqut/fWebzgxm/M=;
	b=ej0gFa/S1HYPC28eK/H124gGUTiXvm3NMpUQ18pp0UFL2RJqqagRndCqTzzQW1IYxqDLs29xFemv8fRm+AfCGFywI/OXftBIyDSKHeeN5OPWkFS7+xoq7PsS0FGbm3R/yl8mu5SpdJIyl6VMm8QAH5qK1JRtU2yNCAMHXjsHjJk=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
 [207.211.31.81]) by mx.zohomail.com
	with SMTPS id 1573228086396317.93057387003955;
 Fri, 8 Nov 2019 07:48:06 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-288-zMTbAaOVNs6da-_kuMLkEw-1; Fri, 08 Nov 2019 10:47:03 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B18B107ACC8;
	Fri,  8 Nov 2019 15:46:57 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 056E3608B3;
	Fri,  8 Nov 2019 15:46:57 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id B675F18005C3;
	Fri,  8 Nov 2019 15:46:56 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8Fgj99014180 for ;
	Fri, 8 Nov 2019 10:42:45 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 3A4745D6B7; Fri,  8 Nov 2019 15:42:45 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 8E5F15D6AE
	for ; Fri,  8 Nov 2019 15:42:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228085;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=p/o6y2apUUnqaTgJLB6ht8ASTtvItqut/fWebzgxm/M=;
	b=VtV1SxQAMcv9SwWsfTiJZNgQYTP/Zb2k9lYTQyTZaROXXP2jVVAUZpx/lV4OAgjjoSeFgp
	3UmHzCe9eBtY/8NxpvS18NvXz8zb/oxsw9bfe0ObzQxgmXAF7MhKmG7CrUZt6jEL6A/xKk
	94gdPA8jqYUPMInwQXfcnWq5576H5SI=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:16 +0100
Message-Id: 
 <1f579be07a58c060ba7621bc6eff6755f80377a2.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 15/20] [ACKED] src: locking: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: zMTbAaOVNs6da-_kuMLkEw-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                  | 1 -
 build-aux/syntax-check.mk   | 2 +-
 src/locking/Makefile.inc.am | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 85a417112d..ed11b77921 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,7 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/locking/lock_daemon_dispatch_stubs.h
 /src/logging/log_daemon_dispatch_stubs.h
 /src/lxc/lxc_controller_dispatch.h
 /src/lxc/lxc_monitor_dispatch.h
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index cf60e890d2..62fe528c75 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1976,7 +1976,7 @@ po_file ?=3D $(srcdir)/po/POTFILES.in
 generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
-  $(srcdir)/src/*/{remote,qemu,lxc,log,lock}_daemon_dispatch_stubs.h \
+  $(srcdir)/src/*/{remote,qemu,lxc,log}_daemon_dispatch_stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/gnulib/lib/*.[ch]
diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am
index ba7a9ea2ea..2bfb662016 100644
--- a/src/locking/Makefile.inc.am
+++ b/src/locking/Makefile.inc.am
@@ -280,7 +280,7 @@ locking/lock_daemon_dispatch_stubs.h: $(LOCK_PROTOCOL) \
 		$(srcdir)/rpc/gendispatch.pl Makefile.am
 	$(AM_V_GEN)perl -w $(srcdir)/rpc/gendispatch.pl --mode=3Dserver \
 	    virLockSpaceProtocol VIR_LOCK_SPACE_PROTOCOL \
-	    $(LOCK_PROTOCOL) > $(srcdir)/locking/lock_daemon_dispatch_stubs.h
+	    $(LOCK_PROTOCOL) > locking/lock_daemon_dispatch_stubs.h
=20
=20
 virtlockd.service: locking/virtlockd.service.in $(top_builddir)/config.sta=
tus
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228055; cv=none;
	d=zoho.com; s=zohoarc;
	b=WfAAieDgxKnWC1q75GXNKLfIWOQ12/njZeX9clXsqsWDyYHEZJFAW+2OuP+9PYtXmFzsUj43ZQM4AGxeU6mwvZi1SDQqvMALiXWOvVonCbjLD1wZqu2xiznuocqdYusEd1bRn+H3pgAQNxsQveaHikSiTZobnBdNnRmZdjUPouo=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228055;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=FbQx2YTeQczRUSqAsFzie53rTwyDBFcPJSwGBxNk3cw=;
	b=TVCh85CnbHwSxvuLN1me2lf9zsTQNui4BWaRWn2Y4hHp+QtayApo52N8imVd97XbvsGxNPnpLAfDLqaEi20+M/7uQBH+zYXr5SiPFSoSKa0fGF00pCT9f5KzHFA4cgqvj8oxsgefJg+aL62Shtb4k1C3k40e8a9S7o682q+YcjI=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 1573228055459224.40017574337253;
 Fri, 8 Nov 2019 07:47:35 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-28-_SSKd5z1MeKf-ZsfE3q_mQ-1; Fri, 08 Nov 2019 10:47:32 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61789800A1A;
	Fri,  8 Nov 2019 15:47:25 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D4BB50;
	Fri,  8 Nov 2019 15:47:25 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id CBD264E574;
	Fri,  8 Nov 2019 15:47:24 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgkK1014185 for ;
	Fri, 8 Nov 2019 10:42:46 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 479375D6B7; Fri,  8 Nov 2019 15:42:46 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id A902E5D6BB
	for ; Fri,  8 Nov 2019 15:42:45 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228054;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=FbQx2YTeQczRUSqAsFzie53rTwyDBFcPJSwGBxNk3cw=;
	b=drmq+exQw/MzMZBZUuyM2RncgW5mpVpyax2HInq/Xnaz3nN6hkqcbay8/JMU+JDOJ/T2Ix
	1ytL1ATDRgZHfeopfPMnCpixoWEz3wP0FEXIW3bTfFakBlAcAOBZGMm9nI3NgJ+I+x0nQM
	WbYHdGLGaZDftXDPpKo9MDOS7MHBjAw=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:17 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 16/20] [ACKED] src: logging: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-MC-Unique: _SSKd5z1MeKf-ZsfE3q_mQ-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                  | 1 -
 build-aux/syntax-check.mk   | 2 +-
 src/logging/Makefile.inc.am | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index ed11b77921..eaad5a1883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,7 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/logging/log_daemon_dispatch_stubs.h
 /src/lxc/lxc_controller_dispatch.h
 /src/lxc/lxc_monitor_dispatch.h
 /src/remote/*_client_bodies.h
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 62fe528c75..a7e87e7a81 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1976,7 +1976,7 @@ po_file ?=3D $(srcdir)/po/POTFILES.in
 generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
-  $(srcdir)/src/*/{remote,qemu,lxc,log}_daemon_dispatch_stubs.h \
+  $(srcdir)/src/*/{remote,qemu,lxc}_daemon_dispatch_stubs.h \
   $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/gnulib/lib/*.[ch]
diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am
index bb7ea7338d..dbaac2bb0d 100644
--- a/src/logging/Makefile.inc.am
+++ b/src/logging/Makefile.inc.am
@@ -127,7 +127,7 @@ logging/log_daemon_dispatch_stubs.h: $(LOG_PROTOCOL) \
 		$(srcdir)/rpc/gendispatch.pl Makefile.am
 	$(AM_V_GEN)perl -w $(srcdir)/rpc/gendispatch.pl --mode=3Dserver \
 	    virLogManagerProtocol VIR_LOG_MANAGER_PROTOCOL \
-	    $(LOG_PROTOCOL) > $(srcdir)/logging/log_daemon_dispatch_stubs.h
+	    $(LOG_PROTOCOL) > logging/log_daemon_dispatch_stubs.h
=20
 virtlogd.8.in: logging/virtlogd.pod
 	$(AM_V_GEN)$(POD2MAN) --section=3D8 $< $@-t1 && \
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender) client-ip=207.211.31.81;
 envelope-from=libvir-list-bounces@redhat.com;
 helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228026; cv=none;
	d=zoho.com; s=zohoarc;
	b=lfj5Hv4EKH6G3DNbGAy/z7CKmmt0mpwkRO5yPJ7jQbS10GDpohnIp9LyhuvrTUBFP0eGOweT+lS79hh4vqNQdYBhCI3TqEFZFqt2pDkxmjJLVhIAnVW092BoU2lRSU+XK7Ujd8u3stomr7g1vskTSuzX8I3cSNDfUOjuf6VILbg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228026;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=t++X6tJ1YZ+T3+BXYiwS+csFXz4b6EvSGlu0DCG/6Hg=;
	b=H2duLkZxvwmBHjN+DxY1jJ+iXUiW3tDadpUHieXAUV3iX5MsLPpJdHa8hz2WoHggi3h4DTtZEISl23TLYcFE/kL0Oz21AkOEDCbbOC1HUs7l7WriHg+IWoy37gQL1fds5Zs4Nc0UuP8pEuoWrkRBFB5Z6AaHu6kYAjL/BdBt0nM=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.81 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
 [207.211.31.81]) by mx.zohomail.com
	with SMTPS id 1573228026931978.5656572127093;
 Fri, 8 Nov 2019 07:47:06 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-364-12bkmqFnNo-AME3gmPw8fQ-1; Fri, 08 Nov 2019 10:46:15 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD068808245;
	Fri,  8 Nov 2019 15:46:09 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id A67E55DA81;
	Fri,  8 Nov 2019 15:46:09 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6108718006D2;
	Fri,  8 Nov 2019 15:46:09 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FglKv014195 for ;
	Fri, 8 Nov 2019 10:42:47 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 40CD15D6B7; Fri,  8 Nov 2019 15:42:47 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id A37515D6BB
	for ; Fri,  8 Nov 2019 15:42:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228025;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=t++X6tJ1YZ+T3+BXYiwS+csFXz4b6EvSGlu0DCG/6Hg=;
	b=LdtylndwaA/8DzPOiEnYyTDe51yRFZBs6JStI00PHyirFbKky+EC7XBETtLcSWqpvX3kSd
	RL40Lp/2VghH/hfLaiR9bRJwxD0MePN1no8Xl+QoVCngg6zzZzy0InI5qODhaUh6oDkCVb
	HMZHvuPfzl63Qem/ZbNSyYQ+Gth1k+Y=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:18 +0100
Message-Id: 
 <0e5ab32bce82a1620fb1bd4a08ac5462d17c80e7.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 17/20] [ACKED] src: lxc: generate source files
	into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-MC-Unique: 12bkmqFnNo-AME3gmPw8fQ-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                | 2 --
 build-aux/syntax-check.mk | 1 -
 src/lxc/Makefile.inc.am   | 4 ++--
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/.gitignore b/.gitignore
index eaad5a1883..38d6637c1c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,8 +41,6 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/lxc/lxc_controller_dispatch.h
-/src/lxc/lxc_monitor_dispatch.h
 /src/remote/*_client_bodies.h
 /src/remote/*_stubs.h
 tags
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index a7e87e7a81..392fc34320 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1977,7 +1977,6 @@ generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
   $(srcdir)/src/*/{remote,qemu,lxc}_daemon_dispatch_stubs.h \
-  $(srcdir)/src/lxc/{lxc_monitor,lxc_controller}_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/gnulib/lib/*.[ch]
=20
diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index f22a53e58d..cb55dfd1c6 100644
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -252,13 +252,13 @@ lxc/lxc_monitor_dispatch.h: $(srcdir)/rpc/gendispatch=
.pl \
 		$(LXC_MONITOR_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \
 	  virLXCMonitor VIR_LXC_MONITOR $(LXC_MONITOR_PROTOCOL) > \
-	  $(srcdir)/lxc/lxc_monitor_dispatch.h
+	  lxc/lxc_monitor_dispatch.h
=20
 lxc/lxc_controller_dispatch.h: $(srcdir)/rpc/gendispatch.pl \
 		$(REMOTE_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dserver \
 	  virLXCMonitor VIR_LXC_MONITOR $(LXC_MONITOR_PROTOCOL) > \
-	  $(srcdir)/lxc/lxc_controller_dispatch.h
+	  lxc/lxc_controller_dispatch.h
=20
 .PHONY: \
 	install-data-lxc \
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 207.211.31.120
 as permitted sender) client-ip=207.211.31.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228037; cv=none;
	d=zoho.com; s=zohoarc;
	b=TDr9J+3RDK/H5pF/0S4hUEb7UWRvJ6avUrIM1wGwIz7K4rqsRgsZkOEIqneBnu06mymwVDsdUjFsxQ9YnTWFQaIAhym6fLtOZY+8n4hXuraMgjOr55sUlFmt0hf+7RUPSb2HZGxLNLhPrHMx1BXhMUzFxQZIg4WorKtSm/Sm9CM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228037;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=w96KYaqzGI2g8pkLJqXEyWOgANawPRSkg+pssdhKQro=;
	b=T3wRJ1SkEirQvUMhU+Bwk55y3o3IwiFBoR7wNArKNm/QTknK16xXJdihpM+Wxxev5s5kvVbeE6BnHdKBMnbEW6Nx+lXCfgczi+9+w6hgIsPaJhOLeBFP0CGOjXuUwPpVQQLt9Zb9N2/bCp2qcxmW2Qgu7XEe7MrbF0LICERa8lQ=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 207.211.31.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [207.211.31.120]) by mx.zohomail.com
	with SMTPS id 1573228037565621.5508126915829;
 Fri, 8 Nov 2019 07:47:17 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-325-40dCc2a4Mcy0EhPJFQ3wmg-1; Fri, 08 Nov 2019 10:46:18 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 686AF102;
	Fri,  8 Nov 2019 15:46:13 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F4963CC6;
	Fri,  8 Nov 2019 15:46:13 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 039C018005C0;
	Fri,  8 Nov 2019 15:46:13 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgmGj014205 for ;
	Fri, 8 Nov 2019 10:42:48 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 5C28F5D6D8; Fri,  8 Nov 2019 15:42:48 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id A3A315D6B7
	for ; Fri,  8 Nov 2019 15:42:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228036;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=w96KYaqzGI2g8pkLJqXEyWOgANawPRSkg+pssdhKQro=;
	b=ahlhWnCWf61u+T0RxZIUR7AgzZEfZ4jGBVRJEIH6Cvig8GT5JwQjXTG4IY/NI+LdQHz3Ax
	i2LKpcSEJZtjCwFxUZEjVngN2Gk1DA5/RW9ZC46RzEoEp4JpfCDtNEO3Cp11OQznUlYr/F
	6RsEa9BmzuN9NkMyf0dKE7WOegnzlWs=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:19 +0100
Message-Id: 
 <9bdfd56da3fd79ef6d059ea7e3fd63c1a66d38b5.1573227570.git.phrdina@redhat.com>
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 18/20] [ACKED] src: remote: generate source
	files into build directory
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-MC-Unique: 40dCc2a4Mcy0EhPJFQ3wmg-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---

Notes:
    Changes in v2:
        - remove entries from .gitignore
        - modify generated_files for sc_po_check as well

 .gitignore                 |  2 --
 build-aux/syntax-check.mk  |  2 --
 po/POTFILES.in             |  4 ++--
 src/remote/Makefile.inc.am | 12 ++++++------
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/.gitignore b/.gitignore
index 38d6637c1c..2d6e3e3194 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,6 +41,4 @@ Makefile.in
 # libvirt related ignores
 /build/
 /ci/scratch/
-/src/remote/*_client_bodies.h
-/src/remote/*_stubs.h
 tags
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 392fc34320..ab9ba33c9c 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1976,8 +1976,6 @@ po_file ?=3D $(srcdir)/po/POTFILES.in
 generated_files =3D \
   $(builddir)/src/*.[ch] \
   $(builddir)/src/*/*.[ch] \
-  $(srcdir)/src/*/{remote,qemu,lxc}_daemon_dispatch_stubs.h \
-  $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/gnulib/lib/*.[ch]
=20
 _gl_translatable_string_re ?=3D \b(N?_|gettext *)\([^)"]*("|$$)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index ebd86a6cd3..de6e5ec0d9 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -3,6 +3,8 @@
 @BUILDDIR@/src/access/viraccessapicheckqemu.c
 @BUILDDIR@/src/admin/admin_client.h
 @BUILDDIR@/src/admin/admin_server_dispatch_stubs.h
+@BUILDDIR@/src/remote/remote_client_bodies.h
+@BUILDDIR@/src/remote/remote_daemon_dispatch_stubs.h
 @SRCDIR@/gnulib/lib/gai_strerror.c
 @SRCDIR@/gnulib/lib/regcomp.c
 @SRCDIR@/src/access/viraccessdriverpolkit.c
@@ -167,11 +169,9 @@
 @SRCDIR@/src/qemu/qemu_tpm.c
 @SRCDIR@/src/qemu/qemu_vhost_user.c
 @SRCDIR@/src/qemu/qemu_vhost_user_gpu.c
-@SRCDIR@/src/remote/remote_client_bodies.h
 @SRCDIR@/src/remote/remote_daemon.c
 @SRCDIR@/src/remote/remote_daemon_config.c
 @SRCDIR@/src/remote/remote_daemon_dispatch.c
-@SRCDIR@/src/remote/remote_daemon_dispatch_stubs.h
 @SRCDIR@/src/remote/remote_daemon_stream.c
 @SRCDIR@/src/remote/remote_driver.c
 @SRCDIR@/src/rpc/virkeepalive.c
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 7361d02cf4..242eb3ed2d 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -427,37 +427,37 @@ remote/remote_client_bodies.h: $(srcdir)/rpc/gendispa=
tch.pl \
 		$(REMOTE_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \
 	  remote REMOTE $(REMOTE_PROTOCOL) \
-	  > $(srcdir)/remote/remote_client_bodies.h
+	  > remote/remote_client_bodies.h
=20
 remote/lxc_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \
 		$(LXC_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \
 	  lxc LXC $(LXC_PROTOCOL) \
-	  > $(srcdir)/remote/lxc_client_bodies.h
+	  > remote/lxc_client_bodies.h
=20
 remote/qemu_client_bodies.h: $(srcdir)/rpc/gendispatch.pl \
 		$(QEMU_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(srcdir)/rpc/gendispatch.pl --mode=3Dclient \
 	  qemu QEMU $(QEMU_PROTOCOL) \
-	  > $(srcdir)/remote/qemu_client_bodies.h
+	  > remote/qemu_client_bodies.h
=20
 remote/remote_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(REMOTE_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \
 	  --mode=3Dserver remote REMOTE $(REMOTE_PROTOCOL) \
-	  > $(srcdir)/remote/remote_daemon_dispatch_stubs.h
+	  > remote/remote_daemon_dispatch_stubs.h
=20
 remote/lxc_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(LXC_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \
 	  --mode=3Dserver lxc LXC $(LXC_PROTOCOL) \
-	  > $(srcdir)/remote/lxc_daemon_dispatch_stubs.h
+	  > remote/lxc_daemon_dispatch_stubs.h
=20
 remote/qemu_daemon_dispatch_stubs.h: $(srcdir)/rpc/gendispatch.pl \
 		$(QEMU_PROTOCOL) Makefile.am
 	$(AM_V_GEN)$(PERL) -w $(top_srcdir)/src/rpc/gendispatch.pl \
 	  --mode=3Dserver qemu QEMU $(QEMU_PROTOCOL) \
-	  > $(srcdir)/remote/qemu_daemon_dispatch_stubs.h
+	  > remote/qemu_daemon_dispatch_stubs.h
=20
 libvirtd.8.in: remote/libvirtd.pod
 	$(AM_V_GEN)$(POD2MAN) --section=3D8 $< $@-t1 && \
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228084; cv=none;
	d=zoho.com; s=zohoarc;
	b=EZzp2GGEauBAN9yxQ6Mr/7Nn7A7L2FUyHcA1w/OMPXvf+7r53pE4lOzoEwvF700xBpROnMQ2LGyKOXavE4sVsGExs4fHwBUJHUlh8CsehXwjjWYCguJXcLRGo7aRjVzoSporXsUsG87FEpuB/Rufu182Q8RD24vn2AHQi0wKWyU=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228084;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=veDirJ5K09qPbUFYx6WQS7SROj89/FHjplQM9wpgcsA=;
	b=FEkKUPaV9BFYDL1lErZpCwqJkurVrQDpxMUSp3Qtre3p2uDgoOmG4JDe+FJ70W4yuc+2yB7cExT4qX293fUP8dX/vltaP+M/mAT98dh55NnZhxk8EFG86HB5gqHjIxFO14MImQvvuYr9FyzKSoqsT1A1gqj8YVTX9CiXvLw1hHE=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 1573228084288811.8368325982927;
 Fri, 8 Nov 2019 07:48:04 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-345-aVaSyajWPEewmo48Hkg06g-1; Fri, 08 Nov 2019 10:47:34 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 09D17800686;
	Fri,  8 Nov 2019 15:47:29 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D5F6F608B3;
	Fri,  8 Nov 2019 15:47:28 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id 925411819AD1;
	Fri,  8 Nov 2019 15:47:28 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgoUY014221 for ;
	Fri, 8 Nov 2019 10:42:50 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 118DB5D713; Fri,  8 Nov 2019 15:42:50 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 06F255D6B7
	for ; Fri,  8 Nov 2019 15:42:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228082;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=veDirJ5K09qPbUFYx6WQS7SROj89/FHjplQM9wpgcsA=;
	b=bGMfibf61S5bd823rpjDrluT/cVfj90yi8fq3HY4wspHzD98LKO+Fd9wWURCuGos8p4AOx
	YYV+inL1fpJgxniMcLUUe4cvdnkFOnFZi04Q4lfk9E0da4vLsbbWBEQ4AIlALwD/Td8Bsp
	kqXvTX2XNyDfns2CqzXntfVVJccxUfE=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:20 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 19/20] [ACKED] src: stop distributing generated
	source files
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: aVaSyajWPEewmo48Hkg06g-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---
 src/Makefile.am                 |  6 +++---
 src/access/Makefile.inc.am      |  3 ++-
 src/admin/Makefile.inc.am       | 13 +++++++------
 src/bhyve/Makefile.inc.am       |  1 +
 src/esx/Makefile.inc.am         |  4 +---
 src/hyperv/Makefile.inc.am      |  4 +---
 src/interface/Makefile.inc.am   |  1 +
 src/libxl/Makefile.inc.am       |  1 +
 src/locking/Makefile.inc.am     |  8 +++++---
 src/logging/Makefile.inc.am     | 12 +++++++-----
 src/lxc/Makefile.inc.am         | 27 ++++++++++++++++++---------
 src/network/Makefile.inc.am     |  1 +
 src/node_device/Makefile.inc.am |  1 +
 src/nwfilter/Makefile.inc.am    |  1 +
 src/qemu/Makefile.inc.am        |  1 +
 src/remote/Makefile.inc.am      | 20 ++++++++++++--------
 src/rpc/Makefile.inc.am         |  5 ++++-
 src/secret/Makefile.inc.am      |  1 +
 src/storage/Makefile.inc.am     |  1 +
 src/util/Makefile.inc.am        |  6 ++++--
 src/vbox/Makefile.inc.am        |  1 +
 src/vz/Makefile.inc.am          |  1 +
 22 files changed, 75 insertions(+), 44 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index da7e2e6c80..4a0c121a7d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -655,13 +655,13 @@ endif WITH_LIBVIRTD
 		< $< > $@-t && \
 	mv $@-t $@
=20
-CLEANFILES +=3D $(man8_MANS)
-MAINTAINERCLEANFILES +=3D $(MANINFILES)
+CLEANFILES +=3D \
+	$(man8_MANS) \
+	$(MANINFILES)
=20
 EXTRA_DIST +=3D \
         $(SYSTEMD_UNIT_FILES_IN) \
         $(PODFILES) \
-        $(MANINFILES) \
         $(NULL)
=20
=20
diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am
index 2d871ec8aa..fd0a5d8098 100644
--- a/src/access/Makefile.inc.am
+++ b/src/access/Makefile.inc.am
@@ -43,13 +43,14 @@ ACCESS_DRIVER_POLKIT_POLICY =3D access/org.libvirt.api.=
policy
 GENERATED_SYM_FILES +=3D $(ACCESS_DRIVER_SYM_FILES)
=20
 EXTRA_DIST +=3D \
-	$(ACCESS_DRIVER_POLKIT_POLICY) \
 	access/genpolkit.pl \
 	$(NULL)
=20
=20
 libvirt_driver_access_la_SOURCES =3D \
 	$(ACCESS_DRIVER_SOURCES) \
+	$(NULL)
+nodist_libvirt_driver_access_la_SOURCES =3D \
 	$(ACCESS_DRIVER_GENERATED) \
 	$(NULL)
 noinst_LTLIBRARIES +=3D libvirt_driver_access.la
diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am
index 448f7e1203..3feb23aa20 100644
--- a/src/admin/Makefile.inc.am
+++ b/src/admin/Makefile.inc.am
@@ -9,22 +9,21 @@ ADMIN_PROTOCOL_GENERATED =3D \
 	admin/admin_server_dispatch_stubs.h \
 	$(NULL)
=20
-EXTRA_DIST +=3D $(ADMIN_PROTOCOL) $(ADMIN_PROTOCOL_GENERATED)
+EXTRA_DIST +=3D $(ADMIN_PROTOCOL)
 BUILT_SOURCES +=3D $(ADMIN_PROTOCOL_GENERATED)
-MAINTAINERCLEANFILES +=3D $(ADMIN_PROTOCOL_GENERATED)
+CLEANFILES +=3D $(ADMIN_PROTOCOL_GENERATED)
=20
 admin/admin_server_dispatch.c: admin/admin_server_dispatch_stubs.h
=20
 noinst_LTLIBRARIES +=3D libvirt_driver_admin.la
 libvirt_driver_admin_la_SOURCES =3D \
-	admin/admin_protocol.c \
-	admin/admin_protocol.h \
 	admin/admin_server.c \
 	admin/admin_server.h \
 	admin/admin_server_dispatch.c \
 	admin/admin_server_dispatch.h \
-	admin/admin_server_dispatch_stubs.h \
 	$(NULL)
+nodist_libvirt_driver_admin_la_SOURCES =3D \
+	$(ADMIN_PROTOCOL_GENERATED)
 libvirt_driver_admin_la_CFLAGS =3D \
 	$(AM_CFLAGS) \
 	$(XDR_CFLAGS) \
@@ -60,9 +59,11 @@ lib_LTLIBRARIES +=3D libvirt-admin.la
=20
 libvirt_admin_la_SOURCES =3D \
 	admin/libvirt-admin.c \
-	$(ADMIN_PROTOCOL_GENERATED) \
 	$(DATATYPES_SOURCES)
=20
+nodist_libvirt_admin_la_SOURCES =3D \
+	$(ADMIN_PROTOCOL_GENERATED)
+
 libvirt_admin_la_LDFLAGS =3D \
 	$(VERSION_SCRIPT_FLAGS)$(LIBVIRT_ADMIN_SYMBOL_FILE) \
 	-version-info $(LIBVIRT_VERSION_INFO) \
diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am
index 96ae2f5044..de9fbe9239 100644
--- a/src/bhyve/Makefile.inc.am
+++ b/src/bhyve/Makefile.inc.am
@@ -56,6 +56,7 @@ augeastest_DATA +=3D bhyve/test_virtbhyved.aug
 CLEANFILES +=3D bhyve/virtbhyved.aug
=20
 virtbhyved_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtbhyved_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtbhyved_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtbhyved\"" \
diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am
index 7ba9fd1758..6b10755b7e 100644
--- a/src/esx/Makefile.inc.am
+++ b/src/esx/Makefile.inc.am
@@ -44,7 +44,6 @@ ESX_DRIVER_EXTRA_DIST =3D \
 	esx/README \
 	esx/esx_vi_generator.input \
 	esx/esx_vi_generator.py \
-	$(ESX_DRIVER_GENERATED) \
 	$(NULL)
=20
 ESX_GENERATED_STAMP =3D .esx_vi_generator.stamp
@@ -54,7 +53,6 @@ DRIVER_SOURCE_FILES +=3D $(ESX_DRIVER_SOURCES)
 EXTRA_DIST +=3D \
 	$(ESX_DRIVER_SOURCES) \
 	$(ESX_DRIVER_EXTRA_DIST) \
-	$(ESX_GENERATED_STAMP) \
 	$(NULL)
=20
 BUILT_SOURCES +=3D $(ESX_DRIVER_GENERATED)
@@ -66,7 +64,7 @@ $(ESX_GENERATED_STAMP): $(srcdir)/esx/esx_vi_generator.in=
put \
 	$(AM_V_GEN) $(RUNUTF8) $(PYTHON) \
 		$(srcdir)/esx/esx_vi_generator.py $(srcdir) $(builddir) && touch $@
=20
-MAINTAINERCLEANFILES +=3D $(ESX_DRIVER_GENERATED) $(ESX_GENERATED_STAMP)
+CLEANFILES +=3D $(ESX_DRIVER_GENERATED) $(ESX_GENERATED_STAMP)
=20
 if WITH_ESX
 USED_SYM_FILES +=3D $(srcdir)/libvirt_esx.syms
diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am
index 79e94d09bb..b71602c971 100644
--- a/src/hyperv/Makefile.inc.am
+++ b/src/hyperv/Makefile.inc.am
@@ -24,8 +24,6 @@ HYPERV_GENERATED_STAMP =3D .hyperv_wmi_generator.stamp
 HYPERV_DRIVER_EXTRA_DIST =3D \
 	hyperv/hyperv_wmi_generator.input \
 	hyperv/hyperv_wmi_generator.py \
-	$(HYPERV_DRIVER_GENERATED) \
-	$(HYPERV_GENERATED_STAMP) \
 	$(NULL)
=20
 DRIVER_SOURCE_FILES +=3D $(HYPERV_DRIVER_SOURCES)
@@ -45,7 +43,7 @@ $(HYPERV_GENERATED_STAMP): $(srcdir)/hyperv/hyperv_wmi_ge=
nerator.input \
 	  $(srcdir)/hyperv/hyperv_wmi_generator.py $(srcdir) $(builddir) \
 	  && touch $@
=20
-MAINTAINERCLEANFILES +=3D $(HYPERV_DRIVER_GENERATED) $(HYPERV_GENERATED_ST=
AMP)
+CLEANFILES +=3D $(HYPERV_DRIVER_GENERATED) $(HYPERV_GENERATED_STAMP)
=20
 if WITH_HYPERV
 noinst_LTLIBRARIES +=3D libvirt_driver_hyperv.la
diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am
index 30ea98ad15..5f22b90cb4 100644
--- a/src/interface/Makefile.inc.am
+++ b/src/interface/Makefile.inc.am
@@ -52,6 +52,7 @@ augeastest_DATA +=3D interface/test_virtinterfaced.aug
 CLEANFILES +=3D interface/virtinterfaced.aug
=20
 virtinterfaced_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtinterfaced_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtinterfaced_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtinterfaced\"" \
diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am
index 5d9cf14f7f..8686e78a5d 100644
--- a/src/libxl/Makefile.inc.am
+++ b/src/libxl/Makefile.inc.am
@@ -64,6 +64,7 @@ augeastest_DATA +=3D libxl/test_virtxend.aug
 CLEANFILES +=3D libxl/virtxend.aug
=20
 virtxend_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtxend_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtxend_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtxend\"" \
diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am
index 2bfb662016..5c2361a581 100644
--- a/src/locking/Makefile.inc.am
+++ b/src/locking/Makefile.inc.am
@@ -43,8 +43,6 @@ LOCK_DAEMON_SOURCES =3D \
=20
 EXTRA_DIST +=3D \
 	$(LOCK_PROTOCOL) \
-	$(LOCK_PROTOCOL_GENERATED) \
-	$(LOCK_DAEMON_GENERATED) \
 	$(LOCK_DAEMON_SOURCES) \
 	$(LOCK_DRIVER_LOCKD_SOURCES) \
 	$(LOCK_DRIVER_SOURCES) \
@@ -64,7 +62,7 @@ BUILT_SOURCES +=3D \
 	$(LOCK_DAEMON_GENERATED) \
 	$(NULL)
=20
-MAINTAINERCLEANFILES +=3D \
+CLEANFILES +=3D \
 	$(LOCK_PROTOCOL_GENERATED) \
 	$(LOCK_DAEMON_GENERATED) \
 	$(NULL)
@@ -105,6 +103,8 @@ if WITH_LIBVIRTD
 lockdriver_LTLIBRARIES +=3D lockd.la
 lockd_la_SOURCES =3D \
 	$(LOCK_DRIVER_LOCKD_SOURCES) \
+	$(NULL)
+nodist_lockd_la_SOURCES =3D \
 	$(LOCK_PROTOCOL_GENERATED) \
 	$(NULL)
 lockd_la_CFLAGS =3D \
@@ -145,6 +145,8 @@ sbin_PROGRAMS +=3D virtlockd
=20
 virtlockd_SOURCES =3D \
 	$(LOCK_DAEMON_SOURCES) \
+	$(NULL)
+nodist_virtlockd_SOURCES =3D \
 	$(LOCK_PROTOCOL_GENERATED) \
 	$(LOCK_DAEMON_GENERATED) \
 	$(NULL)
diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am
index dbaac2bb0d..fba54239d5 100644
--- a/src/logging/Makefile.inc.am
+++ b/src/logging/Makefile.inc.am
@@ -10,7 +10,6 @@ LOG_DAEMON_GENERATED =3D \
 	$(NULL)
=20
 LOG_DRIVER_SOURCES =3D \
-	$(LOG_PROTOCOL_GENERATED) \
 	logging/log_manager.c \
 	logging/log_manager.h \
 	$(NULL)
@@ -30,10 +29,8 @@ LOG_PROTOCOL =3D $(srcdir)/logging/log_protocol.x
=20
 EXTRA_DIST +=3D \
 	$(LOG_PROTOCOL) \
-	$(LOG_PROTOCOL_GENERATED) \
-	$(LOG_DAEMON_GENERATED) \
 	$(LOG_DAEMON_SOURCES) \
-	$(LOG_DRIVER_SOURCES) \
+	$(LOG_DRIVER) \
         logging/virtlogd.aug \
         logging/virtlogd.conf \
         logging/test_virtlogd.aug.in \
@@ -42,7 +39,7 @@ BUILT_SOURCES +=3D \
 	$(LOG_PROTOCOL_GENERATED) \
 	$(LOG_DAEMON_GENERATED) \
 	$(NULL)
-MAINTAINERCLEANFILES +=3D \
+CLEANFILES +=3D \
 	$(LOG_PROTOCOL_GENERATED) \
 	$(LOG_DAEMON_GENERATED) \
 	$(NULL)
@@ -66,6 +63,9 @@ libvirt_la_BUILT_LIBADD +=3D libvirt_driver_log.la
 libvirt_driver_log_la_SOURCES =3D \
 	$(LOG_DRIVER_SOURCES) \
 	$(NULL)
+nodist_libvirt_driver_log_la_SOURCES =3D \
+	$(LOG_PROTOCOL_GENERATED) \
+	$(NULL)
 libvirt_driver_log_la_CFLAGS =3D \
 	-I$(builddir)/logging \
 	-I$(builddir)/rpc \
@@ -80,6 +80,8 @@ man8_MANS +=3D virtlogd.8
=20
 virtlogd_SOURCES =3D \
 		$(LOG_DAEMON_SOURCES) \
+		$(NULL)
+nodist_virtlogd_SOURCES =3D \
 		$(LOG_PROTOCOL_GENERATED) \
 		$(LOG_DAEMON_GENERATED) \
 		$(NULL)
diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am
index cb55dfd1c6..d3a7cbf93b 100644
--- a/src/lxc/Makefile.inc.am
+++ b/src/lxc/Makefile.inc.am
@@ -22,8 +22,6 @@ LXC_GENERATED =3D \
 LXC_MONITOR_PROTOCOL =3D $(srcdir)/lxc/lxc_monitor_protocol.x
=20
 LXC_DRIVER_SOURCES =3D \
-	$(LXC_MONITOR_PROTOCOL_GENERATED) \
-	$(LXC_MONITOR_GENERATED) \
 	lxc/lxc_conf.c \
 	lxc/lxc_conf.h \
 	lxc/lxc_container.c \
@@ -47,8 +45,6 @@ LXC_DRIVER_SOURCES =3D \
 	$(NULL)
=20
 LXC_CONTROLLER_SOURCES =3D \
-	$(LXC_MONITOR_PROTOCOL_GENERATED) \
-	$(LXC_CONTROLLER_GENERATED) \
 	lxc/lxc_conf.c \
 	lxc/lxc_conf.h \
 	lxc/lxc_container.c \
@@ -62,13 +58,17 @@ LXC_CONTROLLER_SOURCES =3D \
 	lxc/lxc_controller.c \
 	$(NULL)
=20
-
-DRIVER_SOURCE_FILES +=3D $(LXC_DRIVER_SOURCES)
-STATEFUL_DRIVER_SOURCE_FILES +=3D $(LXC_DRIVER_SOURCES)
+DRIVER_SOURCE_FILES +=3D \
+	$(LXC_MONITOR_PROTOCOL_GENERATED) \
+	$(LXC_MONITOR_GENERATED) \
+	$(LXC_DRIVER_SOURCES)
+STATEFUL_DRIVER_SOURCE_FILES +=3D \
+	$(LXC_MONITOR_PROTOCOL_GENERATED) \
+	$(LXC_MONITOR_GENERATED) \
+	$(LXC_DRIVER_SOURCES)
 EXTRA_DIST +=3D \
 	$(LXC_DRIVER_SOURCES) \
 	$(LXC_MONITOR_PROTOCOL) \
-	$(LXC_GENERATED) \
 	$(LXC_CONTROLLER_SOURCES) \
 	$(NULL)
=20
@@ -112,7 +112,11 @@ libvirt_driver_lxc_impl_la_CFLAGS +=3D $(BLKID_CFLAGS)
 libvirt_driver_lxc_impl_la_LIBADD +=3D $(BLKID_LIBS)
 endif WITH_BLKID
 libvirt_driver_lxc_impl_la_LIBADD +=3D $(SECDRIVER_LIBS)
-libvirt_driver_lxc_impl_la_SOURCES =3D $(LXC_DRIVER_SOURCES)
+libvirt_driver_lxc_impl_la_SOURCES =3D \
+	$(LXC_DRIVER_SOURCES)
+nodist_libvirt_driver_lxc_impl_la_SOURCES =3D \
+	$(LXC_MONITOR_PROTOCOL_GENERATED) \
+	$(LXC_MONITOR_GENERATED)
=20
=20
 sbin_PROGRAMS +=3D virtlxcd
@@ -123,6 +127,7 @@ augeastest_DATA +=3D lxc/test_virtlxcd.aug
 CLEANFILES +=3D lxc/virtlxcd.aug
=20
 virtlxcd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodst_virtlxcd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtlxcd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtlxcd\"" \
@@ -183,6 +188,10 @@ libvirt_lxc_SOURCES =3D \
 	$(LXC_CONTROLLER_SOURCES) \
 	$(DATATYPES_SOURCES) \
 	$(NULL)
+nodist_libvirt_lxc_SOURCES =3D \
+	$(LXC_MONITOR_PROTOCOL_GENERATED) \
+	$(LXC_CONTROLLER_GENERATED) \
+	$(NULL)
 libvirt_lxc_LDFLAGS =3D \
 	$(AM_LDFLAGS) \
 	$(PIE_LDFLAGS) \
diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am
index 2f7932ae60..58dd90c23b 100644
--- a/src/network/Makefile.inc.am
+++ b/src/network/Makefile.inc.am
@@ -59,6 +59,7 @@ augeastest_DATA +=3D network/test_virtnetworkd.aug
 CLEANFILES +=3D network/virtnetworkd.aug
=20
 virtnetworkd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtnetworkd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtnetworkd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtnetworkd\"" \
diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc=
.am
index 1dfa0a5274..2a8c437e7b 100644
--- a/src/node_device/Makefile.inc.am
+++ b/src/node_device/Makefile.inc.am
@@ -77,6 +77,7 @@ augeastest_DATA +=3D node_device/test_virtnodedevd.aug
 CLEANFILES +=3D node_device/virtnodedevd.aug
=20
 virtnodedevd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtnodedevd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtnodedevd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtnodedevd\"" \
diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am
index ca05cba934..c320b75f78 100644
--- a/src/nwfilter/Makefile.inc.am
+++ b/src/nwfilter/Makefile.inc.am
@@ -60,6 +60,7 @@ augeastest_DATA +=3D nwfilter/test_virtnwfilterd.aug
 CLEANFILES +=3D nwfilter/virtnwfilterd.aug
=20
 virtnwfilterd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtnwfilterd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtnwfilterd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtnwfilterd\"" \
diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am
index 69e290c428..3f3476b2b4 100644
--- a/src/qemu/Makefile.inc.am
+++ b/src/qemu/Makefile.inc.am
@@ -134,6 +134,7 @@ augeastest_DATA +=3D qemu/test_virtqemud.aug
 CLEANFILES +=3D qemu/virtqemud.aug
=20
 virtqemud_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtqemud_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtqemud_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtqemud\"" \
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 242eb3ed2d..f5de92be23 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -15,7 +15,6 @@ REMOTE_DRIVER_GENERATED =3D \
 REMOTE_DRIVER_SOURCES =3D \
 	remote/remote_driver.c \
 	remote/remote_driver.h \
-	$(REMOTE_DRIVER_GENERATED) \
 	$(NULL)
=20
 REMOTE_DAEMON_GENERATED =3D \
@@ -33,7 +32,6 @@ REMOTE_DAEMON_SOURCES =3D \
 	remote/remote_daemon_dispatch.h \
 	remote/remote_daemon_stream.c \
 	remote/remote_daemon_stream.h \
-	$(REMOTE_DAEMON_GENERATED) \
 	$(NULL)
=20
 REMOTE_DAEMON_CFLAGS =3D \
@@ -140,7 +138,9 @@ REMOTE_DRIVER_PROTOCOL =3D \
 	$(LXC_PROTOCOL) \
 	$(NULL)
=20
-DRIVER_SOURCE_FILES +=3D $(REMOTE_DRIVER_SOURCES)
+DRIVER_SOURCE_FILES +=3D \
+	$(REMOTE_DRIVER_GENERATED) \
+	$(REMOTE_DRIVER_SOURCES)
=20
 EXTRA_DIST +=3D \
 	$(REMOTE_DRIVER_PROTOCOL) \
@@ -161,11 +161,9 @@ BUILT_SOURCES +=3D \
 	$(REMOTE_DRIVER_GENERATED) \
 	$(REMOTE_DAEMON_GENERATED) \
 	$(NULL)
-MAINTAINERCLEANFILES +=3D \
+CLEANFILES +=3D \
 	$(REMOTE_DRIVER_GENERATED) \
 	$(REMOTE_DAEMON_GENERATED) \
-	$(NULL)
-CLEANFILES +=3D \
 	remote/libvirtd.conf \
 	remote/virtproxyd.conf \
 	$(NULL)
@@ -182,10 +180,13 @@ libvirt_driver_remote_la_CFLAGS =3D \
 	$(AM_CFLAGS) \
 	$(NULL)
 libvirt_driver_remote_la_LDFLAGS =3D $(AM_LDFLAGS)
-libvirt_driver_remote_la_SOURCES =3D $(REMOTE_DRIVER_SOURCES)
+libvirt_driver_remote_la_SOURCES =3D \
+	$(REMOTE_DRIVER_SOURCES)
+nodist_libvirt_driver_remote_la_SOURCES =3D \
+	$(REMOTE_DRIVER_GENERATED)
=20
 if WITH_DTRACE_PROBES
-nodist_libvirt_driver_remote_la_SOURCES =3D libvirt_probes.h
+nodist_libvirt_driver_remote_la_SOURCES +=3D libvirt_probes.h
 endif WITH_DTRACE_PROBES
=20
 if WITH_SASL
@@ -230,6 +231,8 @@ man8_MANS +=3D libvirtd.8
=20
 libvirtd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
=20
+nodist_libvirtd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
+
 libvirtd_CFLAGS =3D \
 	$(REMOTE_DAEMON_CFLAGS) \
 	-DSOCK_PREFIX=3D"\"libvirt\"" \
@@ -243,6 +246,7 @@ libvirtd_LDFLAGS =3D $(REMOTE_DAEMON_LD_FLAGS)
 libvirtd_LDADD =3D $(REMOTE_DAEMON_LD_ADD)
=20
 virtproxyd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtproxyd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtproxyd_CFLAGS =3D \
 	$(REMOTE_DAEMON_CFLAGS) \
 	-DSOCK_PREFIX=3D"\"libvirt\"" \
diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am
index 4aa38db1ab..a5bde92c9f 100644
--- a/src/rpc/Makefile.inc.am
+++ b/src/rpc/Makefile.inc.am
@@ -16,7 +16,7 @@ VIR_NET_RPC_GENERATED =3D \
 	$(NULL)
=20
 BUILT_SOURCES +=3D $(VIR_NET_RPC_GENERATED)
-MAINTAINERCLEANFILES +=3D $(VIR_NET_RPC_GENERATED)
+CLEANFILES +=3D $(VIR_NET_RPC_GENERATED)
=20
 noinst_LTLIBRARIES +=3D \
 	libvirt-net-rpc.la \
@@ -39,6 +39,9 @@ libvirt_net_rpc_la_SOURCES =3D \
 	rpc/virnetsocket.c \
 	rpc/virkeepalive.h \
 	rpc/virkeepalive.c \
+	$(NULL)
+
+nodist_libvirt_net_rpc_la_SOURCES =3D \
 	$(VIR_NET_RPC_GENERATED) \
 	$(NULL)
=20
diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am
index 94f293d418..3d77366d3c 100644
--- a/src/secret/Makefile.inc.am
+++ b/src/secret/Makefile.inc.am
@@ -48,6 +48,7 @@ augeastest_DATA +=3D secret/test_virtsecretd.aug
 CLEANFILES +=3D secret/virtsecretd.aug
=20
 virtsecretd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtsecretd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtsecretd_CFLAGS =3D \
 	$(REMOTE_DAEMON_CFLAGS) \
 	-DDAEMON_NAME=3D"\"virtsecretd\"" \
diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am
index ec35ab7665..1dfe48668f 100644
--- a/src/storage/Makefile.inc.am
+++ b/src/storage/Makefile.inc.am
@@ -152,6 +152,7 @@ augeastest_DATA +=3D storage/test_virtstoraged.aug
 CLEANFILES +=3D storage/virtstoraged.aug
=20
 virtstoraged_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtstoraged_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtstoraged_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtstoraged\"" \
diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am
index d8c8e61c4b..0eadef71ca 100644
--- a/src/util/Makefile.inc.am
+++ b/src/util/Makefile.inc.am
@@ -253,9 +253,8 @@ KEYMANS =3D $(KEYPODS:%.pod=3D%.7)
=20
 man7_MANS +=3D $(KEYMANS)
=20
-UTIL_SOURCES +=3D $(KEYTABLES)
 BUILT_SOURCES +=3D $(KEYTABLES)
-MAINTAINERCLEANFILES +=3D $(KEYTABLES)
+CLEANFILES +=3D $(KEYTABLES)
 CLEANFILES +=3D $(KEYMANS) $(KEYPODS)
=20
 UTIL_IO_HELPER_SOURCES =3D util/iohelper.c
@@ -266,6 +265,9 @@ libvirt_la_BUILT_LIBADD +=3D libvirt_util.la
 libvirt_util_la_SOURCES =3D \
 	$(UTIL_SOURCES) \
 	$(NULL)
+nodist_libvirt_util_la_SOURCES =3D \
+	$(KEYTABLES) \
+	$(NULL)
 libvirt_util_la_CFLAGS =3D \
 	$(CAPNG_CFLAGS) \
 	$(YAJL_CFLAGS) \
diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am
index 346a84429b..551189c0f5 100644
--- a/src/vbox/Makefile.inc.am
+++ b/src/vbox/Makefile.inc.am
@@ -73,6 +73,7 @@ augeastest_DATA +=3D vbox/test_virtvboxd.aug
 CLEANFILES +=3D vbox/virtvboxd.aug
=20
 virtvboxd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtvboxd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtvboxd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtvboxd\"" \
diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am
index c5bef04088..1757c8ba10 100644
--- a/src/vz/Makefile.inc.am
+++ b/src/vz/Makefile.inc.am
@@ -47,6 +47,7 @@ augeastest_DATA +=3D vz/test_virtvzd.aug
 CLEANFILES +=3D vz/virtvzd.aug
=20
 virtvzd_SOURCES =3D $(REMOTE_DAEMON_SOURCES)
+nodist_virtvzd_SOURCES =3D $(REMOTE_DAEMON_GENERATED)
 virtvzd_CFLAGS =3D \
        $(REMOTE_DAEMON_CFLAGS) \
        -DDAEMON_NAME=3D"\"virtvzd\"" \
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
From nobody Fri Apr 19 23:55:54 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zoho.com: domain of redhat.com designates 205.139.110.120
 as permitted sender) client-ip=205.139.110.120;
 envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass(p=none dis=none)  header.from=redhat.com
ARC-Seal: i=1; a=rsa-sha256; t=1573228061; cv=none;
	d=zoho.com; s=zohoarc;
	b=h1kALYBzU1e82sTpf7qSGGKv2ilCjLwXL3yTZfwC40YYXuYoW0IGZFXu09cFuwqN8J0/Ok7PS9+L2qBR8zoWnNJMhAqI52+AafIqZbs93N64sFpCiFgW/NQp9/QoPSeTKgwtj95nRPXHPdr/rOglOQU9tE1PW/+AmFN+Up3om9E=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com;
 s=zohoarc;
	t=1573228061;
 h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
	bh=g6eI6Cf8Rf9utebc3MS6wUZ5+kfgiS4enfB1CzaE7CQ=;
	b=PZDNTbceFgkxT23ZbORbatCbePoTeQFKyWn7A/rGcbE3CVNEPetx+bych96o1AkJ9x80l+S5jEE3zSoPLs2Ew4SlDsD/mSAxvVl2f/UHr5VkJxJtGN5rLuegBloZAqOPbLgJy0dLV1NS8XgqNdwXVX5S1zlDD5lv1NKIW2pLbT4=
ARC-Authentication-Results: i=1; mx.zoho.com;
	dkim=pass;
	spf=pass (zoho.com: domain of redhat.com designates 205.139.110.120 as
 permitted sender)  smtp.mailfrom=libvir-list-bounces@redhat.com;
	dmarc=pass header.from= (p=none dis=none)
 header.from=
Return-Path: 
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
 [205.139.110.120]) by mx.zohomail.com
	with SMTPS id 157322806176260.84303369598342;
 Fri, 8 Nov 2019 07:47:41 -0800 (PST)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-386-00h9nMT5N0y1KeUXk5frJg-1; Fri, 08 Nov 2019 10:47:38 -0500
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D133102;
	Fri,  8 Nov 2019 15:47:33 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
 (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 34D515D6D8;
	Fri,  8 Nov 2019 15:47:33 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
 (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2A291819ACF;
	Fri,  8 Nov 2019 15:47:32 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
	[10.5.11.15])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id xA8FgpST014226 for ;
	Fri, 8 Nov 2019 10:42:51 -0500
Received: by smtp.corp.redhat.com (Postfix)
	id 1803C5D6BB; Fri,  8 Nov 2019 15:42:51 +0000 (UTC)
Received: from antique-laptop.redhat.com (ovpn-200-52.brq.redhat.com
	[10.40.200.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 7C7505D6B7
	for ; Fri,  8 Nov 2019 15:42:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1573228060;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post;
	bh=g6eI6Cf8Rf9utebc3MS6wUZ5+kfgiS4enfB1CzaE7CQ=;
	b=B4SitRH6w8sa1wS2UX76ukUIYTdwaEPBWjpFnY/wO++0yis2+CrJFQE8973PX2eGcL7+fA
	Zzvhw+G4xzsd9crEXskm4lzEUloyaMzCfSVW7GncQavYzgca+4/fK57/vhQ/U3+TziT1DQ
	27HWyRF3nrepth/ZKQD76UZQtrxasNE=
From: Pavel Hrdina 
To: libvir-list@redhat.com
Date: Fri,  8 Nov 2019 16:42:21 +0100
Message-Id: 
 
In-Reply-To: 
References: 
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-loop: libvir-list@redhat.com
Subject: [libvirt] [PATCH v4 20/20] [ACKED] tools: stop distributing
	generated source files
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
	
List-Unsubscribe: ,
	
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
	
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-MC-Unique: 00h9nMT5N0y1KeUXk5frJg-1
X-Mimecast-Spam-Score: 0
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"

Signed-off-by: Pavel Hrdina 
Reviewed-by: J=C3=A1n Tomko 
Reviewed-by: Daniel P. Berrang=C3=A9 
---
 tools/Makefile.am | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/Makefile.am b/tools/Makefile.am
index 68320c7246..1a541a3984 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -84,7 +84,6 @@ EXTRA_DIST =3D \
 	bash-completion/vsh \
 	libvirt_recover_xattrs.sh \
 	$(PODFILES) \
-	$(MANINFILES) \
 	$(NULL)
=20
=20
--=20
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list