util: buffer: Use glib's GString internally

[libvirt] [PATCH 02/19] util: buffer: Use 'cleanup' as label name in virBufferAddBuffer

Posted by Peter Krempa 6 years, 3 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/util/virbuffer.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index a58481430a..a2b5aa8508 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer.c
@@ -201,22 +201,22 @@ virBufferAddBuffer(virBufferPtr buf, virBufferPtr toadd)
         return;

     if (!buf)
-        goto done;
+        goto cleanup;

     if (buf->error || toadd->error) {
         if (!buf->error)
             virBufferSetError(buf, toadd->error);
-        goto done;
+        goto cleanup;
     }

     if (virBufferGrow(buf, toadd->use) < 0)
-        goto done;
+        goto cleanup;

     memcpy(&buf->content[buf->use], toadd->content, toadd->use);
     buf->use += toadd->use;
     buf->content[buf->use] = '\0';

- done:
+ cleanup:
     virBufferFreeAndReset(toadd);
 }

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 02/19] util: buffer: Use 'cleanup' as label name in virBufferAddBuffer

Posted by Ján Tomko 6 years, 3 months ago

On Thu, Oct 24, 2019 at 03:56:20PM +0200, Peter Krempa wrote:
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/util/virbuffer.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list