[libvirt] [PATCH 00/19] util: buffer: Use glib's GString internally

Peter Krempa posted 19 patches 3 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1571925291.git.pkrempa@redhat.com
src/bhyve/bhyve_command.c                 |   3 -
src/bhyve/bhyve_driver.c                  |   5 -
src/conf/capabilities.c                   |  16 -
src/conf/checkpoint_conf.c                |   3 -
src/conf/cpu_conf.c                       |   7 -
src/conf/domain_addr.c                    |   2 -
src/conf/domain_capabilities.c            |   1 -
src/conf/domain_conf.c                    | 154 ++++-----
src/conf/interface_conf.c                 |   3 -
src/conf/network_conf.c                   |   5 +-
src/conf/node_device_conf.c               |   3 -
src/conf/nwfilter_conf.c                  |   9 -
src/conf/secret_conf.c                    |   3 -
src/conf/snapshot_conf.c                  |   3 -
src/conf/storage_conf.c                   |  12 -
src/conf/virnetworkobj.c                  |   3 -
src/conf/virnetworkportdef.c              |   3 -
src/conf/virnwfilterbindingdef.c          |   3 -
src/conf/virnwfilterbindingobj.c          |   3 -
src/conf/virsavecookie.c                  |   3 -
src/cpu/cpu_map.c                         |   2 -
src/cpu/cpu_x86.c                         |  10 -
src/esx/esx_driver.c                      |  12 -
src/esx/esx_util.c                        |   6 -
src/esx/esx_vi.c                          |  15 -
src/esx/esx_vi_methods.c                  |   3 -
src/hyperv/hyperv_driver.c                |   3 -
src/hyperv/hyperv_wmi.c                   |  10 -
src/libvirt_private.syms                  |   3 +-
src/libxl/libxl_conf.c                    |   5 -
src/libxl/libxl_driver.c                  |   2 -
src/libxl/libxl_migration.c               |   3 -
src/libxl/xen_common.c                    |  13 -
src/libxl/xen_xl.c                        |   9 -
src/libxl/xen_xm.c                        |   3 -
src/locking/lock_driver_sanlock.c         |   3 -
src/lxc/lxc_container.c                   |   3 -
src/lxc/lxc_controller.c                  |   3 -
src/lxc/lxc_driver.c                      |   2 -
src/lxc/lxc_fuse.c                        |   4 -
src/network/bridge_driver.c               |   6 -
src/node_device/node_device_udev.c        |   3 -
src/nwfilter/nwfilter_ebiptables_driver.c |   8 -
src/nwfilter/nwfilter_gentech_driver.c    |   6 -
src/nwfilter/nwfilter_learnipaddr.c       |   5 -
src/phyp/phyp_driver.c                    |   4 -
src/qemu/qemu_capabilities.c              |   3 +-
src/qemu/qemu_command.c                   | 130 --------
src/qemu/qemu_domain.c                    |  28 +-
src/qemu/qemu_driver.c                    |   2 -
src/qemu/qemu_migration_cookie.c          |   3 -
src/qemu/qemu_monitor_json.c              |   3 -
src/rpc/virnetlibsshsession.c             |   6 -
src/rpc/virnetsocket.c                    |   8 -
src/rpc/virnetsshsession.c                |   6 -
src/security/virt-aa-helper.c             |  11 -
src/storage/storage_backend_rbd.c         |   6 -
src/storage/storage_util.c                |  13 -
src/util/viralloc.h                       |  19 --
src/util/virbitmap.c                      |   7 -
src/util/virbuffer.c                      | 361 +++++++---------------
src/util/virbuffer.h                      |  30 +-
src/util/vircommand.c                     |  11 +-
src/util/virconf.c                        |   6 -
src/util/virdnsmasq.c                     |   6 -
src/util/virfilecache.c                   |   3 -
src/util/virlog.c                         |   8 -
src/util/virnetdevopenvswitch.c           |   3 -
src/util/virpidfile.c                     |   7 -
src/util/virqemu.c                        |   3 -
src/util/virresctrl.c                     |   4 +-
src/util/virstoragefile.c                 |   3 -
src/util/virstring.c                      |   5 -
src/util/virsysinfo.c                     |  24 +-
src/util/virsystemd.c                     |   6 -
src/util/viruri.c                         |   3 -
src/util/virxml.c                         |  19 +-
src/util/virxml.h                         |   5 +-
src/vmx/vmx.c                             |   3 -
src/vz/vz_driver.c                        |   5 -
tests/cputest.c                           |   4 -
tests/networkxml2firewalltest.c           |   3 -
tests/nwfilterebiptablestest.c            |  21 --
tests/nwfilterxml2firewalltest.c          |   3 -
tests/qemublocktest.c                     |   6 -
tests/qemumonitorjsontest.c               |   6 -
tests/qemumonitortestutils.c              |   2 -
tests/testutils.c                         |   2 -
tests/testutilsqemuschema.c               |   2 +-
tests/vboxsnapshotxmltest.c               |   5 -
tests/virbuftest.c                        | 139 ++-------
tests/vircgrouptest.c                     |   2 -
tests/virfirewalltest.c                   |  30 --
tests/virkmodtest.c                       |   6 +-
tests/virnetdevbandwidthtest.c            |   5 -
tests/virsystemdtest.c                    |   3 -
tests/viruritest.c                        |   2 +-
tools/virsh-checkpoint.c                  |   5 -
tools/virsh-domain-monitor.c              |   6 -
tools/virsh-domain.c                      |  30 --
tools/virsh-pool.c                        |   9 -
tools/virsh-snapshot.c                    |   5 -
tools/virsh-volume.c                      |   4 -
tools/vsh.c                               |  33 +-
tools/vsh.h                               |   5 +-
105 files changed, 224 insertions(+), 1264 deletions(-)

[libvirt] [PATCH 00/19] util: buffer: Use glib's GString internally

Posted by Peter Krempa 3 weeks ago
Converting to glib's helpers allows us to greatly simplify the error
handling from virBuffer.

Peter Krempa (19):
  util: buffer: Simplify convoluted condition
  util: buffer: Use 'cleanup' as label name in virBufferAddBuffer
  util: buffer: Simplify escape buffer allocations
  virsh: Reimplement _vshCalloc using g_malloc0_n
  util: alloc: drop xalloc_oversized macro
  util: buffer: Don't treat missing truncation in virBufferTrim as usage
    error
  util: buffer: Simplify handling of indent overflows
  tests: virbuffer: Drop 'infinite loop' tests
  tests: virbuffer: Remove unused test data struct
  util: buffer: Split getting of effective indent out of
    virBufferGetIndent
  util: sysinfo: Use virXMLFormatElement and infrastructure in
    virSysinfoFormat
  util: virbuffer: Remove @dynamic from virBufferGetIndent
  util: buffer: Properly URLencode strings
  util: buffer: Encode URIs with upper case hex characters
  util: buffer: Reimplement virBuffer internals using glib's GString
  util: buffer: Remove error handling internals
  util: buffer: Remove virBufferError
  util: buffer: Remove virBufferCheckError
  util: xml: Make virXMLFormatElement void

 src/bhyve/bhyve_command.c                 |   3 -
 src/bhyve/bhyve_driver.c                  |   5 -
 src/conf/capabilities.c                   |  16 -
 src/conf/checkpoint_conf.c                |   3 -
 src/conf/cpu_conf.c                       |   7 -
 src/conf/domain_addr.c                    |   2 -
 src/conf/domain_capabilities.c            |   1 -
 src/conf/domain_conf.c                    | 154 ++++-----
 src/conf/interface_conf.c                 |   3 -
 src/conf/network_conf.c                   |   5 +-
 src/conf/node_device_conf.c               |   3 -
 src/conf/nwfilter_conf.c                  |   9 -
 src/conf/secret_conf.c                    |   3 -
 src/conf/snapshot_conf.c                  |   3 -
 src/conf/storage_conf.c                   |  12 -
 src/conf/virnetworkobj.c                  |   3 -
 src/conf/virnetworkportdef.c              |   3 -
 src/conf/virnwfilterbindingdef.c          |   3 -
 src/conf/virnwfilterbindingobj.c          |   3 -
 src/conf/virsavecookie.c                  |   3 -
 src/cpu/cpu_map.c                         |   2 -
 src/cpu/cpu_x86.c                         |  10 -
 src/esx/esx_driver.c                      |  12 -
 src/esx/esx_util.c                        |   6 -
 src/esx/esx_vi.c                          |  15 -
 src/esx/esx_vi_methods.c                  |   3 -
 src/hyperv/hyperv_driver.c                |   3 -
 src/hyperv/hyperv_wmi.c                   |  10 -
 src/libvirt_private.syms                  |   3 +-
 src/libxl/libxl_conf.c                    |   5 -
 src/libxl/libxl_driver.c                  |   2 -
 src/libxl/libxl_migration.c               |   3 -
 src/libxl/xen_common.c                    |  13 -
 src/libxl/xen_xl.c                        |   9 -
 src/libxl/xen_xm.c                        |   3 -
 src/locking/lock_driver_sanlock.c         |   3 -
 src/lxc/lxc_container.c                   |   3 -
 src/lxc/lxc_controller.c                  |   3 -
 src/lxc/lxc_driver.c                      |   2 -
 src/lxc/lxc_fuse.c                        |   4 -
 src/network/bridge_driver.c               |   6 -
 src/node_device/node_device_udev.c        |   3 -
 src/nwfilter/nwfilter_ebiptables_driver.c |   8 -
 src/nwfilter/nwfilter_gentech_driver.c    |   6 -
 src/nwfilter/nwfilter_learnipaddr.c       |   5 -
 src/phyp/phyp_driver.c                    |   4 -
 src/qemu/qemu_capabilities.c              |   3 +-
 src/qemu/qemu_command.c                   | 130 --------
 src/qemu/qemu_domain.c                    |  28 +-
 src/qemu/qemu_driver.c                    |   2 -
 src/qemu/qemu_migration_cookie.c          |   3 -
 src/qemu/qemu_monitor_json.c              |   3 -
 src/rpc/virnetlibsshsession.c             |   6 -
 src/rpc/virnetsocket.c                    |   8 -
 src/rpc/virnetsshsession.c                |   6 -
 src/security/virt-aa-helper.c             |  11 -
 src/storage/storage_backend_rbd.c         |   6 -
 src/storage/storage_util.c                |  13 -
 src/util/viralloc.h                       |  19 --
 src/util/virbitmap.c                      |   7 -
 src/util/virbuffer.c                      | 361 +++++++---------------
 src/util/virbuffer.h                      |  30 +-
 src/util/vircommand.c                     |  11 +-
 src/util/virconf.c                        |   6 -
 src/util/virdnsmasq.c                     |   6 -
 src/util/virfilecache.c                   |   3 -
 src/util/virlog.c                         |   8 -
 src/util/virnetdevopenvswitch.c           |   3 -
 src/util/virpidfile.c                     |   7 -
 src/util/virqemu.c                        |   3 -
 src/util/virresctrl.c                     |   4 +-
 src/util/virstoragefile.c                 |   3 -
 src/util/virstring.c                      |   5 -
 src/util/virsysinfo.c                     |  24 +-
 src/util/virsystemd.c                     |   6 -
 src/util/viruri.c                         |   3 -
 src/util/virxml.c                         |  19 +-
 src/util/virxml.h                         |   5 +-
 src/vmx/vmx.c                             |   3 -
 src/vz/vz_driver.c                        |   5 -
 tests/cputest.c                           |   4 -
 tests/networkxml2firewalltest.c           |   3 -
 tests/nwfilterebiptablestest.c            |  21 --
 tests/nwfilterxml2firewalltest.c          |   3 -
 tests/qemublocktest.c                     |   6 -
 tests/qemumonitorjsontest.c               |   6 -
 tests/qemumonitortestutils.c              |   2 -
 tests/testutils.c                         |   2 -
 tests/testutilsqemuschema.c               |   2 +-
 tests/vboxsnapshotxmltest.c               |   5 -
 tests/virbuftest.c                        | 139 ++-------
 tests/vircgrouptest.c                     |   2 -
 tests/virfirewalltest.c                   |  30 --
 tests/virkmodtest.c                       |   6 +-
 tests/virnetdevbandwidthtest.c            |   5 -
 tests/virsystemdtest.c                    |   3 -
 tests/viruritest.c                        |   2 +-
 tools/virsh-checkpoint.c                  |   5 -
 tools/virsh-domain-monitor.c              |   6 -
 tools/virsh-domain.c                      |  30 --
 tools/virsh-pool.c                        |   9 -
 tools/virsh-snapshot.c                    |   5 -
 tools/virsh-volume.c                      |   4 -
 tools/vsh.c                               |  33 +-
 tools/vsh.h                               |   5 +-
 105 files changed, 224 insertions(+), 1264 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list