qemu: Add support for incremental backups

[libvirt] [PATCH RFC 20/40] conf: checkpoint: Don't clear current checkpoint when redefining an existing one

Posted by Peter Krempa 6 years, 2 months ago

There's no point in clearing the current checkpoint when we are just
changing the definition of the current checkpoint as by the virtue of the
'update_current' flag the same checkpoint would become current in
qemuCheckpointCreateXML.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/checkpoint_conf.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c
index ea2e77a50a..7f2cfd7f4c 100644
--- a/src/conf/checkpoint_conf.c
+++ b/src/conf/checkpoint_conf.c
@@ -575,11 +575,6 @@ virDomainCheckpointRedefinePrep(virDomainObjPtr vm,
                                            def->parent.dom, xmlopt))
             return -1;

-        if (other == virDomainCheckpointGetCurrent(vm->checkpoints)) {
-            *update_current = true;
-            virDomainCheckpointSetCurrent(vm->checkpoints, NULL);
-        }
-
         /* Drop and rebuild the parent relationship, but keep all
          * child relations by reusing chk.  */
         virDomainMomentDropParent(other);
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH RFC 20/40] conf: checkpoint: Don't clear current checkpoint when redefining an existing one

Posted by Ján Tomko 6 years, 1 month ago

On Fri, Oct 18, 2019 at 06:11:05PM +0200, Peter Krempa wrote:
>There's no point in clearing the current checkpoint when we are just
>changing the definition of the current checkpoint as by the virtue of the
>'update_current' flag the same checkpoint would become current in
>qemuCheckpointCreateXML.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/conf/checkpoint_conf.c | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list