From nobody Mon Feb 9 06:07:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571415124; cv=none; d=zoho.com; s=zohoarc; b=Fp7WphD6DuMlFnhGQ3D220EyuFKx0jvGQfo2KaHI9ZinTCynEDl244CA33xHaL5Px5w6znjmnvhuSwdaEMGebQdVxwoW1WEV0Kw+nEBv8gN5A62dTeHn/V+OSorLoQmylmkKXVt4KtZfelvAs3raqLI9LVpwhyYEu5nFah5J6U4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571415124; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C7hYAmUtSWGwh+OWVMCPhh9xID1IjrNHbeFk1btnEls=; b=Um57IZeqH24+Zk5Yewg+/icS6Whu5oiloTojhvIVJbOhYQmuQDLqRNaVPVYnl3BUnbS2ruJzlY23cPHsKJLjwOWE0a71ZH0QIpCwE4RTSyt6lGA32q21LE79vM3B4O3+pmDXlb6snaLLuam/y+nYnEc715VhH3Hf6nVOpMog0SQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1571415124856382.7294414037668; Fri, 18 Oct 2019 09:12:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E7F07BDD5; Fri, 18 Oct 2019 16:12:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 349455D71C; Fri, 18 Oct 2019 16:12:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7586C592; Fri, 18 Oct 2019 16:12:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x9IGBrDB004736 for ; Fri, 18 Oct 2019 12:11:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7EAC2600C4; Fri, 18 Oct 2019 16:11:53 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id D539C60161; Fri, 18 Oct 2019 16:11:52 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Fri, 18 Oct 2019 18:11:05 +0200 Message-Id: <29d62e5e72be0452f5e2ca97a74a13e3d0d9d734.1571414890.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH RFC 20/40] conf: checkpoint: Don't clear current checkpoint when redefining an existing one X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 18 Oct 2019 16:12:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" There's no point in clearing the current checkpoint when we are just changing the definition of the current checkpoint as by the virtue of the 'update_current' flag the same checkpoint would become current in qemuCheckpointCreateXML. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/conf/checkpoint_conf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c index ea2e77a50a..7f2cfd7f4c 100644 --- a/src/conf/checkpoint_conf.c +++ b/src/conf/checkpoint_conf.c @@ -575,11 +575,6 @@ virDomainCheckpointRedefinePrep(virDomainObjPtr vm, def->parent.dom, xmlopt)) return -1; - if (other =3D=3D virDomainCheckpointGetCurrent(vm->checkpoints)) { - *update_current =3D true; - virDomainCheckpointSetCurrent(vm->checkpoints, NULL); - } - /* Drop and rebuild the parent relationship, but keep all * child relations by reusing chk. */ virDomainMomentDropParent(other); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list