[libvirt] [PATCH 2/3] qemu: hotplug: Use VIR_AUTOFREE in qemuDomainAttachDiskGeneric

Peter Krempa posted 3 patches 6 years, 5 months ago
[libvirt] [PATCH 2/3] qemu: hotplug: Use VIR_AUTOFREE in qemuDomainAttachDiskGeneric
Posted by Peter Krempa 6 years, 5 months ago
Get rid of the last manually freed var.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_hotplug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index c91dfc9f6b..30aa6d2344 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -613,7 +613,7 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver,
     VIR_AUTOPTR(qemuBlockStorageSourceChainData) data = NULL;
     int ret = -1;
     qemuDomainObjPrivatePtr priv = vm->privateData;
-    char *devstr = NULL;
+    VIR_AUTOFREE(char *) devstr = NULL;
     VIR_AUTOUNREF(virQEMUDriverConfigPtr) cfg = virQEMUDriverGetConfig(driver);
     VIR_AUTOPTR(virJSONValue) corProps = NULL;
     VIR_AUTOFREE(char *) corAlias = NULL;
@@ -679,7 +679,6 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver,

  cleanup:
     qemuDomainSecretDiskDestroy(disk);
-    VIR_FREE(devstr);
     return ret;

  exit_monitor:
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/3] qemu: hotplug: Use VIR_AUTOFREE in qemuDomainAttachDiskGeneric
Posted by Ján Tomko 6 years, 5 months ago
On Thu, Sep 05, 2019 at 04:20:05PM +0200, Peter Krempa wrote:
>Get rid of the last manually freed var.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_hotplug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list