From nobody Mon Feb 9 10:57:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567693222; cv=none; d=zoho.com; s=zohoarc; b=WgnAn/89g4KaQUOcWDsvTHTb2Qksm7LIwTla4p2rA5gyD7j7Hv1XX0c/fjDvOmRcub6zBsnlPs8xshdxwPOrx/BfA/W9aCyj5+7oFuO0R4p8HI7Qko6IGAmjVyxi+V2FZ6aOMDKrJ0wsS8Qw9G4egpPSn7OF3xz3y5qX0kbLZJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567693222; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=nbYn8f9V9wo8PXYVRUEiZfpzvE1dRwAwd13Lz7OLB14=; b=X3IMn9OFOG31eulhM4SDv9MG6tcIOukUnIzPh4Z2yC2XI9KPciq4p8xcKE3rrWUUC1z2WWp74klmRM0HuGl1v1qaOBIo91ZnzF59tIUvHoFySQNCh+zezTJz0umMbRXHqEY+annkPMDxu5FQcgFjUABgo5fwikaxE2Cum9pasVo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567693222534665.4505358711237; Thu, 5 Sep 2019 07:20:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20AC918C4283; Thu, 5 Sep 2019 14:20:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDCC41001281; Thu, 5 Sep 2019 14:20:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AAA78180221F; Thu, 5 Sep 2019 14:20:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x85EKFDt006257 for ; Thu, 5 Sep 2019 10:20:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5022260127; Thu, 5 Sep 2019 14:20:15 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4B5F60467 for ; Thu, 5 Sep 2019 14:20:14 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Thu, 5 Sep 2019 16:20:05 +0200 Message-Id: <621eeb5758e5e5018b48103c026c83ee05083336.1567693128.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] qemu: hotplug: Use VIR_AUTOFREE in qemuDomainAttachDiskGeneric X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Thu, 05 Sep 2019 14:20:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Get rid of the last manually freed var. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index c91dfc9f6b..30aa6d2344 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -613,7 +613,7 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver, VIR_AUTOPTR(qemuBlockStorageSourceChainData) data =3D NULL; int ret =3D -1; qemuDomainObjPrivatePtr priv =3D vm->privateData; - char *devstr =3D NULL; + VIR_AUTOFREE(char *) devstr =3D NULL; VIR_AUTOUNREF(virQEMUDriverConfigPtr) cfg =3D virQEMUDriverGetConfig(d= river); VIR_AUTOPTR(virJSONValue) corProps =3D NULL; VIR_AUTOFREE(char *) corAlias =3D NULL; @@ -679,7 +679,6 @@ qemuDomainAttachDiskGeneric(virQEMUDriverPtr driver, cleanup: qemuDomainSecretDiskDestroy(disk); - VIR_FREE(devstr); return ret; exit_monitor: --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list