qemu: Support block pull/commit jobs with blockdev (blockdev-add saga)

[libvirt] [PATCH 1/9] qemu: blockjob: Use proper value when setting disk's READY state

Posted by Peter Krempa 6 years, 6 months ago

Commit c412383796c used value from wrong enum when setting the disk's
mirrorState variable. This meant that a 'READY' job would show up as
'PIVOTING'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_blockjob.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index da4f20929b..e63dc49e92 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -723,7 +723,7 @@ qemuBlockJobEventProcess(virQEMUDriverPtr driver,

     case QEMU_BLOCKJOB_STATE_READY:
         if (job->disk && job->disk->mirror) {
-            job->disk->mirrorState = VIR_DOMAIN_BLOCK_JOB_READY;
+            job->disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_READY;
             qemuBlockJobEmitEvents(driver, vm, job->disk, job->type, job->newstate);
         }
         job->state = job->newstate;
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/9] qemu: blockjob: Use proper value when setting disk's READY state

Posted by Eric Blake 6 years, 6 months ago

On 7/24/19 4:07 PM, Peter Krempa wrote:
> Commit c412383796c used value from wrong enum when setting the disk's

used a value from the wrong enum

> mirrorState variable. This meant that a 'READY' job would show up as
> 'PIVOTING'.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/qemu/qemu_blockjob.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thankfully, not a released regression.

ACK.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list