From nobody Sun Feb 8 20:53:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564002478; cv=none; d=zoho.com; s=zohoarc; b=UCNFxmFZCECj7OXNMCt17RqRxooeWxrHEZam467v577r2gkpiLlA7qAvzZxYz8yPVxGb0c3BFVaEsxezsnobqJS4+HlAVhBLpV+nk548dtqU9X6XP1MBgoRQBexb3VXrGI/oRXrLnigKBq1+aMrQhJTUXkWimzb0hqiOHEcLK+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564002478; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Q7XFypMsdBOAdkH5Wo2nhrSxsfheJvjttfmSnk8M+h8=; b=eKNlboAD++vRGDSdJEltvttOW1rZPNbIKwT+Bvx1UsVYA9xhgnozZD/lDpkp2qcnLXtziV69c2doFx3Lq6xJlpIIlYRk+Kb+dLdwfQpqCmP9GNBf0tlLWRlYjgQk9Rib75vtBJpKKGwi/ONGkpXPD4BCcfgZ5cPUNkF/Ce3e6wM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564002478753460.9202310072917; Wed, 24 Jul 2019 14:07:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF0747FDCC; Wed, 24 Jul 2019 21:07:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85E4519C7F; Wed, 24 Jul 2019 21:07:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F0FB1800202; Wed, 24 Jul 2019 21:07:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6OL7eCP003644 for ; Wed, 24 Jul 2019 17:07:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id C185F5DA34; Wed, 24 Jul 2019 21:07:40 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D3065D967 for ; Wed, 24 Jul 2019 21:07:40 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Wed, 24 Jul 2019 23:07:28 +0200 Message-Id: <07ec26f436ea458cab08ad844a0d1103795bc4f2.1564002117.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/9] qemu: blockjob: Use proper value when setting disk's READY state X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 24 Jul 2019 21:07:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit c412383796c used value from wrong enum when setting the disk's mirrorState variable. This meant that a 'READY' job would show up as 'PIVOTING'. Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index da4f20929b..e63dc49e92 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -723,7 +723,7 @@ qemuBlockJobEventProcess(virQEMUDriverPtr driver, case QEMU_BLOCKJOB_STATE_READY: if (job->disk && job->disk->mirror) { - job->disk->mirrorState =3D VIR_DOMAIN_BLOCK_JOB_READY; + job->disk->mirrorState =3D VIR_DOMAIN_DISK_MIRROR_STATE_READY; qemuBlockJobEmitEvents(driver, vm, job->disk, job->type, job->= newstate); } job->state =3D job->newstate; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list