The flag causes undefine to fail if trying to remove a non-RBD disk. Add
a warning about that.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tools/virsh.pod | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index fd9ba00d1f..11e853deea 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -2936,7 +2936,8 @@ The I<--delete-storage-volume-snapshots> (previously I<--delete-snapshots>)
 flag specifies that any snapshots associated with
 the storage volume should be deleted as well. Requires the
 I<--remove-all-storage> flag to be provided. Not all storage drivers
-support this option, presently only rbd.
+support this option, presently only rbd. Using this when also removing volumes
+handled by storage driver which does not support the flag will result in failure.

 The flag I<--wipe-storage> specifies that the storage volumes should be
 wiped before removal.
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 6/5/19 6:23 AM, Peter Krempa wrote:
> The flag causes undefine to fail if trying to remove a non-RBD disk. Add
> a warning about that.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tools/virsh.pod | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index fd9ba00d1f..11e853deea 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -2936,7 +2936,8 @@ The I<--delete-storage-volume-snapshots> (previously I<--delete-snapshots>)
>  flag specifies that any snapshots associated with
>  the storage volume should be deleted as well. Requires the
>  I<--remove-all-storage> flag to be provided. Not all storage drivers
> -support this option, presently only rbd.
> +support this option, presently only rbd. Using this when also removing volumes
> +handled by storage driver which does not support the flag will result in failure.

s/by/by a/

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list